You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Mark Wang <ma...@gmail.com> on 2015/07/06 20:02:21 UTC

Re: Review Request 35285: Rename Option::get(const T& _t) to getOrElse() and refactor original functions (mesos)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35285/
-----------------------------------------------------------

(Updated July 6, 2015, 6:02 p.m.)


Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-2800
    https://issues.apache.org/jira/browse/MESOS-2800


Repository: mesos


Description
-------

Rename Option<T>::get(const T& _t) to getOrElse() and refactor original functions (mesos)


Diffs (updated)
-----

  src/log/catchup.cpp f7afc38916d0a7e57cdecb0da7ccb3901e726b90 
  src/master/main.cpp 2624b7ea4920a534c98f5dfbf9286c54c50f11a9 
  src/master/master.hpp fb4d6fac85e284987ec8fbf6949b5023875573fb 
  src/slave/containerizer/containerizer.cpp b9ac94c59fdc229516d1ae193992ce0cf8ff96be 
  src/tests/cluster.hpp cfe7ef0c7a6dc62cddc3e5f5b5b28c8bcb2bed26 

Diff: https://reviews.apache.org/r/35285/diff/


Testing
-------

make check


Thanks,

Mark Wang

Re: Review Request 35285: Rename Option::get(const T& _t) to getOrElse() and refactor original functions (mesos)

Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35285/#review90538
-----------------------------------------------------------

Ship it!


Ship It!

- Joris Van Remoortere


On July 6, 2015, 6:47 p.m., Mark Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35285/
> -----------------------------------------------------------
> 
> (Updated July 6, 2015, 6:47 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2800
>     https://issues.apache.org/jira/browse/MESOS-2800
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Rename Option<T>::get(const T& _t) to getOrElse() and refactor original functions (mesos)
> 
> 
> Diffs
> -----
> 
>   src/log/catchup.cpp f7afc38916d0a7e57cdecb0da7ccb3901e726b90 
>   src/master/main.cpp 2624b7ea4920a534c98f5dfbf9286c54c50f11a9 
>   src/master/master.hpp fb4d6fac85e284987ec8fbf6949b5023875573fb 
>   src/slave/containerizer/containerizer.cpp b9ac94c59fdc229516d1ae193992ce0cf8ff96be 
>   src/tests/cluster.hpp cfe7ef0c7a6dc62cddc3e5f5b5b28c8bcb2bed26 
> 
> Diff: https://reviews.apache.org/r/35285/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Mark Wang
> 
>

Re: Review Request 35285: Rename Option::get(const T& _t) to getOrElse() and refactor original functions (mesos)

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35285/#review90547
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On July 6, 2015, 6:47 p.m., Mark Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35285/
> -----------------------------------------------------------
> 
> (Updated July 6, 2015, 6:47 p.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-2800
>     https://issues.apache.org/jira/browse/MESOS-2800
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Rename Option<T>::get(const T& _t) to getOrElse() and refactor original functions (mesos)
> 
> 
> Diffs
> -----
> 
>   src/log/catchup.cpp f7afc38916d0a7e57cdecb0da7ccb3901e726b90 
>   src/master/main.cpp 2624b7ea4920a534c98f5dfbf9286c54c50f11a9 
>   src/master/master.hpp fb4d6fac85e284987ec8fbf6949b5023875573fb 
>   src/slave/containerizer/containerizer.cpp b9ac94c59fdc229516d1ae193992ce0cf8ff96be 
>   src/tests/cluster.hpp cfe7ef0c7a6dc62cddc3e5f5b5b28c8bcb2bed26 
> 
> Diff: https://reviews.apache.org/r/35285/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Mark Wang
> 
>

Re: Review Request 35285: Rename Option::get(const T& _t) to getOrElse() and refactor original functions (mesos)

Posted by Mark Wang <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35285/
-----------------------------------------------------------

(Updated July 6, 2015, 6:47 p.m.)


Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-2800
    https://issues.apache.org/jira/browse/MESOS-2800


Repository: mesos


Description
-------

Rename Option<T>::get(const T& _t) to getOrElse() and refactor original functions (mesos)


Diffs
-----

  src/log/catchup.cpp f7afc38916d0a7e57cdecb0da7ccb3901e726b90 
  src/master/main.cpp 2624b7ea4920a534c98f5dfbf9286c54c50f11a9 
  src/master/master.hpp fb4d6fac85e284987ec8fbf6949b5023875573fb 
  src/slave/containerizer/containerizer.cpp b9ac94c59fdc229516d1ae193992ce0cf8ff96be 
  src/tests/cluster.hpp cfe7ef0c7a6dc62cddc3e5f5b5b28c8bcb2bed26 

Diff: https://reviews.apache.org/r/35285/diff/


Testing
-------

make check


Thanks,

Mark Wang

Re: Review Request 35285: Rename Option::get(const T& _t) to getOrElse() and refactor original functions (mesos)

Posted by Mark Wang <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35285/
-----------------------------------------------------------

(Updated July 6, 2015, 6:45 p.m.)


Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-2800
    https://issues.apache.org/jira/browse/MESOS-2800


Repository: mesos


Description
-------

Rename Option<T>::get(const T& _t) to getOrElse() and refactor original functions (mesos)


Diffs (updated)
-----

  src/log/catchup.cpp f7afc38916d0a7e57cdecb0da7ccb3901e726b90 
  src/master/main.cpp 2624b7ea4920a534c98f5dfbf9286c54c50f11a9 
  src/master/master.hpp fb4d6fac85e284987ec8fbf6949b5023875573fb 
  src/slave/containerizer/containerizer.cpp b9ac94c59fdc229516d1ae193992ce0cf8ff96be 
  src/tests/cluster.hpp cfe7ef0c7a6dc62cddc3e5f5b5b28c8bcb2bed26 

Diff: https://reviews.apache.org/r/35285/diff/


Testing
-------

make check


Thanks,

Mark Wang

Re: Review Request 35285: Rename Option::get(const T& _t) to getOrElse() and refactor original functions (mesos)

Posted by Mark Wang <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35285/
-----------------------------------------------------------

(Updated July 6, 2015, 6:33 p.m.)


Review request for mesos and Joris Van Remoortere.


Bugs: MESOS-2800
    https://issues.apache.org/jira/browse/MESOS-2800


Repository: mesos


Description
-------

Rename Option<T>::get(const T& _t) to getOrElse() and refactor original functions (mesos)


Diffs
-----

  src/log/catchup.cpp f7afc38916d0a7e57cdecb0da7ccb3901e726b90 
  src/master/main.cpp 2624b7ea4920a534c98f5dfbf9286c54c50f11a9 
  src/master/master.hpp fb4d6fac85e284987ec8fbf6949b5023875573fb 
  src/slave/containerizer/containerizer.cpp b9ac94c59fdc229516d1ae193992ce0cf8ff96be 
  src/tests/cluster.hpp cfe7ef0c7a6dc62cddc3e5f5b5b28c8bcb2bed26 

Diff: https://reviews.apache.org/r/35285/diff/


Testing
-------

make check


Thanks,

Mark Wang