You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by zh...@apache.org on 2023/04/03 08:11:30 UTC
[doris] 02/03: [fix](merge-on-write) fix that missed rows don't match merged rows for base compaction (#18262)
This is an automated email from the ASF dual-hosted git repository.
zhangchen pushed a commit to branch branch-1.2-lts
in repository https://gitbox.apache.org/repos/asf/doris.git
commit 4c22234520fd0418a17158c78105f38cbaa1a177
Author: Xin Liao <li...@126.com>
AuthorDate: Fri Mar 31 15:06:51 2023 +0800
[fix](merge-on-write) fix that missed rows don't match merged rows for base compaction (#18262)
---
be/src/olap/compaction.cpp | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/be/src/olap/compaction.cpp b/be/src/olap/compaction.cpp
index 48ef55c347..c154667e6e 100644
--- a/be/src/olap/compaction.cpp
+++ b/be/src/olap/compaction.cpp
@@ -473,10 +473,12 @@ Status Compaction::modify_rowsets(const Merger::Statistics* stats) {
_tablet->calc_compaction_output_rowset_delete_bitmap(
_input_rowsets, _rowid_conversion, version.second, UINT64_MAX, &missed_rows,
&location_map, &output_rowset_delete_bitmap);
- DCHECK_EQ(missed_rows.size(), missed_rows_size);
- if (missed_rows.size() != missed_rows_size) {
- LOG(WARNING) << "missed rows don't match, before: " << missed_rows_size
- << " after: " << missed_rows.size();
+ if (compaction_type() == READER_CUMULATIVE_COMPACTION) {
+ DCHECK_EQ(missed_rows.size(), missed_rows_size);
+ if (missed_rows.size() != missed_rows_size) {
+ LOG(WARNING) << "missed rows don't match, before: " << missed_rows_size
+ << " after: " << missed_rows.size();
+ }
}
RETURN_IF_ERROR(_tablet->check_rowid_conversion(_output_rowset, location_map));
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org