You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/10/14 14:28:40 UTC
[GitHub] [netbeans] junichi11 opened a new pull request #2456: [NETBEANS-4443] PHP 8.0 Support
junichi11 opened a new pull request #2456:
URL: https://github.com/apache/netbeans/pull/2456
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #2456: [NETBEANS-4443] PHP 8.0 Support
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #2456:
URL: https://github.com/apache/netbeans/pull/2456#issuecomment-708669336
We can merge this one, once Travis would agree. If the major infrastructure changes has happened here and there is a need for some polish, that can be introduced as PR-s on the upcoming delivery branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #2456: [NETBEANS-4443] PHP 8.0 Support
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2456:
URL: https://github.com/apache/netbeans/pull/2456#issuecomment-708934835
Created the new PR: https://github.com/apache/netbeans/pull/2457
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #2456: [NETBEANS-4443] PHP 8.0 Support
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2456:
URL: https://github.com/apache/netbeans/pull/2456#issuecomment-708908236
@lkishalmi This branch was created before 12.1 was released. So, maybe conflict would occur in this PR, I suppose. I didn't fix it to avoid that. Can I rebase this branch(it is in not forked repository but the apach/netbeans) with the master branch then fix the spec version then force-push it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 closed pull request #2456: [NETBEANS-4443] PHP 8.0 Support
Posted by GitBox <gi...@apache.org>.
junichi11 closed pull request #2456:
URL: https://github.com/apache/netbeans/pull/2456
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #2456: [NETBEANS-4443] PHP 8.0 Support
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2456:
URL: https://github.com/apache/netbeans/pull/2456#issuecomment-708915799
@lkishalmi I'll close this then recreate a PR from my repository.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 edited a comment on pull request #2456: [NETBEANS-4443] PHP 8.0 Support
Posted by GitBox <gi...@apache.org>.
junichi11 edited a comment on pull request #2456:
URL: https://github.com/apache/netbeans/pull/2456#issuecomment-708908236
@lkishalmi This branch was created before 12.1 was released. So, maybe conflict would occur in this PR, I suppose. I didn't fix it to avoid that. Can I rebase this branch(it is in not forked repository but the apach/netbeans) with the master branch then fix the spec version then **force**-push it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] lkishalmi commented on pull request #2456: [NETBEANS-4443] PHP 8.0 Support
Posted by GitBox <gi...@apache.org>.
lkishalmi commented on pull request #2456:
URL: https://github.com/apache/netbeans/pull/2456#issuecomment-708903008
please fix the spec versions in this PR. Master will receive a spec version bump after branching for the release. It would be really appreciated if I do not have to merge spec version changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #2456: [NETBEANS-4443] PHP 8.0 Support
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2456:
URL: https://github.com/apache/netbeans/pull/2456#issuecomment-708446438
@lkishalmi I've not implemented all features for PHP 8.0 yet. (Some syntaxes are not supported yet.) But feature freeze is tomorrow, right? Should we merge these into the master once at the moment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #2456: [NETBEANS-4443] PHP 8.0 Support
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #2456:
URL: https://github.com/apache/netbeans/pull/2456#issuecomment-708873763
@lkishalmi I see. Thanks!
@tmysik I haven't finished PHP 8.0 support (we have to implement new some syntaxes yet), but let's merge this into the master branch once. I'm going to fix the spec version after this is merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists