You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by "Philip M. Gollucci" <pg...@p6m7g8.com> on 2005/04/05 09:24:08 UTC
TEST results
FreeBSD 6.0-current/i386
perl 5.9.3 w/out threads
httpd2, apr/apr-uti, modperl from svn trunk
Attached are
tests.log (the output of make test only interesting parts)
verbose.log (make test TEST_VERBOSE=1 for the failed tests)
verbose_error_log.txt (t/logs/error_log from above)
All the ModPerl-Registry tests pass except for 2 skipped from
ithreads and CGI.pm-3.08
Failed Test Stat Wstat Total Fail Failed List of
Failed
-------------------------------------------------------------------------------
t/apache/content_length_header.t 27 3 11.11% 2 5 17
t/protocol/eliza.t 7 4 57.14% 3-6
16 tests skipped.
Failed 2/228 test scripts, 99.12% okay. 7/2328 subtests failed, 99.70% okay.
I saw a lot of Apache2 stuff in the install lines during make install..
shouldn't it be gone ?
Overall thats an incredibly awesome success rate for all the changes
that just happened. Keep up the great work!
END
------------------------------------------------------------------------------
Philip M. Gollucci
Consultant
E-Mail: pgollucci@p6m7g8.com
URL : http://p6m7g8.net/Resume/resume.shtml
Phone : 301.254.5198
$Id: .signature,v 1.7 2004/09/05 23:46:37 philip Exp $
Re: TEST results
Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
> This should fix the problem. I've committed it already.
>
> Index: t/protocol/TestProtocol/eliza.pm
> ===================================================================
> --- t/protocol/TestProtocol/eliza.pm (revision 160192)
> +++ t/protocol/TestProtocol/eliza.pm (working copy)
> @@ -18,6 +18,17 @@
> my Apache2::Connection $c = shift;
> my APR::Socket $socket = $c->client_socket;
>
> + # starting from Apache 2.0.49 several platforms require you to set
> + # the socket to a blocking IO mode
> + my $nonblocking = $socket->opt_get(APR::Const::SO_NONBLOCK);
> + if ($nonblocking) {
> + $socket->opt_set(APR::Const::SO_NONBLOCK, 0);
> +
> + # test that we really *are* in the blocking mode
> + !$socket->opt_get(APR::Const::SO_NONBLOCK)
> + or die "failed to set blocking mode";
> + }
> +
> my $last = 0;
> while ($socket->recv(my $buff, BUFF_LEN)) {
> # \r is sent instead of \n if the client is talking over telnet
Yep that fixed it !
--
END
------------------------------------------------------------------------------
Philip M. Gollucci
Consultant
E-Mail: pgollucci@p6m7g8.com
URL : http://p6m7g8.net/Resume/resume.shtml
Phone : 301.254.5198
$Id: .signature,v 1.7 2004/09/05 23:46:37 philip Exp $
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: TEST results
Posted by Stas Bekman <st...@stason.org>.
Philip M. Gollucci wrote:
> FreeBSD 6.0-current/i386
> perl 5.9.3 w/out threads
> httpd2, apr/apr-uti, modperl from svn trunk
[...]
> t/protocol/eliza..................1..7
> # Running under perl version 5.009003 for freebsd
> # Current time local: Tue Apr 5 03:13:06 2005
> # Current time GMT: Tue Apr 5 07:13:06 2005
> # Using Test.pm version 1.25
> # Using Apache/Test.pm version 1.22
> ok 1
> # send: Hello Eliza
> # recv: How do you do. Please state your problem.
> ok 2
> # send: How are you?
> # recv:
> # Failed test 3 in t/protocol/eliza.t at line 25 fail #2
> not ok 3
> # Failed test 4 in t/protocol/eliza.t at line 25 fail #3
> # send: Why do I have core dumped?
> # recv:
> # Failed test 5 in t/protocol/eliza.t at line 25 fail #4
> not ok 4
> # send: I feel like writing some tests today, what about you?
> # Failed test 6 in t/protocol/eliza.t at line 25 fail #5
> # recv:
> not ok 5
> # send: Good bye, Eliza
> # recv:
> not ok 6
> # Eliza shouldn't respond anymore
> ok 7
> FAILED tests 3-6
> Failed 4/7 tests, 42.86% okay
This should fix the problem. I've committed it already.
Index: t/protocol/TestProtocol/eliza.pm
===================================================================
--- t/protocol/TestProtocol/eliza.pm (revision 160192)
+++ t/protocol/TestProtocol/eliza.pm (working copy)
@@ -18,6 +18,17 @@
my Apache2::Connection $c = shift;
my APR::Socket $socket = $c->client_socket;
+ # starting from Apache 2.0.49 several platforms require you to set
+ # the socket to a blocking IO mode
+ my $nonblocking = $socket->opt_get(APR::Const::SO_NONBLOCK);
+ if ($nonblocking) {
+ $socket->opt_set(APR::Const::SO_NONBLOCK, 0);
+
+ # test that we really *are* in the blocking mode
+ !$socket->opt_get(APR::Const::SO_NONBLOCK)
+ or die "failed to set blocking mode";
+ }
+
my $last = 0;
while ($socket->recv(my $buff, BUFF_LEN)) {
# \r is sent instead of \n if the client is talking over telnet
--
__________________________________________________________________
Stas Bekman JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/ mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org http://ticketmaster.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: TEST results
Posted by "Philip M. Gollucci" <pg...@p6m7g8.com>.
Geoffrey Young wrote:
>if you're using httpd 2.1 (svn trunk) then that's probably the issue - this
>test tests properties of the httpd server just so we can make note when it
>changes behaviors on us.
>
>
>
I'll check it out soonish.
>hopefully stas has an idea about this one :)
>
>
>
Stas commited a fix... I'll test tonight.
>>I saw a lot of Apache2 stuff in the install lines during make install..
>>shouldn't it be gone ?
>>
>>
I'll get some details.. Thanks.
--
END
-----------------------------------------------------------------------------
Philip M. Gollucci
Senior Developer - Liquidity Services Inc.
Phone: 202.568.6268 (Direct)
E-Mail: pgollucci@liquidation.com
Web: http://www.liquidation.com
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: TEST results
Posted by Geoffrey Young <ge...@modperlcookbook.org>.
> httpd2, apr/apr-uti, modperl from svn trunk
> -------------------------------------------------------------------------------
>
> t/apache/content_length_header.t 27 3 11.11% 2 5 17
if you're using httpd 2.1 (svn trunk) then that's probably the issue - this
test tests properties of the httpd server just so we can make note when it
changes behaviors on us.
so, it's something for us to look into, but 2.1 isn't really officially
supported at the moment, so no biggie.
> t/protocol/eliza.t 7 4 57.14% 3-6
hopefully stas has an idea about this one :)
> I saw a lot of Apache2 stuff in the install lines during make install..
> shouldn't it be gone ?
that depends. can you be more specific? what was explicitly removed was an
isntall into, say, Apache2/Apache/RequestRec.pm. the proper path is now
Apache2/RequestRec.pm, so Apache2/ isn't gone, per-se, it's just become
officially present and non-invisible :)
>
> Overall thats an incredibly awesome success rate for all the changes
> that just happened. Keep up the great work!
thanks. and thanks for testing - it's good to know that folks other than
the developers are taking it for a spin and helping to catch problems.
--Geoff
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org