[GitHub] [spark] LuciferYang commented on a diff in pull request #37400: [SPARK-39957][CORE] Delay onDisconnected to enable Driver receives ExecutorExitCode

["LuciferYang (via GitHub)" <gi...@apache.org>]

LuciferYang commented on code in PR #37400:
URL: https://github.com/apache/spark/pull/37400#discussion_r1148842933


##########
core/src/main/scala/org/apache/spark/scheduler/cluster/StandaloneSchedulerBackend.scala:
##########
@@ -272,4 +285,66 @@ private[spark] class StandaloneSchedulerBackend(
     }
   }
 
+  override def createDriverEndpoint(): DriverEndpoint = {
+    new StandaloneDriverEndpoint()
+  }
+
+  private class StandaloneDriverEndpoint extends DriverEndpoint {
+    // [SC-104659]: There are two paths to detect executor loss.

Review Comment:
   @kevin85421 Sorry to bother you, but can you explain what `SC-104659` and `SC-104335` mean? This seems doesn't Spark jira. Thanks ~
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org