You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org> on 2023/05/09 13:48:02 UTC
[GitHub] [apisix-dashboard] monkeyDluffy6017 opened a new pull request, #2801: feat: disable route export openapi func
monkeyDluffy6017 opened a new pull request, #2801:
URL: https://github.com/apache/apisix-dashboard/pull/2801
Please answer these questions before submitting a pull request, **or your PR will get closed**.
**Why submit this pull request?**
- [ ] Bugfix
- [x] New feature provided
- [ ] Improve performance
- [ ] Backport patches
**What changes will this PR take into?**
The export openapi func doesn't work well, we need to disable it for now
**Related issues**
fix/resolve #0001
**Checklist:**
- [x] Did you explain what problem does this PR solve? Or what new features have been added?
- [x] Have you added corresponding test cases?
- [x] Have you modified the corresponding document?
- [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on a diff in pull request #2801: feat: disable route export openapi func
Posted by "guoqqqi (via GitHub)" <gi...@apache.org>.
guoqqqi commented on code in PR #2801:
URL: https://github.com/apache/apisix-dashboard/pull/2801#discussion_r1189276635
##########
web/yarn.lock:
##########
Review Comment:
We do not need to submit this file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] 0xdeadbeer commented on pull request #2801: feat: disable route export openapi func
Posted by "0xdeadbeer (via GitHub)" <gi...@apache.org>.
0xdeadbeer commented on PR #2801:
URL: https://github.com/apache/apisix-dashboard/pull/2801#issuecomment-1657829543
> **What changes will this PR take into?**
> The export openapi func doesn't work well, we need to disable it for now
May I ask what you're referring to with "doesn't work well"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2801: feat: disable route export openapi func
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2801:
URL: https://github.com/apache/apisix-dashboard/pull/2801#issuecomment-1540283921
## [Codecov](https://app.codecov.io/gh/apache/apisix-dashboard/pull/2801?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2801](https://app.codecov.io/gh/apache/apisix-dashboard/pull/2801?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3605145) into [master](https://app.codecov.io/gh/apache/apisix-dashboard/commit/8390d3dfd53bae19fc31e5dbc8753882e69a8ff3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8390d3d) will **decrease** coverage by `20.60%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 3605145 differs from pull request most recent head b53325e. Consider uploading reports for the commit b53325e to get more accurate results
```diff
@@ Coverage Diff @@
## master #2801 +/- ##
===========================================
- Coverage 68.61% 48.01% -20.60%
===========================================
Files 139 46 -93
Lines 3769 3145 -624
Branches 883 0 -883
===========================================
- Hits 2586 1510 -1076
- Misses 1183 1450 +267
- Partials 0 185 +185
```
| Flag | Coverage Δ | |
|---|---|---|
| backend-unit-test | `48.01% <ø> (?)` | |
| frontend-e2e-test | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 185 files with indirect coverage changes](https://app.codecov.io/gh/apache/apisix-dashboard/pull/2801/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] bzp2010 commented on pull request #2801: feat: disable route export openapi func
Posted by "bzp2010 (via GitHub)" <gi...@apache.org>.
bzp2010 commented on PR #2801:
URL: https://github.com/apache/apisix-dashboard/pull/2801#issuecomment-1543037858
@monkeyDluffy6017 Maybe just comment it rather than delete them？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] monkeyDluffy6017 commented on pull request #2801: feat: disable route export openapi func
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on PR #2801:
URL: https://github.com/apache/apisix-dashboard/pull/2801#issuecomment-1549111584
> @monkeyDluffy6017 Maybe just comment it rather than delete them？
We don't know when this functionality will be added back, and it's not aesthetically pleasing to have so much code commented out in the project
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org