[Impala-ASF-CR] IMPALA-11542: Implement pre-allocation in LLVM memory manager

["Michael Smith (Code Review)" <ge...@cloudera.org>]

Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20692 )

Change subject: IMPALA-11542: Implement pre-allocation in LLVM memory manager
......................................................................


Patch Set 13:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/20692/13/be/src/thirdparty/llvm/SectionMemoryManager.h
File be/src/thirdparty/llvm/SectionMemoryManager.h:

http://gerrit.cloudera.org:8080/#/c/20692/13/be/src/thirdparty/llvm/SectionMemoryManager.h@55
PS13, Line 55:   bool needsToReserveAllocationSpace() override { return true; }
> The other option would be to only enable it on aarch64, which would limit t
I think this is pretty low risk, going to ignore it.



-- 
To view, visit http://gerrit.cloudera.org:8080/20692
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f224edcdbdcb05fce663c18b4a5f03c8e985675
Gerrit-Change-Number: 20692
Gerrit-PatchSet: 13
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wy...@gmail.com>
Gerrit-Comment-Date: Fri, 01 Dec 2023 18:03:08 +0000
Gerrit-HasComments: Yes