You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@atlas.apache.org by Sarath Subramanian <sa...@apache.org> on 2018/06/08 22:50:52 UTC

Review Request 67514: ATLAS-2751: Atlas is not consuming messages from ATLAS_HOOK topic after recovering from zookeeper connection timeout.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67514/
-----------------------------------------------------------

Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.


Bugs: ATLAS-2751
    https://issues.apache.org/jira/browse/ATLAS-2751


Repository: atlas


Description
-------

Atlas is not consuming messages from ATLAS_HOOK topic after recovering from zookeeper connection timeout.


Diffs
-----

  notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 00e56e33f 


Diff: https://reviews.apache.org/r/67514/diff/1/


Testing
-------

Manually tested in HA cluster toggling active and passive state. consumers process hook messages.

https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/474/console


Thanks,

Sarath Subramanian

Re: Review Request 67514: ATLAS-2751: Atlas is not consuming messages from ATLAS_HOOK topic after recovering from zookeeper connection timeout.

Posted by Ashutosh Mestry <am...@hortonworks.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67514/#review204508
-----------------------------------------------------------


Ship it!




Ship It!

- Ashutosh Mestry


On June 8, 2018, 10:50 p.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67514/
> -----------------------------------------------------------
> 
> (Updated June 8, 2018, 10:50 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-2751
>     https://issues.apache.org/jira/browse/ATLAS-2751
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Atlas is not consuming messages from ATLAS_HOOK topic after recovering from zookeeper connection timeout.
> 
> 
> Diffs
> -----
> 
>   notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 00e56e33f 
> 
> 
> Diff: https://reviews.apache.org/r/67514/diff/1/
> 
> 
> Testing
> -------
> 
> Manually tested in HA cluster toggling active and passive state. consumers process hook messages.
> 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/474/console
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>

Re: Review Request 67514: ATLAS-2751: Atlas is not consuming messages from ATLAS_HOOK topic after recovering from zookeeper connection timeout.

Posted by Madhan Neethiraj <ma...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67514/#review204526
-----------------------------------------------------------


Ship it!




- Madhan Neethiraj


On June 9, 2018, 4:36 a.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67514/
> -----------------------------------------------------------
> 
> (Updated June 9, 2018, 4:36 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-2751
>     https://issues.apache.org/jira/browse/ATLAS-2751
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Atlas is not consuming messages from ATLAS_HOOK topic after recovering from zookeeper connection timeout.
> 
> 
> Diffs
> -----
> 
>   notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 00e56e33f 
> 
> 
> Diff: https://reviews.apache.org/r/67514/diff/2/
> 
> 
> Testing
> -------
> 
> Manually tested in HA cluster toggling active and passive state. consumers process hook messages.
> 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/474/console
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>

Re: Review Request 67514: ATLAS-2751: Atlas is not consuming messages from ATLAS_HOOK topic after recovering from zookeeper connection timeout.

Posted by Sarath Subramanian <sa...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67514/
-----------------------------------------------------------

(Updated June 8, 2018, 9:36 p.m.)


Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.


Changes
-------

addressed review comments.


Bugs: ATLAS-2751
    https://issues.apache.org/jira/browse/ATLAS-2751


Repository: atlas


Description
-------

Atlas is not consuming messages from ATLAS_HOOK topic after recovering from zookeeper connection timeout.


Diffs (updated)
-----

  notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 00e56e33f 


Diff: https://reviews.apache.org/r/67514/diff/2/

Changes: https://reviews.apache.org/r/67514/diff/1-2/


Testing
-------

Manually tested in HA cluster toggling active and passive state. consumers process hook messages.

https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/474/console


Thanks,

Sarath Subramanian

Re: Review Request 67514: ATLAS-2751: Atlas is not consuming messages from ATLAS_HOOK topic after recovering from zookeeper connection timeout.

Posted by Madhan Neethiraj <ma...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67514/#review204516
-----------------------------------------------------------



Would it help to update stop() to set consumer=null and producer=null?


notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java
Line 226 (original), 226 (patched)
<https://reviews.apache.org/r/67514/#comment287037>

    "consumer != null" doesn't seem necessary here.



notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java
Lines 298 (patched)
<https://reviews.apache.org/r/67514/#comment287035>

    Consider reading this string from a configuration - like:
      atlas.kafka.error.message.consumer_closed=This consumer has already been closed."
      
    This can handling of Kafka message changes easier.


- Madhan Neethiraj


On June 8, 2018, 10:50 p.m., Sarath Subramanian wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67514/
> -----------------------------------------------------------
> 
> (Updated June 8, 2018, 10:50 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Nixon Rodrigues.
> 
> 
> Bugs: ATLAS-2751
>     https://issues.apache.org/jira/browse/ATLAS-2751
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Atlas is not consuming messages from ATLAS_HOOK topic after recovering from zookeeper connection timeout.
> 
> 
> Diffs
> -----
> 
>   notification/src/main/java/org/apache/atlas/kafka/KafkaNotification.java 00e56e33f 
> 
> 
> Diff: https://reviews.apache.org/r/67514/diff/1/
> 
> 
> Testing
> -------
> 
> Manually tested in HA cluster toggling active and passive state. consumers process hook messages.
> 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/474/console
> 
> 
> Thanks,
> 
> Sarath Subramanian
> 
>