You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2014/11/06 18:33:26 UTC

Review Request 27689: Download client configs gives incorrect content for certain components

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27689/
-----------------------------------------------------------

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-8187
    https://issues.apache.org/jira/browse/AMBARI-8187


Repository: ambari


Description
-------

**HDP-2.1**

  1. FALCON_CLIENT - `.properties` files have XML content
  2. SQOOP_CLIENT - No `sqoop-site.xml` file
  3. HBASE_CLIENT - No `hbase-policy.xml` file


Diffs
-----

  ambari-common/src/main/python/resource_management/libraries/script/script.py 4caaa78 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java 339ebc4 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/metainfo.xml 0816591 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/metainfo.xml b4e6883 

Diff: https://reviews.apache.org/r/27689/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 27689: Download client configs gives incorrect content for certain components

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27689/#review60194
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On Nov. 6, 2014, 5:47 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27689/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2014, 5:47 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-8187
>     https://issues.apache.org/jira/browse/AMBARI-8187
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> **HDP-2.1**
> 
>   1. FALCON_CLIENT - `.properties` files have XML content
>   2. SQOOP_CLIENT - No `sqoop-site.xml` file
>   3. HBASE_CLIENT - No `hbase-policy.xml` file
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 4caaa78 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java 339ebc4 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/metainfo.xml 0816591 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/metainfo.xml b4e6883 
>   ambari-server/src/test/python/stacks/1.3.2/HDFS/test_hdfs_client.py 80da9b6 
>   ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_client.py 2081c36 
>   ambari-server/src/test/python/stacks/1.3.2/configs/default.json 0256444 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_hdfs_client.py 0a4bfb5 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json 2dc4a8d 
> 
> Diff: https://reviews.apache.org/r/27689/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 27689: Download client configs gives incorrect content for certain components

Posted by Vitalyi Brodetskyi <vb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27689/#review60196
-----------------------------------------------------------

Ship it!


Ship It!

- Vitalyi Brodetskyi


On Лис. 6, 2014, 5:47 після полудня, Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27689/
> -----------------------------------------------------------
> 
> (Updated Лис. 6, 2014, 5:47 після полудня)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-8187
>     https://issues.apache.org/jira/browse/AMBARI-8187
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> **HDP-2.1**
> 
>   1. FALCON_CLIENT - `.properties` files have XML content
>   2. SQOOP_CLIENT - No `sqoop-site.xml` file
>   3. HBASE_CLIENT - No `hbase-policy.xml` file
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 4caaa78 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java 339ebc4 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/metainfo.xml 0816591 
>   ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/metainfo.xml b4e6883 
>   ambari-server/src/test/python/stacks/1.3.2/HDFS/test_hdfs_client.py 80da9b6 
>   ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_client.py 2081c36 
>   ambari-server/src/test/python/stacks/1.3.2/configs/default.json 0256444 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_hdfs_client.py 0a4bfb5 
>   ambari-server/src/test/python/stacks/2.0.6/configs/default.json 2dc4a8d 
> 
> Diff: https://reviews.apache.org/r/27689/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>


Re: Review Request 27689: Download client configs gives incorrect content for certain components

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27689/
-----------------------------------------------------------

(Updated Nov. 6, 2014, 5:47 p.m.)


Review request for Ambari, Dmitro Lisnichenko and Vitalyi Brodetskyi.


Bugs: AMBARI-8187
    https://issues.apache.org/jira/browse/AMBARI-8187


Repository: ambari


Description
-------

**HDP-2.1**

  1. FALCON_CLIENT - `.properties` files have XML content
  2. SQOOP_CLIENT - No `sqoop-site.xml` file
  3. HBASE_CLIENT - No `hbase-policy.xml` file


Diffs (updated)
-----

  ambari-common/src/main/python/resource_management/libraries/script/script.py 4caaa78 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java 339ebc4 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/metainfo.xml 0816591 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/metainfo.xml b4e6883 
  ambari-server/src/test/python/stacks/1.3.2/HDFS/test_hdfs_client.py 80da9b6 
  ambari-server/src/test/python/stacks/1.3.2/MAPREDUCE/test_mapreduce_client.py 2081c36 
  ambari-server/src/test/python/stacks/1.3.2/configs/default.json 0256444 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_hdfs_client.py 0a4bfb5 
  ambari-server/src/test/python/stacks/2.0.6/configs/default.json 2dc4a8d 

Diff: https://reviews.apache.org/r/27689/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 27689: Download client configs gives incorrect content for certain components

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27689/
-----------------------------------------------------------

(Updated Nov. 6, 2014, 5:47 p.m.)


Review request for Ambari, Dmitro Lisnichenko and Vitalyi Brodetskyi.


Bugs: AMBARI-8187
    https://issues.apache.org/jira/browse/AMBARI-8187


Repository: ambari


Description
-------

**HDP-2.1**

  1. FALCON_CLIENT - `.properties` files have XML content
  2. SQOOP_CLIENT - No `sqoop-site.xml` file
  3. HBASE_CLIENT - No `hbase-policy.xml` file


Diffs
-----

  ambari-common/src/main/python/resource_management/libraries/script/script.py 4caaa78 
  ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java 339ebc4 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/HBASE/metainfo.xml 0816591 
  ambari-server/src/main/resources/stacks/HDP/2.1/services/FALCON/metainfo.xml b4e6883 

Diff: https://reviews.apache.org/r/27689/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk