You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "xishuaidelin (via GitHub)" <gi...@apache.org> on 2025/04/09 10:43:59 UTC

[PR] [FLINK-37640][table-planner] Fix timestamp_ltz is converted timestamp in scan reuse [flink]

xishuaidelin opened a new pull request, #26430:
URL: https://github.com/apache/flink/pull/26430

   … in scan reuse
   
   <!--
   *Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   *Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   *(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)*
   
   
   ## Brief change log
   
   *(for example:)*
     - *The TaskInfo is stored in the blob store on job creation time as a persistent artifact*
     - *Deployments RPC transmits only the blob storage reference*
     - *TaskManagers retrieve the TaskInfo from the blob cache*
   
   
   ## Verifying this change
   
   Please make sure both new and modified tests in this PR follow [the conventions for tests defined in our code quality guide](https://flink.apache.org/how-to-contribute/code-style-and-quality-common/#7-testing).
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (100MB)*
     - *Extended integration test for recovery after master (JobManager) failure*
     - *Added test that validates that TaskInfo is transferred only once across recoveries*
     - *Manually verified the change by running a 4 node cluster with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.*
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / no)
     - The serializers: (yes / no / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / no / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
     - The S3 file system connector: (yes / no / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37640][table-planner] Fix timestamp_ltz is converted timestamp in scan reuse [flink]

Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #26430:
URL: https://github.com/apache/flink/pull/26430#discussion_r2035559270


##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/reuse/ScanReuserUtils.java:
##########
@@ -203,7 +204,13 @@ private static WatermarkPushDownSpec adjustWatermarkIndex(
                 String name = newFieldNames.get(i);
                 LogicalType type = newSourceType.getTypeAt(i);
                 if (name.equals(rowtimeColumn)) {
-                    type = new TimestampType(type.isNullable(), TimestampKind.ROWTIME, 3);
+                    if (type instanceof LocalZonedTimestampType) {

Review Comment:
   do we need to check for `ZonedTimestampType` as well? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37640][table-planner] Fix timestamp_ltz is converted timestamp in scan reuse [flink]

Posted by "xuyangzhong (via GitHub)" <gi...@apache.org>.
xuyangzhong merged PR #26430:
URL: https://github.com/apache/flink/pull/26430


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37640][table-planner] Fix timestamp_ltz is converted timestamp in scan reuse [flink]

Posted by "xishuaidelin (via GitHub)" <gi...@apache.org>.
xishuaidelin commented on code in PR #26430:
URL: https://github.com/apache/flink/pull/26430#discussion_r2045869371


##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/reuse/ScanReuserUtils.java:
##########
@@ -203,7 +204,13 @@ private static WatermarkPushDownSpec adjustWatermarkIndex(
                 String name = newFieldNames.get(i);
                 LogicalType type = newSourceType.getTypeAt(i);
                 if (name.equals(rowtimeColumn)) {
-                    type = new TimestampType(type.isNullable(), TimestampKind.ROWTIME, 3);
+                    if (type instanceof LocalZonedTimestampType) {

Review Comment:
   Sorry for my late reply. Actually Flink SQL currently only supports local time zone and without time zone data types while others would not be parsed successfully. So we don’t need to worry about this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37640][table-planner] Fix timestamp_ltz is converted timestamp in scan reuse [flink]

Posted by "xishuaidelin (via GitHub)" <gi...@apache.org>.
xishuaidelin commented on code in PR #26430:
URL: https://github.com/apache/flink/pull/26430#discussion_r2083708808


##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/api/CompiledPlanITCase.java:
##########
@@ -429,4 +461,30 @@ private File createSourceSinkTables() throws IOException {
     private String getPreparedToCompareCompiledPlan(final String planAsString) {
         return TableTestUtil.replaceExecNodeId(TableTestUtil.replaceFlinkVersion(planAsString));
     }
+
+    @Test
+    void testWatermarkPushDownWithTimeStampChanged() throws Exception {

Review Comment:
   Ok



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37640][table-planner] Fix timestamp_ltz is converted timestamp in scan reuse [flink]

Posted by "xishuaidelin (via GitHub)" <gi...@apache.org>.
xishuaidelin commented on code in PR #26430:
URL: https://github.com/apache/flink/pull/26430#discussion_r2083760128


##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/reuse/ScanReuserUtils.java:
##########
@@ -203,7 +204,13 @@ private static WatermarkPushDownSpec adjustWatermarkIndex(
                 String name = newFieldNames.get(i);
                 LogicalType type = newSourceType.getTypeAt(i);
                 if (name.equals(rowtimeColumn)) {
-                    type = new TimestampType(type.isNullable(), TimestampKind.ROWTIME, 3);
+                    if (type instanceof LocalZonedTimestampType) {

Review Comment:
   Thanks for pointing that out! 🤝 You're absolutely right — since other types are already excluded during the SQL parsing phase, there's indeed no need to handle them in this context.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37640][table-planner] Fix timestamp_ltz is converted timestamp in scan reuse [flink]

Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #26430:
URL: https://github.com/apache/flink/pull/26430#discussion_r2035552895


##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/reuse/ScanReuserUtils.java:
##########
@@ -203,7 +204,13 @@ private static WatermarkPushDownSpec adjustWatermarkIndex(
                 String name = newFieldNames.get(i);
                 LogicalType type = newSourceType.getTypeAt(i);
                 if (name.equals(rowtimeColumn)) {
-                    type = new TimestampType(type.isNullable(), TimestampKind.ROWTIME, 3);
+                    if (type instanceof LocalZonedTimestampType) {
+                        type =

Review Comment:
   nit: `type =` and `new LocalZonedTimestampType(` could be on the same line



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37640][table-planner] Fix timestamp_ltz is converted timestamp in scan reuse [flink]

Posted by "xishuaidelin (via GitHub)" <gi...@apache.org>.
xishuaidelin commented on code in PR #26430:
URL: https://github.com/apache/flink/pull/26430#discussion_r2045878539


##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/reuse/ScanReuserUtils.java:
##########
@@ -203,7 +204,13 @@ private static WatermarkPushDownSpec adjustWatermarkIndex(
                 String name = newFieldNames.get(i);
                 LogicalType type = newSourceType.getTypeAt(i);
                 if (name.equals(rowtimeColumn)) {
-                    type = new TimestampType(type.isNullable(), TimestampKind.ROWTIME, 3);
+                    if (type instanceof LocalZonedTimestampType) {
+                        type =

Review Comment:
   Thanks for the feedback! Actually this is the result of our code formatting rules.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37640][table-planner] Fix timestamp_ltz is converted timestamp in scan reuse [flink]

Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #26430:
URL: https://github.com/apache/flink/pull/26430#discussion_r2035566851


##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/reuse/ScanReuserUtils.java:
##########
@@ -203,7 +204,13 @@ private static WatermarkPushDownSpec adjustWatermarkIndex(
                 String name = newFieldNames.get(i);
                 LogicalType type = newSourceType.getTypeAt(i);
                 if (name.equals(rowtimeColumn)) {
-                    type = new TimestampType(type.isNullable(), TimestampKind.ROWTIME, 3);
+                    if (type instanceof LocalZonedTimestampType) {

Review Comment:
   Can a Zoned Timestamp type get through to this code? I know this is not what we would expect for a watermark - but wondered if it can get here.  



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37640][table-planner] Fix timestamp_ltz is converted timestamp in scan reuse [flink]

Posted by "xishuaidelin (via GitHub)" <gi...@apache.org>.
xishuaidelin commented on code in PR #26430:
URL: https://github.com/apache/flink/pull/26430#discussion_r2045869371


##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/reuse/ScanReuserUtils.java:
##########
@@ -203,7 +204,13 @@ private static WatermarkPushDownSpec adjustWatermarkIndex(
                 String name = newFieldNames.get(i);
                 LogicalType type = newSourceType.getTypeAt(i);
                 if (name.equals(rowtimeColumn)) {
-                    type = new TimestampType(type.isNullable(), TimestampKind.ROWTIME, 3);
+                    if (type instanceof LocalZonedTimestampType) {

Review Comment:
   Sorry for my late reply. Actually Flink SQL currently only supports local time zone and without time zone data types while other time-related types would not be parsed successfully. So we don’t need to worry about this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37640][table-planner] Fix timestamp_ltz is converted timestamp in scan reuse [flink]

Posted by "xuyangzhong (via GitHub)" <gi...@apache.org>.
xuyangzhong commented on code in PR #26430:
URL: https://github.com/apache/flink/pull/26430#discussion_r2081141084


##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/api/CompiledPlanITCase.java:
##########
@@ -429,4 +461,30 @@ private File createSourceSinkTables() throws IOException {
     private String getPreparedToCompareCompiledPlan(final String planAsString) {
         return TableTestUtil.replaceExecNodeId(TableTestUtil.replaceFlinkVersion(planAsString));
     }
+
+    @Test
+    void testWatermarkPushDownWithTimeStampChanged() throws Exception {

Review Comment:
   nit: Timestamp



##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/api/CompiledPlanITCase.java:
##########
@@ -429,4 +461,30 @@ private File createSourceSinkTables() throws IOException {
     private String getPreparedToCompareCompiledPlan(final String planAsString) {
         return TableTestUtil.replaceExecNodeId(TableTestUtil.replaceFlinkVersion(planAsString));
     }
+
+    @Test
+    void testWatermarkPushDownWithTimeStampChanged() throws Exception {

Review Comment:
   How about moving this test to `ScanReuseTest`, as it is actually unrelated to `CompilePlan`?



##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/reuse/ScanReuserUtils.java:
##########
@@ -203,7 +204,13 @@ private static WatermarkPushDownSpec adjustWatermarkIndex(
                 String name = newFieldNames.get(i);
                 LogicalType type = newSourceType.getTypeAt(i);
                 if (name.equals(rowtimeColumn)) {
-                    type = new TimestampType(type.isNullable(), TimestampKind.ROWTIME, 3);
+                    if (type instanceof LocalZonedTimestampType) {
+                        type =
+                                new LocalZonedTimestampType(
+                                        type.isNullable(), TimestampKind.ROWTIME, 3);

Review Comment:
   I just wonder what happens if the precision is not 3 actually.



##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/reuse/ScanReuserUtils.java:
##########
@@ -203,7 +204,13 @@ private static WatermarkPushDownSpec adjustWatermarkIndex(
                 String name = newFieldNames.get(i);
                 LogicalType type = newSourceType.getTypeAt(i);
                 if (name.equals(rowtimeColumn)) {
-                    type = new TimestampType(type.isNullable(), TimestampKind.ROWTIME, 3);
+                    if (type instanceof LocalZonedTimestampType) {

Review Comment:
   I believe that when encountering types other than LocalZonedTimestampType and TimestampType, it would be better to raise an error proactively rather than silently converting them to TimestampType. This is because currently we just do not support timestamp(3) with time zone during parsing. (See more at https://github.com/apache/flink/blob/d61575e80f9050840be2cfede3d8c7ba09c74a0d/flink-table/flink-sql-parser/src/main/codegen/templates/Parser.jj#L5979) 



##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/api/CompiledPlanITCase.java:
##########
@@ -55,6 +56,18 @@ class CompiledPlanITCase extends JsonPlanTestBase {
     private static final String[] COLUMNS_DEFINITION =
             new String[] {"a bigint", "b int", "c varchar"};
 
+    private static final String[] COLUMNS_DEFINITION_WITH_TIMESTAMP =
+            new String[] {"a bigint", "ts timestamp_ltz(3)"};
+    private static final List<String> DATA_WITH_TIMESTAMP =

Review Comment:
   Remove this unused variable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37640][table-planner] Fix timestamp_ltz is converted timestamp in scan reuse [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #26430:
URL: https://github.com/apache/flink/pull/26430#issuecomment-2789260474

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "2e30a62ca5560bec27dc0360c8f69d696525b9b5",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "2e30a62ca5560bec27dc0360c8f69d696525b9b5",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 2e30a62ca5560bec27dc0360c8f69d696525b9b5 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37640][table-planner] Fix timestamp_ltz is converted timestamp in scan reuse [flink]

Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #26430:
URL: https://github.com/apache/flink/pull/26430#discussion_r2035559270


##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/reuse/ScanReuserUtils.java:
##########
@@ -203,7 +204,13 @@ private static WatermarkPushDownSpec adjustWatermarkIndex(
                 String name = newFieldNames.get(i);
                 LogicalType type = newSourceType.getTypeAt(i);
                 if (name.equals(rowtimeColumn)) {
-                    type = new TimestampType(type.isNullable(), TimestampKind.ROWTIME, 3);
+                    if (type instanceof LocalZonedTimestampType) {

Review Comment:
   do we need to check for `ZonedTimestampType` as well? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37640][table-planner] Fix timestamp_ltz is converted timestamp in scan reuse [flink]

Posted by "xishuaidelin (via GitHub)" <gi...@apache.org>.
xishuaidelin commented on code in PR #26430:
URL: https://github.com/apache/flink/pull/26430#discussion_r2083772219


##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/reuse/ScanReuserUtils.java:
##########
@@ -203,7 +204,13 @@ private static WatermarkPushDownSpec adjustWatermarkIndex(
                 String name = newFieldNames.get(i);
                 LogicalType type = newSourceType.getTypeAt(i);
                 if (name.equals(rowtimeColumn)) {
-                    type = new TimestampType(type.isNullable(), TimestampKind.ROWTIME, 3);
+                    if (type instanceof LocalZonedTimestampType) {
+                        type =
+                                new LocalZonedTimestampType(
+                                        type.isNullable(), TimestampKind.ROWTIME, 3);

Review Comment:
   Good question. Watermark currently supports millisecond-precision timestamps (3 decimal places); inputs with lower precision require no processing, while higher-precision inputs truncate beyond milliseconds without affecting correctness.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org