You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by Mehant Baid <ba...@gmail.com> on 2015/05/12 01:40:26 UTC
Review Request 34064: DRILL-1980
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34064/
-----------------------------------------------------------
Review request for drill and Jason Altekruse.
Repository: drill-git
Description
-------
Add support for being able to perform CTAS with interval data type.
Also add support to be able to read interval type from parquet
Diffs
-----
exec/java-exec/src/main/codegen/templates/ParquetOutputRecordWriter.java 0d24041
exec/java-exec/src/main/codegen/templates/ParquetTypeHelper.java 6ac488d
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUtility.java 5291855
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ColumnReaderFactory.java 70b2342
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/FixedByteAlignedReader.java fe0234b
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/NullableFixedByteAlignedReaders.java c2221d6
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetToDrillTypeConverter.java 8ab5fea
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet2/DrillParquetGroupConverter.java c6367ae
Diff: https://reviews.apache.org/r/34064/diff/
Testing
-------
Unit tests pending, will upload shortly.
Thanks,
Mehant Baid
Re: Review Request 34064: DRILL-1980
Posted by Jason Altekruse <al...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34064/#review83369
-----------------------------------------------------------
Ship it!
It would be nice to confirm that the files we are producing give the correct values when read with other tools, but after taking a look at both the Impala docs and the parquet-mr codebase it doesn't look like anyone else has implemented it. It does look like we're writing it in the correct format as described in the spec. As we will be writing data with it, external confirmation of accuracy would be nice to have. We should probably open a JIRA for testing it once it is added to parquet-mr or the c++ reader based on impala.
- Jason Altekruse
On May 12, 2015, 4:37 a.m., Mehant Baid wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34064/
> -----------------------------------------------------------
>
> (Updated May 12, 2015, 4:37 a.m.)
>
>
> Review request for drill and Jason Altekruse.
>
>
> Repository: drill-git
>
>
> Description
> -------
>
> Add support for being able to perform CTAS with interval data type.
> Also add support to be able to read interval type from parquet
>
>
> Diffs
> -----
>
> exec/java-exec/src/main/codegen/templates/ParquetOutputRecordWriter.java 0d24041
> exec/java-exec/src/main/codegen/templates/ParquetTypeHelper.java 6ac488d
> exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUtility.java 5291855
> exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ColumnReaderFactory.java 70b2342
> exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/FixedByteAlignedReader.java fe0234b
> exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/NullableFixedByteAlignedReaders.java c2221d6
> exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetToDrillTypeConverter.java 8ab5fea
> exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet2/DrillParquetGroupConverter.java c6367ae
> exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java 958cf1a
>
> Diff: https://reviews.apache.org/r/34064/diff/
>
>
> Testing
> -------
>
> Added unit tests
>
>
> Thanks,
>
> Mehant Baid
>
>
Re: Review Request 34064: DRILL-1980
Posted by Mehant Baid <ba...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34064/
-----------------------------------------------------------
(Updated May 12, 2015, 4:37 a.m.)
Review request for drill and Jason Altekruse.
Changes
-------
Updated patch with tests
Repository: drill-git
Description
-------
Add support for being able to perform CTAS with interval data type.
Also add support to be able to read interval type from parquet
Diffs (updated)
-----
exec/java-exec/src/main/codegen/templates/ParquetOutputRecordWriter.java 0d24041
exec/java-exec/src/main/codegen/templates/ParquetTypeHelper.java 6ac488d
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetReaderUtility.java 5291855
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ColumnReaderFactory.java 70b2342
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/FixedByteAlignedReader.java fe0234b
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/NullableFixedByteAlignedReaders.java c2221d6
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/columnreaders/ParquetToDrillTypeConverter.java 8ab5fea
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet2/DrillParquetGroupConverter.java c6367ae
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/writer/TestParquetWriter.java 958cf1a
Diff: https://reviews.apache.org/r/34064/diff/
Testing (updated)
-------
Added unit tests
Thanks,
Mehant Baid