You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/24 11:34:14 UTC
[GitHub] [arrow-rs] Jimexist opened a new pull request, #3176: bloom filter part V: add an integration with pytest against pyspark
Jimexist opened a new pull request, #3176:
URL: https://github.com/apache/arrow-rs/pull/3176
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
- Closes #3167
- Closes #3023
# Rationale for this change
add an integration with pytest against pyspark
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #3176: bloom filter part V: add an integration with pytest against pyspark
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #3176:
URL: https://github.com/apache/arrow-rs/pull/3176
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3176: bloom filter part V: add an integration with pytest against pyspark
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #3176:
URL: https://github.com/apache/arrow-rs/pull/3176#discussion_r1031415521
##########
parquet/pytest/pyspark_integration_test.py:
##########
@@ -0,0 +1,63 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+import pyspark.sql
+import tempfile
+import subprocess
+import pathlib
+
+TEST_COL_NAME = "id"
+
+
+def create_data_and_df(col_name=TEST_COL_NAME):
+ spark = pyspark.sql.SparkSession.builder.getOrCreate()
+ spark.conf.set("parquet.bloom.filter.enabled", True)
+ spark.conf.set("parquet.bloom.filter.expected.ndv", 10)
+ spark.conf.set("parquet.bloom.filter.max.bytes", 32)
+ data = [(f"id-{i % 10}",) for i in range(100)]
+ df = spark.createDataFrame(data, [col_name]).repartition(1)
+ return data, df
Review Comment:
Should we also test with some `data` for which the bloom filter may evaluate to false?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #3176: bloom filter part V: add an integration with pytest against pyspark
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3176:
URL: https://github.com/apache/arrow-rs/pull/3176#issuecomment-1326790076
Benchmark runs are scheduled for baseline = 22deab00696f4fac2a587c59bf9b0ce2c2ec3ac6 and contender = 007fb4c56ffce7f8b6be7928196da79ee5eff75a. 007fb4c56ffce7f8b6be7928196da79ee5eff75a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/367e63519cbd4060bfea6682a3e12a07...1292cc26738144d3a833a71186f6ddf4/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/78e53119223248fe9166153b0c4b34cf...d2589118e04145339003ed57bcb3e6fa/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/e4201d3221ab41b99577db11d60f3bd0...99250faa82474c9f9271efbb0aebe50e/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/4f29b08d93fd47da8365252de819ed25...32607125d5a941b9b9977ecb3c0951da/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org