You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by jl...@apache.org on 2016/06/24 21:37:13 UTC
svn commit: r1750166 - in /ofbiz/trunk:
applications/datamodel/entitydef/workeffort-entitymodel.xml
applications/workeffort/data/WorkEffortDemoData.xml
specialpurpose/projectmgr/data/ProjectMgrDemoData.xml
specialpurpose/scrum/data/scrumDemoData.xml
Author: jleroux
Date: Fri Jun 24 21:37:11 2016
New Revision: 1750166
URL: http://svn.apache.org/viewvc?rev=1750166&view=rev
Log:
A patch from Gopal Yadav for "Add Work Effort Party Assignment creates record with invalid PartyId" https://issues.apache.org/jira/browse/OFBIZ-7188
Steps to regenerate:
1. Go to FindWorkEffort screen https://localhost:8443/workeffort/control/FindWorkEffort
2. Click on Find button in search option and choose any of the WorkEffort from the list.
3. Go to the Parties tab to check parties assigned to the WorkEffort.
4. Add Work Effort Party Assignment:
- Enter any invalid PartyId (which does not exist in the system e.g, XYZ or ABC)
- Choose any of the roles from the drop-down list.
- Add FromDate.
- Submit the form.
Current Behaviour: System creates a WorkEffortPartyAssignment record with invalid data (partyId).
Expected: System should not create this record as entered data - partyId is invalid.
Exploring around this issue I found that entity definition of WorkEffortPartyAssignment has relation with Person, here I think it is required to create a foreign key rule with Person entity. Also, fk-name has not been created with PartyRole in the entity definition.
I have corrected the definition and attached a patch for the same.
Modified:
ofbiz/trunk/applications/datamodel/entitydef/workeffort-entitymodel.xml
ofbiz/trunk/applications/workeffort/data/WorkEffortDemoData.xml
ofbiz/trunk/specialpurpose/projectmgr/data/ProjectMgrDemoData.xml
ofbiz/trunk/specialpurpose/scrum/data/scrumDemoData.xml
Modified: ofbiz/trunk/applications/datamodel/entitydef/workeffort-entitymodel.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/datamodel/entitydef/workeffort-entitymodel.xml?rev=1750166&r1=1750165&r2=1750166&view=diff
==============================================================================
--- ofbiz/trunk/applications/datamodel/entitydef/workeffort-entitymodel.xml (original)
+++ ofbiz/trunk/applications/datamodel/entitydef/workeffort-entitymodel.xml Fri Jun 24 21:37:11 2016
@@ -703,10 +703,7 @@ under the License.
<relation type="one-nofk" rel-entity-name="Party">
<key-map field-name="partyId"/>
</relation>
- <relation type="one-nofk" rel-entity-name="Person">
- <key-map field-name="partyId"/>
- </relation>
- <relation type="one-nofk" rel-entity-name="PartyRole">
+ <relation type="one" fk-name="WKEFF_PA_PRTY_ROLE" rel-entity-name="PartyRole">
<key-map field-name="partyId"/>
<key-map field-name="roleTypeId"/>
</relation>
Modified: ofbiz/trunk/applications/workeffort/data/WorkEffortDemoData.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/workeffort/data/WorkEffortDemoData.xml?rev=1750166&r1=1750165&r2=1750166&view=diff
==============================================================================
--- ofbiz/trunk/applications/workeffort/data/WorkEffortDemoData.xml (original)
+++ ofbiz/trunk/applications/workeffort/data/WorkEffortDemoData.xml Fri Jun 24 21:37:11 2016
@@ -32,6 +32,9 @@ under the License.
<UserLogin userLoginId="WorkEffortUser" partyId="WorkEffortUser" currentPassword="{SHA}47b56994cbc2b6d10aa1be30f70165adb305a41a" />
<UserLoginSecurityGroup groupId="WORKEFFORT_USER" userLoginId="WorkEffortUser" fromDate="2011-01-01 00:00:00.0" />
+ <PartyRole partyId="admin" roleTypeId="CAL_OWNER"/>
+ <PartyRole partyId="admin" roleTypeId="CAL_ATTENDEE"/>
+
<!-- Publish the staff meeting calendar event in iCalendar format -->
<WorkEffort workEffortId="CALENDAR_PUB_DEMO" workEffortTypeId="PUBLISH_PROPS" currentStatusId="CAL_CANCELLED" scopeEnumId="WES_PUBLIC" description="Demo Project 1 Customer 1" workEffortName="iCalendar Publish Demonstration"/>
<WorkEffortPartyAssignment workEffortId="CALENDAR_PUB_DEMO" partyId="admin" statusId="PRTYASGN_ASSIGNED" roleTypeId="CAL_OWNER" fromDate="2008-01-01 00:00:00.0"/>
@@ -41,6 +44,11 @@ under the License.
<Party partyId="DemoEmployee1"/><!-- further defined in the projectmanager -->
<Party partyId="DemoEmployee2"/>
<Party partyId="DemoEmployee3"/>
+
+ <PartyRole partyId="DemoEmployee1" roleTypeId="CAL_OWNER"/>
+ <PartyRole partyId="DemoEmployee2" roleTypeId="CAL_ATTENDEE"/>
+ <PartyRole partyId="DemoEmployee3" roleTypeId="CAL_ATTENDEE"/>
+
<WorkEffort workEffortId="PROJECT_PUB_DEMO" workEffortTypeId="PUBLISH_PROPS" currentStatusId="CAL_CANCELLED" scopeEnumId="WES_PRIVATE" description="Demo Project 1 Customer 1" workEffortName="Project iCalendar Publish Demonstration"/>
<WorkEffortPartyAssignment workEffortId="PROJECT_PUB_DEMO" partyId="DemoEmployee1" statusId="PRTYASGN_ASSIGNED" roleTypeId="CAL_OWNER" fromDate="2008-01-01 00:00:00.0"/>
<WorkEffortPartyAssignment workEffortId="STAFF_MTG" partyId="DemoEmployee1" statusId="PRTYASGN_ASSIGNED" roleTypeId="CAL_OWNER" availabilityStatusId="WEPA_AV_BUSY" fromDate="2008-01-01 00:00:00.0"/>
Modified: ofbiz/trunk/specialpurpose/projectmgr/data/ProjectMgrDemoData.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/projectmgr/data/ProjectMgrDemoData.xml?rev=1750166&r1=1750165&r2=1750166&view=diff
==============================================================================
--- ofbiz/trunk/specialpurpose/projectmgr/data/ProjectMgrDemoData.xml (original)
+++ ofbiz/trunk/specialpurpose/projectmgr/data/ProjectMgrDemoData.xml Fri Jun 24 21:37:11 2016
@@ -109,6 +109,7 @@ under the License.
<!-- make sure admin show up as a resource, he acts as a full access admin -->
<PartyRole partyId="admin" roleTypeId="PROJECT_TEAM"/>
+ <PartyRole partyId="admin" roleTypeId="PROVIDER_MANAGER"/>
<!-- security demo data -->
<!-- allow these these usergroups read only -->
@@ -168,6 +169,8 @@ under the License.
<WorkEffortAssoc workEffortIdFrom="9103" workEffortIdTo="9105" workEffortAssocTypeId="WORK_EFF_DEPENDENCY" sequenceNum="0" fromDate="2000-01-01 00:00:00.0"/>
<WorkEffortAssoc workEffortIdFrom="9105" workEffortIdTo="9106" workEffortAssocTypeId="WORK_EFF_DEPENDENCY" sequenceNum="0" fromDate="2000-01-01 00:00:00.0"/>
+ <PartyRole partyId="DemoCustCompany" roleTypeId="CLIENT_BILLING"/>
+
<!-- Another Demo project for DemoCustomeCompanyr and employee 1,3-->
<WorkEffort workEffortId="9200" workEffortTypeId="PROJECT" currentStatusId="_NA_" lastStatusUpdate="2007-12-14 15:07:52.911" scopeEnumId="WES_PRIVATE" workEffortName="Demo Project3 DemoCustomerCompany" revisionNumber="1"/>
<WorkEffortPartyAssignment workEffortId="9200" partyId="DemoEmployee3" roleTypeId="PROVIDER_ANALYST" fromDate="2007-12-14 16:45:21.831" statusId="PAS_ASSIGNED"/>
Modified: ofbiz/trunk/specialpurpose/scrum/data/scrumDemoData.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/scrum/data/scrumDemoData.xml?rev=1750166&r1=1750165&r2=1750166&view=diff
==============================================================================
--- ofbiz/trunk/specialpurpose/scrum/data/scrumDemoData.xml (original)
+++ ofbiz/trunk/specialpurpose/scrum/data/scrumDemoData.xml Fri Jun 24 21:37:11 2016
@@ -49,6 +49,7 @@ under the License.
<PartyRole partyId="SCRUMADMIN" roleTypeId="SCRUM_MEMBER"/>
<PartyRole partyId="DemoCustomer-1" roleTypeId="PRODUCT_OWNER"/>
+ <PartyRole partyId="DemoCustomer-1" roleTypeId="SCRUM_TEAM"/>
<PartyRole partyId="SCRUMASTER" roleTypeId="SCRUM_MASTER"/>
<PartyRole partyId="SCRUMASTER" roleTypeId="CONTACT"/>
<PartyRole partyId="SCRUMTEAM-1" roleTypeId="SCRUM_TEAM"/>