[GitHub] [pulsar] codelipenghui commented on a change in pull request #10710: [issue 10693] use unify configuration from remote cluster for geo-replicator

[GitBox <gi...@apache.org>]

codelipenghui commented on a change in pull request #10710:
URL: https://github.com/apache/pulsar/pull/10710#discussion_r639785017



##########
File path: pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BrokerService.java
##########
@@ -1029,21 +1029,19 @@ public PulsarClient getReplicationClient(String cluster) {
                     clientBuilder.authentication(pulsar.getConfiguration().getBrokerClientAuthenticationPlugin(),
                             pulsar.getConfiguration().getBrokerClientAuthenticationParameters());
                 }
-                if (pulsar.getConfiguration().isBrokerClientTlsEnabled()) {
+                if (data.isBrokerClientTlsEnabled()) {

Review comment:
       This will be a breaking change if the existing clusters enabled the TLS with the same TLS certificate. If the configuration does not present in the `ClusterData`, we should use the broker configuration file.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org