[GitHub] [iceberg] MaxNevermind commented on a diff in pull request #7694: Build: Replace usage of Nebula dependency recommender plugin with Gradle's versionCatalog

["MaxNevermind (via GitHub)" <gi...@apache.org>]

MaxNevermind commented on code in PR #7694:
URL: https://github.com/apache/iceberg/pull/7694#discussion_r1214445211


##########
settings.gradle:
##########
@@ -192,3 +194,186 @@ if (JavaVersion.current() == JavaVersion.VERSION_1_8) {
   }
 }
 
+dependencyResolutionManagement {
+  versionCatalogs {
+    libs {
+      String antlrVersion = "4.8"
+      String awsSdkVersion = "2.20.18"
+      String flink15Version = "1.15.0"
+      String flink16Version = "1.16.1"
+      String flink17Version = "1.17.0"
+      String hadoop2Version = "2.7.3"
+      String hive2Version = "2.3.9"
+      String hive3Version = "3.1.3"
+      String jackson11Version = "2.11.4"

Review Comment:
   yeah, I was hesitant about that because of potential Jackson major version change but Jackson version 2 was released more than 10 years ago so I decided it doesn't change that frequently
   we can change those to jackson2xxVersion if you think it worth it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org