You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "David S. Wang (Created) (JIRA)" <ji...@apache.org> on 2012/03/17 01:02:40 UTC
[jira] [Created] (HBASE-5597) Findbugs check in test-patch.sh
always fails
Findbugs check in test-patch.sh always fails
--------------------------------------------
Key: HBASE-5597
URL: https://issues.apache.org/jira/browse/HBASE-5597
Project: HBase
Issue Type: Bug
Components: scripts
Affects Versions: 0.92.1, 0.94.0, 0.96.0
Reporter: David S. Wang
"Fix" is to bump up OK findbugs count in test-patch.properties. Agreed to on the list.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5597) Findbugs check in test-patch.sh
always fails
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232039#comment-13232039 ]
Uma Maheswara Rao G commented on HBASE-5597:
--------------------------------------------
{quote}
My original goal is to get test-patch.sh to pass.
....
So I am fine with either bumping the OK findbugs count, or creating a findbugs exclusion file. Others can chime in.
{quote}
Hi David,
If our goal is just to make it pass , then both the ways would work. :-)
But only my concern with upping the count is, it will create above issue which I mentioned in my previous comment. Finally we will get trapped with the test-patch results. And we may induce valid findbugs later( may not be reported by test-patch results due to above issue ).
> Findbugs check in test-patch.sh always fails
> --------------------------------------------
>
> Key: HBASE-5597
> URL: https://issues.apache.org/jira/browse/HBASE-5597
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: David S. Wang
> Assignee: David S. Wang
> Attachments: HBASE-5597.patch
>
>
> "Fix" is to bump up OK findbugs count in test-patch.properties. Agreed to on the list.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5597) Findbugs check in test-patch.sh
always fails
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231774#comment-13231774 ]
Hadoop QA commented on HBASE-5597:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12518754/HBASE-5597.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 161 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestImportTsv
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1213//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1213//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1213//console
This message is automatically generated.
> Findbugs check in test-patch.sh always fails
> --------------------------------------------
>
> Key: HBASE-5597
> URL: https://issues.apache.org/jira/browse/HBASE-5597
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: David S. Wang
> Assignee: David S. Wang
> Attachments: HBASE-5597.patch
>
>
> "Fix" is to bump up OK findbugs count in test-patch.properties. Agreed to on the list.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5597) Findbugs check in test-patch.sh
always fails
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234133#comment-13234133 ]
Hudson commented on HBASE-5597:
-------------------------------
Integrated in HBase-TRUNK-security #144 (See [https://builds.apache.org/job/HBase-TRUNK-security/144/])
HBASE-5597 Findbugs check in test-patch.sh always fails (Revision 1303196)
Result = FAILURE
stack :
Files :
* /hbase/trunk/dev-support/test-patch.properties
> Findbugs check in test-patch.sh always fails
> --------------------------------------------
>
> Key: HBASE-5597
> URL: https://issues.apache.org/jira/browse/HBASE-5597
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: David S. Wang
> Assignee: David S. Wang
> Fix For: 0.94.0
>
> Attachments: HBASE-5597.patch
>
>
> "Fix" is to bump up OK findbugs count in test-patch.properties. Agreed to on the list.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5597) Findbugs check in test-patch.sh
always fails
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232109#comment-13232109 ]
stack commented on HBASE-5597:
------------------------------
I'd be fine committing this patch for now and opening another to address findbugs issues. I agree w/ Uma but truth be told, no one that I know of is looking at findbugs output and for sure no one is trying to keep the count down. We need to foreground the findbugs reporting and perhaps have someone dig in. In my experience there are many false positives but it'll find the odd good one. What do ye think?
> Findbugs check in test-patch.sh always fails
> --------------------------------------------
>
> Key: HBASE-5597
> URL: https://issues.apache.org/jira/browse/HBASE-5597
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: David S. Wang
> Assignee: David S. Wang
> Attachments: HBASE-5597.patch
>
>
> "Fix" is to bump up OK findbugs count in test-patch.properties. Agreed to on the list.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5597) Findbugs check in test-patch.sh
always fails
Posted by "stack (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5597:
-------------------------
Resolution: Fixed
Fix Version/s: 0.94.0
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to 0.94 and trunk. Thanks for patch David and review Uma.
> Findbugs check in test-patch.sh always fails
> --------------------------------------------
>
> Key: HBASE-5597
> URL: https://issues.apache.org/jira/browse/HBASE-5597
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: David S. Wang
> Assignee: David S. Wang
> Fix For: 0.94.0
>
> Attachments: HBASE-5597.patch
>
>
> "Fix" is to bump up OK findbugs count in test-patch.properties. Agreed to on the list.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5597) Findbugs check in test-patch.sh
always fails
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13234828#comment-13234828 ]
Hudson commented on HBASE-5597:
-------------------------------
Integrated in HBase-TRUNK #2689 (See [https://builds.apache.org/job/HBase-TRUNK/2689/])
HBASE-5597 Findbugs check in test-patch.sh always fails (Revision 1303196)
Result = FAILURE
stack :
Files :
* /hbase/trunk/dev-support/test-patch.properties
> Findbugs check in test-patch.sh always fails
> --------------------------------------------
>
> Key: HBASE-5597
> URL: https://issues.apache.org/jira/browse/HBASE-5597
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: David S. Wang
> Assignee: David S. Wang
> Fix For: 0.94.0
>
> Attachments: HBASE-5597.patch
>
>
> "Fix" is to bump up OK findbugs count in test-patch.properties. Agreed to on the list.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5597) Findbugs check in test-patch.sh
always fails
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13233985#comment-13233985 ]
Hudson commented on HBASE-5597:
-------------------------------
Integrated in HBase-0.94 #43 (See [https://builds.apache.org/job/HBase-0.94/43/])
HBASE-5597 Findbugs check in test-patch.sh always fails (Revision 1303197)
Result = SUCCESS
stack :
Files :
* /hbase/branches/0.94/dev-support/test-patch.properties
> Findbugs check in test-patch.sh always fails
> --------------------------------------------
>
> Key: HBASE-5597
> URL: https://issues.apache.org/jira/browse/HBASE-5597
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: David S. Wang
> Assignee: David S. Wang
> Fix For: 0.94.0
>
> Attachments: HBASE-5597.patch
>
>
> "Fix" is to bump up OK findbugs count in test-patch.properties. Agreed to on the list.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5597) Findbugs check in test-patch.sh
always fails
Posted by "David S. Wang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David S. Wang updated HBASE-5597:
---------------------------------
Attachment: HBASE-5597.patch
> Findbugs check in test-patch.sh always fails
> --------------------------------------------
>
> Key: HBASE-5597
> URL: https://issues.apache.org/jira/browse/HBASE-5597
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: David S. Wang
> Assignee: David S. Wang
> Attachments: HBASE-5597.patch
>
>
> "Fix" is to bump up OK findbugs count in test-patch.properties. Agreed to on the list.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5597) Findbugs check in test-patch.sh
always fails
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232116#comment-13232116 ]
Uma Maheswara Rao G commented on HBASE-5597:
--------------------------------------------
I am ok to file another JIRA. Just filed HBASE-5598.
ok, let's commit this for now.
+1
> Findbugs check in test-patch.sh always fails
> --------------------------------------------
>
> Key: HBASE-5597
> URL: https://issues.apache.org/jira/browse/HBASE-5597
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: David S. Wang
> Assignee: David S. Wang
> Attachments: HBASE-5597.patch
>
>
> "Fix" is to bump up OK findbugs count in test-patch.properties. Agreed to on the list.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5597) Findbugs check in test-patch.sh
always fails
Posted by "Uma Maheswara Rao G (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13231817#comment-13231817 ]
Uma Maheswara Rao G commented on HBASE-5597:
--------------------------------------------
Hi David,
Problem with just upping the count is, later if you remove some code(contains current findbugs warnings) and add new code(introduce some valid findbugs). Then test-patch may not make difference due to this OK count.
Instead, we can add findbugs-exclude file right? this may point the exact place of the findbug to ignore.
What do you say?
> Findbugs check in test-patch.sh always fails
> --------------------------------------------
>
> Key: HBASE-5597
> URL: https://issues.apache.org/jira/browse/HBASE-5597
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: David S. Wang
> Assignee: David S. Wang
> Attachments: HBASE-5597.patch
>
>
> "Fix" is to bump up OK findbugs count in test-patch.properties. Agreed to on the list.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-5597) Findbugs check in test-patch.sh
always fails
Posted by "David S. Wang (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David S. Wang reassigned HBASE-5597:
------------------------------------
Assignee: David S. Wang
> Findbugs check in test-patch.sh always fails
> --------------------------------------------
>
> Key: HBASE-5597
> URL: https://issues.apache.org/jira/browse/HBASE-5597
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: David S. Wang
> Assignee: David S. Wang
>
> "Fix" is to bump up OK findbugs count in test-patch.properties. Agreed to on the list.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5597) Findbugs check in test-patch.sh
always fails
Posted by "David S. Wang (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5597?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David S. Wang updated HBASE-5597:
---------------------------------
Status: Patch Available (was: Open)
> Findbugs check in test-patch.sh always fails
> --------------------------------------------
>
> Key: HBASE-5597
> URL: https://issues.apache.org/jira/browse/HBASE-5597
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: David S. Wang
> Assignee: David S. Wang
> Attachments: HBASE-5597.patch
>
>
> "Fix" is to bump up OK findbugs count in test-patch.properties. Agreed to on the list.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5597) Findbugs check in test-patch.sh
always fails
Posted by "David S. Wang (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5597?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13232032#comment-13232032 ]
David S. Wang commented on HBASE-5597:
--------------------------------------
My original goal is to get test-patch.sh to pass. Actually, it would be great to just fix all of the findbugs errors, instead of having either this count or the exclude files. But evidently it has not been important enough to fix so far, or else we would not have an "OK findbugs count" in the first place.
So I am fine with either bumping the OK findbugs count, or creating a findbugs exclusion file. Others can chime in.
> Findbugs check in test-patch.sh always fails
> --------------------------------------------
>
> Key: HBASE-5597
> URL: https://issues.apache.org/jira/browse/HBASE-5597
> Project: HBase
> Issue Type: Bug
> Components: scripts
> Affects Versions: 0.92.1, 0.94.0, 0.96.0
> Reporter: David S. Wang
> Assignee: David S. Wang
> Attachments: HBASE-5597.patch
>
>
> "Fix" is to bump up OK findbugs count in test-patch.properties. Agreed to on the list.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira