You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/03 23:58:43 UTC

[GitHub] [arrow-ballista] andygrove opened a new pull request, #57: Delegate to `datafusion-proto` for logical plan serde

andygrove opened a new pull request, #57:
URL: https://github.com/apache/arrow-ballista/pull/57

   # Which issue does this PR close?
   
   <!--
   We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
   -->
   
   Part of https://github.com/apache/arrow-ballista/issues/2
   
    # Rationale for this change
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   Remove duplicate code from this project and delegate to DataFusion instead.
   
   # What changes are included in this PR?
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   Remove `AsLogicalPlan`, `LogicalExtensionCodec` and use the versions from `datafusion-proto`
   
   # Are there any user-facing changes?
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   No
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-ballista] andygrove commented on pull request #57: Delegate to `datafusion-proto` for logical plan serde

Posted by GitBox <gi...@apache.org>.
andygrove commented on PR #57:
URL: https://github.com/apache/arrow-ballista/pull/57#issuecomment-1146466369

   @thinkharderdev This is a new PR for delegating to datafusion-proto and now it just uses the `AsLogicalPlan` trait from that crate


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-ballista] alamb commented on pull request #57: Delegate to `datafusion-proto` for logical plan serde

Posted by GitBox <gi...@apache.org>.
alamb commented on PR #57:
URL: https://github.com/apache/arrow-ballista/pull/57#issuecomment-1146637751

   ![bird-parrot](https://user-images.githubusercontent.com/490673/172013186-50413cc8-7bff-4ffd-b9f7-6fbf26f938ae.gif)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-ballista] andygrove merged pull request #57: Delegate to `datafusion-proto` for logical plan serde

Posted by GitBox <gi...@apache.org>.
andygrove merged PR #57:
URL: https://github.com/apache/arrow-ballista/pull/57


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org