You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/02/28 21:12:52 UTC

[GitHub] [incubator-tvm] alexwong commented on a change in pull request #4964: [Torch] Add initial control flow support

alexwong commented on a change in pull request #4964: [Torch] Add initial control flow support 
URL: https://github.com/apache/incubator-tvm/pull/4964#discussion_r385917420
 
 

 ##########
 File path: python/tvm/relay/frontend/pytorch.py
 ##########
 @@ -123,7 +124,8 @@ def _impl(inputs, input_types):
         else:
             assert "data type {} could not be parsed in ones op" % (type(data))
 
-        return _op.full(_expr.const(1), shape, dtype=_convert_data_type(input_types[0]))
+        dtype = "float32"
 
 Review comment:
   Is it intentional to always use float32? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services