You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "B. Todd Burruss (JIRA)" <ji...@apache.org> on 2010/12/04 07:18:10 UTC
[jira] Created: (CASSANDRA-1820) Port 8080 is not always suitable
for JMX
Port 8080 is not always suitable for JMX
----------------------------------------
Key: CASSANDRA-1820
URL: https://issues.apache.org/jira/browse/CASSANDRA-1820
Project: Cassandra
Issue Type: Improvement
Reporter: B. Todd Burruss
Attachments: patch.txt
if JMX_PORT is already set in environment, then cassandra-env.sh will not override it.
patch attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1820) Port 8080 is not always suitable
for JMX
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Evans updated CASSANDRA-1820:
----------------------------------
Remaining Estimate: 0h
Original Estimate: 0h
> Port 8080 is not always suitable for JMX
> ----------------------------------------
>
> Key: CASSANDRA-1820
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1820
> Project: Cassandra
> Issue Type: Improvement
> Components: Packaging
> Reporter: B. Todd Burruss
> Assignee: B. Todd Burruss
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: patch.txt
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> if JMX_PORT is already set in environment, then cassandra-env.sh will not override it.
> patch attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1820) Port 8080 is not always suitable
for JMX
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971074#action_12971074 ]
Eric Evans commented on CASSANDRA-1820:
---------------------------------------
> my reasoning behind this request is that you guys have put a lot of good work
> into cassandra-env.sh and i hate to duplicate all that into a custom one, just
> to change a port number. this makes my personal upgrade path more painful from
> release to release.
I understand, but this is a configuration file. The expectation is that it will be edited by users to customize for their environments.
If anything, you could make a good argument for 8080 being a bad default, (it is, and that's probably why most people would need to change it), though it's also too late in the release cycle for a new default.
> - MAX_HEAP_SIZE was already coded to be configurable since by default it is not
> set. this is the very reason i thought that JMX_PORT could also be configurable
FWIW, this wasn't the intention. There is a commented entry just above that expression.
> Port 8080 is not always suitable for JMX
> ----------------------------------------
>
> Key: CASSANDRA-1820
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1820
> Project: Cassandra
> Issue Type: Improvement
> Components: Packaging
> Reporter: B. Todd Burruss
> Assignee: B. Todd Burruss
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: patch.txt
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> if JMX_PORT is already set in environment, then cassandra-env.sh will not override it.
> patch attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1820) Port 8080 is not always suitable
for JMX
Posted by "B. Todd Burruss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971078#action_12971078 ]
B. Todd Burruss commented on CASSANDRA-1820:
--------------------------------------------
+1 on 8080 as a bad default. what was someone thinking?
and i understand about MAX_HEAP_SIZE and saw the comment ... but it is a nice "feature" ;)
> Port 8080 is not always suitable for JMX
> ----------------------------------------
>
> Key: CASSANDRA-1820
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1820
> Project: Cassandra
> Issue Type: Improvement
> Components: Packaging
> Reporter: B. Todd Burruss
> Assignee: B. Todd Burruss
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: patch.txt
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> if JMX_PORT is already set in environment, then cassandra-env.sh will not override it.
> patch attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1820) Port 8080 is not always suitable
for JMX
Posted by "B. Todd Burruss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971067#action_12971067 ]
B. Todd Burruss commented on CASSANDRA-1820:
--------------------------------------------
my reasoning behind this request is that you guys have put a lot of good work into cassandra-env.sh and i hate to duplicate all that into a custom one, just to change a port number. this makes my personal upgrade path more painful from release to release.
for you particular points:
- i don't think changing the name would introduce that much pain. since there isn't a way to set the JMX_PORT except by using custom scripts i figure most folks just don't do it
- MAX_HEAP_SIZE was already coded to be configurable since by default it is not set. this is the very reason i thought that JMX_PORT could also be configurable
- where do i think it should stop? i think easy wins like port numbers should be configurable via environment.
thx
> Port 8080 is not always suitable for JMX
> ----------------------------------------
>
> Key: CASSANDRA-1820
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1820
> Project: Cassandra
> Issue Type: Improvement
> Components: Packaging
> Reporter: B. Todd Burruss
> Assignee: B. Todd Burruss
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: patch.txt
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> if JMX_PORT is already set in environment, then cassandra-env.sh will not override it.
> patch attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-1820) Port 8080 is not always suitable
for JMX
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eric Evans resolved CASSANDRA-1820.
-----------------------------------
Resolution: Won't Fix
> Port 8080 is not always suitable for JMX
> ----------------------------------------
>
> Key: CASSANDRA-1820
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1820
> Project: Cassandra
> Issue Type: Improvement
> Components: Packaging
> Reporter: B. Todd Burruss
> Assignee: B. Todd Burruss
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: patch.txt
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> if JMX_PORT is already set in environment, then cassandra-env.sh will not override it.
> patch attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1820) Port 8080 is not always suitable
for JMX
Posted by "Eric Evans (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12971044#action_12971044 ]
Eric Evans commented on CASSANDRA-1820:
---------------------------------------
There are a few reasons why I'm reluctant to apply something like this:
* JMX_PORT is too generic a name for an exported env var. CASSANDRA_JMX_PORT would be a better name, but changing it will introduce upgrade pain.
* You can already change this sort of thing by specifying an alternate {{cassandra-env.sh}} using the {{CASSANDRA_CONF}} env var. Too many ways of accomplishing the same thing can easily result in less usability, not more.
* You could make a similar argument about other configurables, {{MAX_HEAP_SIZE}} for example. Where do you draw the line? Or should they all be directly configurable through the environment?
I'm going to close this as Won't Fix, if you disagree with this then feel free to reopen it and we can take the discussion to a wider group.
Thanks.
> Port 8080 is not always suitable for JMX
> ----------------------------------------
>
> Key: CASSANDRA-1820
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1820
> Project: Cassandra
> Issue Type: Improvement
> Components: Packaging
> Reporter: B. Todd Burruss
> Assignee: B. Todd Burruss
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: patch.txt
>
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> if JMX_PORT is already set in environment, then cassandra-env.sh will not override it.
> patch attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1820) Port 8080 is not always suitable
for JMX
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-1820:
--------------------------------------
Reviewer: urandom
Component/s: Packaging
Priority: Minor (was: Major)
Fix Version/s: 0.7.0
Assignee: B. Todd Burruss
> Port 8080 is not always suitable for JMX
> ----------------------------------------
>
> Key: CASSANDRA-1820
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1820
> Project: Cassandra
> Issue Type: Improvement
> Components: Packaging
> Reporter: B. Todd Burruss
> Assignee: B. Todd Burruss
> Priority: Minor
> Fix For: 0.7.0
>
> Attachments: patch.txt
>
>
> if JMX_PORT is already set in environment, then cassandra-env.sh will not override it.
> patch attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1820) Port 8080 is not always suitable
for JMX
Posted by "B. Todd Burruss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1820?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
B. Todd Burruss updated CASSANDRA-1820:
---------------------------------------
Attachment: patch.txt
> Port 8080 is not always suitable for JMX
> ----------------------------------------
>
> Key: CASSANDRA-1820
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1820
> Project: Cassandra
> Issue Type: Improvement
> Reporter: B. Todd Burruss
> Attachments: patch.txt
>
>
> if JMX_PORT is already set in environment, then cassandra-env.sh will not override it.
> patch attached
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.