[GitHub] [openwhisk] style95 commented on a diff in pull request #5346: Make the test stable

[GitBox <gi...@apache.org>]

style95 commented on code in PR #5346:
URL: https://github.com/apache/openwhisk/pull/5346#discussion_r1010172255


##########
tests/src/test/scala/org/apache/openwhisk/core/containerpool/v2/test/FunctionPullingContainerProxyTests.scala:
##########
@@ -1575,6 +1575,9 @@ class FunctionPullingContainerProxyTests
 
     machine ! Initialize(invocationNamespace.asString, fqn, action, schedulerHost, rpcPort, messageTransId)
     probe.expectMsg(Transition(machine, Uninitialized, CreatingClient))
+    awaitAssert {
+      machine.stateData shouldBe a[ContainerCreatedData]

Review Comment:
   When `ClientCreationCompleted` is sent to the proxy before the data is updated, it causes a kind of cycle and the test keeps running.
   https://github.com/apache/openwhisk/blob/master/core/invoker/src/main/scala/org/apache/openwhisk/core/containerpool/v2/FunctionPullingContainerProxy.scala#L342



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@openwhisk.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org