Re: svn commit: r33217 - trunk/subversion/libsvn_ra_serf

[Lieven Govaerts <sv...@mobsol.be>]

kfogel@tigris.org wrote:
> Author: kfogel
> Date: Sat Sep 20 14:07:01 2008
> New Revision: 33217
> 
> Log:
> Add comments to ensure that similar code in two places is kept in sync.
> This follows up to r33204.
> 
> * subversion/libsvn_ra_serf/propfind_buckets.c
>   (become_request): Add note about also adding any new DAV headers...
> 
> * subversion/libsvn_ra_serf/util.c
>   (svn_ra_serf__setup_serf_req): ...here, and vice versa.
> 

Karl,

The better way to solve this is to get rid of the propfind bucket type
altogether. Justin added this type at a time when the delegate and
body_delegate callbacks weren't there yet. These should be perfectly
sufficient to implement PROPFIND requests without the need for a new
bucket type.

It's somewhere on my TODO list, but not at the top. For now, these
comments you added are the best we can do.

Lieven

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r33217 - trunk/subversion/libsvn_ra_serf

[Karl Fogel <kf...@red-bean.com>]

Lieven Govaerts <sv...@mobsol.be> writes:
> The better way to solve this is to get rid of the propfind bucket type
> altogether. Justin added this type at a time when the delegate and
> body_delegate callbacks weren't there yet. These should be perfectly
> sufficient to implement PROPFIND requests without the need for a new
> bucket type.

I absolutely agree, but didn't have time to do that right now.

> It's somewhere on my TODO list, but not at the top. For now, these
> comments you added are the best we can do.

Yup.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org