You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2015/11/19 10:44:45 UTC
Review Request 40475: LENS-851: queries where results of two storage
tables of same fact are unioned, the rows should be aggregated
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40475/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-851
https://issues.apache.org/jira/browse/LENS-851
Repository: lens
Description
-------
union order is now sorted according to storage table name.
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 8a6aa000da47328438d924110db9f6dcffef633f
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 4db1626fc1398be79dbe2c293537b360b0940eb3
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 494f81bd94c6e972875b7a84765de8fa53016479
Diff: https://reviews.apache.org/r/40475/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 40475: LENS-851: queries where results of two
storage tables of same fact are unioned, the rows should be aggregated
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40475/
-----------------------------------------------------------
(Updated Nov. 24, 2015, 6:14 p.m.)
Review request for lens.
Bugs: LENS-851
https://issues.apache.org/jira/browse/LENS-851
Repository: lens
Description
-------
union order is now sorted according to storage table name.
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/MultiFactHQLContext.java 2fcea8b774eaecb987e2436e0b5b60baeed54e23
Diff: https://reviews.apache.org/r/40475/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 40475: LENS-851: queries where results of two
storage tables of same fact are unioned, the rows should be aggregated
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40475/#review107155
-----------------------------------------------------------
Ship it!
Hope tests are passing on both java7 and java8.
- Amareshwari Sriramadasu
On Nov. 19, 2015, 9:44 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40475/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2015, 9:44 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-851
> https://issues.apache.org/jira/browse/LENS-851
>
>
> Repository: lens
>
>
> Description
> -------
>
> union order is now sorted according to storage table name.
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java 8a6aa000da47328438d924110db9f6dcffef633f
> lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java 4db1626fc1398be79dbe2c293537b360b0940eb3
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 494f81bd94c6e972875b7a84765de8fa53016479
>
> Diff: https://reviews.apache.org/r/40475/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>