[GitHub] [superset] zhaoyongjie commented on pull request #18960: fix(chart): deprecate persisting url_params

[GitBox <gi...@apache.org>]

zhaoyongjie commented on pull request #18960:
URL: https://github.com/apache/superset/pull/18960#issuecomment-1055385662


   Hey @villebro @michael-s-molina
   
   Thanks for the fix. I tested all scenarios based on this PR, and it works fine!
   1. _url_params_ was removed when I created a chart on the master branch and switch to the current PR.
   2. _url_params_ was removed if I create a chart from the current branch.
   
   But now the problem is, we can't find the original form_data_key anymore. This means that every time Chart is opened, a new form_data_key is generated. I would hear your thoughts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org