You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/27 12:37:31 UTC
[GitHub] [airflow] potiuk opened a new pull request #14508: Adds verbose mode to prepare_provider_packages scripts/breeze cmds.
potiuk opened a new pull request #14508:
URL: https://github.com/apache/airflow/pull/14508
Also clarified a little unclear change resulting from #14480 which
did not carry an explanation why we want to return exit code 64.
Explanation is added back and explicit check for False is used. It is
not clear how result callback function behaves when comand returns
no value (it could easily be called with result = None). This is
not clear in the click documentation, so expicit check for False
value better reflects the intention here.
Breeze commands and documentation is also updated so that both
invocation via breeze (which assures coommon import check) and
manual execution for debugging can take advantage of it.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #14508: Adds verbose mode to prepare_provider_packages scripts/breeze cmds.
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #14508:
URL: https://github.com/apache/airflow/pull/14508#discussion_r585997378
##########
File path: dev/provider_packages/README_BACKPORT_PACKAGES.md
##########
@@ -199,6 +199,7 @@ Debugging can be done in exactly the same way as in case of [Regular providers](
difference is that all scripts there should have ``--backports`` flag added. When updating
documentation you can also specify ``--release-version`` manually.
+You can add ``--verbose`` flag in breeze command if you want to see commands executed.
Review comment:
```suggestion
You can add `--verbose` flag in breeze command if you want to see commands executed.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #14508: Adds verbose mode to prepare_provider_packages scripts/breeze cmds.
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #14508:
URL: https://github.com/apache/airflow/pull/14508#discussion_r589096946
##########
File path: dev/provider_packages/prepare_provider_packages.py
##########
@@ -438,7 +445,7 @@ def is_from_the_expected_base_package(the_class: Type, expected_package: str) ->
return the_class.__module__.startswith(expected_package)
-def inherits_from(the_class: Type, expected_ancestor: Type) -> bool:
+def inherits_from(the_class: Type, expected_ancestor: Optional[Type]) -> bool:
Review comment:
It's not strictly necessary. The 'optional' does not imply default (the case here was that the mypy realised that we can both - expect None here and pass it. but it does not have to be default (I added it thought).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #14508: Adds verbose mode to prepare_provider_packages scripts/breeze cmds.
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #14508:
URL: https://github.com/apache/airflow/pull/14508#discussion_r585997280
##########
File path: dev/provider_packages/README.md
##########
@@ -249,6 +250,9 @@ You can see for example list of all provider packages:
./dev/provider_packages/prepare_provider_packages.py list-providers-packages
```
+
+You can add ``--verbose`` flag in breeze command if you want to see commands executed.
Review comment:
```suggestion
You can add `--verbose` flag in breeze command if you want to see commands executed.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #14508: Adds verbose mode to prepare_provider_packages scripts/breeze cmds.
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #14508:
URL: https://github.com/apache/airflow/pull/14508#issuecomment-789289850
Smaill improvement to provider package preparation - less verbosity, more clarity on what is being released and why @ashb @kaxil
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #14508: Adds verbose mode to prepare_provider_packages scripts/breeze cmds.
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #14508:
URL: https://github.com/apache/airflow/pull/14508#discussion_r589097147
##########
File path: dev/provider_packages/prepare_provider_packages.py
##########
@@ -951,14 +958,14 @@ def strip_leading_zeros(version: str) -> str:
This converts 1974.04.03 to 1974.4.3 as the format with leading month and day zeros is not accepted
by PIP versioning.
- :param version: version number in calver format (potentially with leading 0s in date and month)
+ :param version: version number in CALVER format (potentially with leading 0s in date and month)
:return: string with leading 0s after dot replaced.
"""
return ".".join(str(int(i)) for i in version.split("."))
def get_previous_release_info(
- previous_release_version: str, past_releases: List[ReleaseInfo], current_release_version: str
+ previous_release_version: Optional[str], past_releases: List[ReleaseInfo], current_release_version: str
Review comment:
Here we even cannot do it, because the following parameters have no defaults - so we can pass 'previous version as Null expliciltly, but it will never be default.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14508: Adds verbose mode to prepare_provider_packages scripts/breeze cmds.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14508:
URL: https://github.com/apache/airflow/pull/14508#issuecomment-792365063
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #14508: Adds verbose mode to prepare_provider_packages scripts/breeze cmds.
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #14508:
URL: https://github.com/apache/airflow/pull/14508#discussion_r585997750
##########
File path: dev/provider_packages/prepare_provider_packages.py
##########
@@ -438,7 +445,7 @@ def is_from_the_expected_base_package(the_class: Type, expected_package: str) ->
return the_class.__module__.startswith(expected_package)
-def inherits_from(the_class: Type, expected_ancestor: Type) -> bool:
+def inherits_from(the_class: Type, expected_ancestor: Optional[Type]) -> bool:
Review comment:
should we have the default value as `None` too since it is `Optional`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #14508: Adds verbose mode to prepare_provider_packages scripts/breeze cmds.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14508:
URL: https://github.com/apache/airflow/pull/14508#issuecomment-787070109
[The Workflow run](https://github.com/apache/airflow/actions/runs/605511001) is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on a change in pull request #14508: Adds verbose mode to prepare_provider_packages scripts/breeze cmds.
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #14508:
URL: https://github.com/apache/airflow/pull/14508#discussion_r585997950
##########
File path: dev/provider_packages/prepare_provider_packages.py
##########
@@ -951,14 +958,14 @@ def strip_leading_zeros(version: str) -> str:
This converts 1974.04.03 to 1974.4.3 as the format with leading month and day zeros is not accepted
by PIP versioning.
- :param version: version number in calver format (potentially with leading 0s in date and month)
+ :param version: version number in CALVER format (potentially with leading 0s in date and month)
:return: string with leading 0s after dot replaced.
"""
return ".".join(str(int(i)) for i in version.split("."))
def get_previous_release_info(
- previous_release_version: str, past_releases: List[ReleaseInfo], current_release_version: str
+ previous_release_version: Optional[str], past_releases: List[ReleaseInfo], current_release_version: str
Review comment:
same here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #14508: Adds verbose mode to prepare_provider_packages scripts/breeze cmds.
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #14508:
URL: https://github.com/apache/airflow/pull/14508
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org