[jira] [Commented] (SOLR-10912) Adding automatic patch validation

["Mikhail Khludnev (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-10912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17004489#comment-17004489 ] 

Mikhail Khludnev commented on SOLR-10912:
-----------------------------------------

[~sarowe], regarding 
??Since Allen Wittenauer wrote above that "The job on Jenkins that feeds test-patch is NOT github aware", I don't plan on doing this verification. I'll include this on a TODO list below.??
Can it be YETUS-614, which is fixed in Yetus 0.8.0? Note, I tried to use github PR link in precommit, but  got just this 
https://builds.apache.org/job/PreCommit-SOLR-Build/641/console
{code:java}
[Sat Dec 28 08:14:15 UTC 2019 DEBUG]: jira_http_fetch: https://issues.apache.org/jira/browse/SOLR-12490
[Sat Dec 28 08:14:17 UTC 2019 DEBUG]: jira_locate_patch: SOLR-12490 seemed like a Github PR, but there was a failure.
{code}

How we can evaluate Yetus 0.8.0 or the latest one? 


> Adding automatic patch validation
> ---------------------------------
>
>                 Key: SOLR-10912
>                 URL: https://issues.apache.org/jira/browse/SOLR-10912
>             Project: Solr
>          Issue Type: Improvement
>          Components: Build
>            Reporter: Mano Kovacs
>            Assignee: Steven Rowe
>            Priority: Major
>             Fix For: 7.4
>
>         Attachments: SOLR-10912.ok-patch-in-core.patch, SOLR-10912.patch, SOLR-10912.patch, SOLR-10912.sample-patch.patch, SOLR-10912.solj-contrib-facet-error.patch
>
>
> Proposing introduction of automated patch validation, similar what Hadoop or other Apache projects are using (see link). This would ensure that every patch passes a certain set of criterions before getting approved. It would save time for developer (faster feedback loop), save time for committers (less step to do manually), and would increase quality.
> Hadoop is currently using Apache Yetus to run validations, which seems to be a good direction to start. This jira could be the board of discussing the preferred solution.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org