You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Robbie Gemmell (Created) (JIRA)" <ji...@apache.org> on 2012/02/03 16:29:53 UTC
[jira] [Created] (QPID-3810) [Java broker] stop the acceptor thread
exiting when encountering IOExceptions such as too many open files
[Java broker] stop the acceptor thread exiting when encountering IOExceptions such as too many open files
---------------------------------------------------------------------------------------------------------
Key: QPID-3810
URL: https://issues.apache.org/jira/browse/QPID-3810
Project: Qpid
Issue Type: Bug
Components: Java Broker
Affects Versions: 0.14
Reporter: Robbie Gemmell
Assignee: Robbie Gemmell
Fix For: 0.15
The Java brokers new IO acceptor thread will exit when encountering IOExceptions such as too many open files. It should instead catch the Exception and attempt to continue (after a short delay to prevent tight spinning throwing such exceptions) and allow broker operation to continue if the issue is resolved.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3810) [Java broker] stop the acceptor
thread exiting when encountering IOExceptions such as too many open files
Posted by "Keith Wall (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200514#comment-13200514 ]
Keith Wall commented on QPID-3810:
----------------------------------
Changes look fine, but I've just noticed the switch in logger seems to be meaning we are seeing format patterns:
{code}
main 2012-02-04 19:39:12,552 DEBUG [apache.qpid.client.AMQConnectionDelegate_0_10] connecting to host: localhost port: 15672 vhost: test username: guest password: ********
main 2012-02-04 19:39:12,616 DEBUG [transport.network.io.IoNetworkTransport] SO_RCVBUF : %s
main 2012-02-04 19:39:12,616 DEBUG [transport.network.io.IoNetworkTransport] SO_SNDBUF : %s
main 2012-02-04 19:39:12,616 DEBUG [transport.network.io.IoNetworkTransport] TCP_NODELAY : %s
main 2012-02-04 19:39:12,646 DEBUG [apache.qpid.transport.Connection] SEND: [conn:26796e1c] AMQP.1 0-10
{code}
> [Java broker] stop the acceptor thread exiting when encountering IOExceptions such as too many open files
> ---------------------------------------------------------------------------------------------------------
>
> Key: QPID-3810
> URL: https://issues.apache.org/jira/browse/QPID-3810
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.14
> Reporter: Robbie Gemmell
> Assignee: Keith Wall
> Fix For: 0.15
>
>
> The Java brokers new IO acceptor thread will exit when encountering IOExceptions such as too many open files. It should instead catch the Exception and attempt to continue (after a short delay to prevent tight spinning throwing such exceptions) and allow broker operation to continue if the issue is resolved.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Assigned] (QPID-3810) [Java broker] stop the acceptor
thread exiting when encountering IOExceptions such as too many open files
Posted by "Keith Wall (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall reassigned QPID-3810:
--------------------------------
Assignee: Robbie Gemmell (was: Keith Wall)
> [Java broker] stop the acceptor thread exiting when encountering IOExceptions such as too many open files
> ---------------------------------------------------------------------------------------------------------
>
> Key: QPID-3810
> URL: https://issues.apache.org/jira/browse/QPID-3810
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.14
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.15
>
>
> The Java brokers new IO acceptor thread will exit when encountering IOExceptions such as too many open files. It should instead catch the Exception and attempt to continue (after a short delay to prevent tight spinning throwing such exceptions) and allow broker operation to continue if the issue is resolved.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Assigned] (QPID-3810) [Java broker] stop the acceptor
thread exiting when encountering IOExceptions such as too many open files
Posted by "Robbie Gemmell (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell reassigned QPID-3810:
------------------------------------
Assignee: Keith Wall (was: Robbie Gemmell)
Keith, could you review this change please? Thanks, Robbie.
> [Java broker] stop the acceptor thread exiting when encountering IOExceptions such as too many open files
> ---------------------------------------------------------------------------------------------------------
>
> Key: QPID-3810
> URL: https://issues.apache.org/jira/browse/QPID-3810
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.14
> Reporter: Robbie Gemmell
> Assignee: Keith Wall
> Fix For: 0.15
>
>
> The Java brokers new IO acceptor thread will exit when encountering IOExceptions such as too many open files. It should instead catch the Exception and attempt to continue (after a short delay to prevent tight spinning throwing such exceptions) and allow broker operation to continue if the issue is resolved.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3810) [Java broker] stop the acceptor
thread exiting when encountering IOExceptions such as too many open files
Posted by "Robbie Gemmell (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200547#comment-13200547 ]
Robbie Gemmell commented on QPID-3810:
--------------------------------------
Oops, didn't notice those. Updated now, 3rd time lucky? :)
> [Java broker] stop the acceptor thread exiting when encountering IOExceptions such as too many open files
> ---------------------------------------------------------------------------------------------------------
>
> Key: QPID-3810
> URL: https://issues.apache.org/jira/browse/QPID-3810
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.14
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.15
>
>
> The Java brokers new IO acceptor thread will exit when encountering IOExceptions such as too many open files. It should instead catch the Exception and attempt to continue (after a short delay to prevent tight spinning throwing such exceptions) and allow broker operation to continue if the issue is resolved.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Assigned] (QPID-3810) [Java broker] stop the acceptor
thread exiting when encountering IOExceptions such as too many open files
Posted by "Robbie Gemmell (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell reassigned QPID-3810:
------------------------------------
Assignee: Keith Wall (was: Robbie Gemmell)
> [Java broker] stop the acceptor thread exiting when encountering IOExceptions such as too many open files
> ---------------------------------------------------------------------------------------------------------
>
> Key: QPID-3810
> URL: https://issues.apache.org/jira/browse/QPID-3810
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.14
> Reporter: Robbie Gemmell
> Assignee: Keith Wall
> Fix For: 0.15
>
>
> The Java brokers new IO acceptor thread will exit when encountering IOExceptions such as too many open files. It should instead catch the Exception and attempt to continue (after a short delay to prevent tight spinning throwing such exceptions) and allow broker operation to continue if the issue is resolved.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3810) [Java broker] stop the acceptor
thread exiting when encountering IOExceptions such as too many open files
Posted by "Robbie Gemmell (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200414#comment-13200414 ]
Robbie Gemmell commented on QPID-3810:
--------------------------------------
Changes made, can you look it over again Keith?
Thanks,
Robbie
> [Java broker] stop the acceptor thread exiting when encountering IOExceptions such as too many open files
> ---------------------------------------------------------------------------------------------------------
>
> Key: QPID-3810
> URL: https://issues.apache.org/jira/browse/QPID-3810
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.14
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.15
>
>
> The Java brokers new IO acceptor thread will exit when encountering IOExceptions such as too many open files. It should instead catch the Exception and attempt to continue (after a short delay to prevent tight spinning throwing such exceptions) and allow broker operation to continue if the issue is resolved.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Updated] (QPID-3810) [Java broker] stop the acceptor thread
exiting when encountering IOExceptions such as too many open files
Posted by "Robbie Gemmell (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell updated QPID-3810:
---------------------------------
Status: Ready To Review (was: In Progress)
> [Java broker] stop the acceptor thread exiting when encountering IOExceptions such as too many open files
> ---------------------------------------------------------------------------------------------------------
>
> Key: QPID-3810
> URL: https://issues.apache.org/jira/browse/QPID-3810
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.14
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.15
>
>
> The Java brokers new IO acceptor thread will exit when encountering IOExceptions such as too many open files. It should instead catch the Exception and attempt to continue (after a short delay to prevent tight spinning throwing such exceptions) and allow broker operation to continue if the issue is resolved.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Resolved] (QPID-3810) [Java broker] stop the acceptor
thread exiting when encountering IOExceptions such as too many open files
Posted by "Keith Wall (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall resolved QPID-3810.
------------------------------
Resolution: Fixed
Looks good to me.
> [Java broker] stop the acceptor thread exiting when encountering IOExceptions such as too many open files
> ---------------------------------------------------------------------------------------------------------
>
> Key: QPID-3810
> URL: https://issues.apache.org/jira/browse/QPID-3810
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.14
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.15
>
>
> The Java brokers new IO acceptor thread will exit when encountering IOExceptions such as too many open files. It should instead catch the Exception and attempt to continue (after a short delay to prevent tight spinning throwing such exceptions) and allow broker operation to continue if the issue is resolved.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Assigned] (QPID-3810) [Java broker] stop the acceptor
thread exiting when encountering IOExceptions such as too many open files
Posted by "Keith Wall (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Keith Wall reassigned QPID-3810:
--------------------------------
Assignee: Robbie Gemmell (was: Keith Wall)
> [Java broker] stop the acceptor thread exiting when encountering IOExceptions such as too many open files
> ---------------------------------------------------------------------------------------------------------
>
> Key: QPID-3810
> URL: https://issues.apache.org/jira/browse/QPID-3810
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.14
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Fix For: 0.15
>
>
> The Java brokers new IO acceptor thread will exit when encountering IOExceptions such as too many open files. It should instead catch the Exception and attempt to continue (after a short delay to prevent tight spinning throwing such exceptions) and allow broker operation to continue if the issue is resolved.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] [Commented] (QPID-3810) [Java broker] stop the acceptor
thread exiting when encountering IOExceptions such as too many open files
Posted by "Keith Wall (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-3810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13200381#comment-13200381 ]
Keith Wall commented on QPID-3810:
----------------------------------
Hi Robbie,
A couple of comments, most of which could be equally applied to the previous version:
1) In the InterruptedException catch block, we should either re-interrupt ourselves, or set _closed = true, to make sure that the AcceptingThread responds correctly to an interrupt and shuts itself down.
2) In the event of a RuntimeException (line 223) or IOException (line 227), we should close any (non-null) Socket that was accepted (line 206) to avoid a potential socket leak and ensure that the peer gets a exception.
3) Guard the new debug in the finally with isDebugEnabled.
HTH, Keith.
> [Java broker] stop the acceptor thread exiting when encountering IOExceptions such as too many open files
> ---------------------------------------------------------------------------------------------------------
>
> Key: QPID-3810
> URL: https://issues.apache.org/jira/browse/QPID-3810
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.14
> Reporter: Robbie Gemmell
> Assignee: Keith Wall
> Fix For: 0.15
>
>
> The Java brokers new IO acceptor thread will exit when encountering IOExceptions such as too many open files. It should instead catch the Exception and attempt to continue (after a short delay to prevent tight spinning throwing such exceptions) and allow broker operation to continue if the issue is resolved.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org