You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by su...@apache.org on 2023/11/10 16:09:05 UTC

(druid) branch master updated: Fix for segment/count Metric Not Emitting with Statsd-emitter (#15347)

This is an automated email from the ASF dual-hosted git repository.

suneet pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git


The following commit(s) were added to refs/heads/master by this push:
     new 3a3d37ef405 Fix for segment/count Metric Not Emitting with Statsd-emitter (#15347)
3a3d37ef405 is described below

commit 3a3d37ef40596b6540b6d30ac82a20766335627b
Author: YongGang <ma...@gmail.com>
AuthorDate: Fri Nov 10 08:08:58 2023 -0800

    Fix for segment/count Metric Not Emitting with Statsd-emitter (#15347)
    
    * fix segment/count metric in Statsd-emitter
    
    * update doc
    
    * Update docs/development/extensions-contrib/prometheus.md
    
    Co-authored-by: Suneet Saldanha <su...@apache.org>
    
    * Update docs/development/extensions-contrib/statsd.md
    
    Co-authored-by: Suneet Saldanha <su...@apache.org>
    
    ---------
    
    Co-authored-by: Suneet Saldanha <su...@apache.org>
---
 docs/development/extensions-contrib/prometheus.md                   | 4 ++--
 docs/development/extensions-contrib/statsd.md                       | 6 +++---
 .../statsd-emitter/src/main/resources/defaultMetricDimensions.json  | 4 ++--
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/docs/development/extensions-contrib/prometheus.md b/docs/development/extensions-contrib/prometheus.md
index 25e521a265f..21d58b28143 100644
--- a/docs/development/extensions-contrib/prometheus.md
+++ b/docs/development/extensions-contrib/prometheus.md
@@ -107,8 +107,8 @@ For metrics which are emitted from multiple services with different dimensions,
 the service name. For example:
 
 ```json
-"coordinator-segment/count" : { "dimensions" : ["dataSource"], "type" : "gauge" },
-"historical-segment/count" : { "dimensions" : ["dataSource", "tier", "priority"], "type" : "gauge" }
+"druid/coordinator-segment/count" : { "dimensions" : ["dataSource"], "type" : "gauge" },
+"druid/historical-segment/count" : { "dimensions" : ["dataSource", "tier", "priority"], "type" : "gauge" }
 ```
  
 For most use cases, the default mapping is sufficient.
diff --git a/docs/development/extensions-contrib/statsd.md b/docs/development/extensions-contrib/statsd.md
index 5ad705a31f2..6a3ce7a2dbc 100644
--- a/docs/development/extensions-contrib/statsd.md
+++ b/docs/development/extensions-contrib/statsd.md
@@ -65,7 +65,7 @@ e.g.
 For metrics which are emitted from multiple services with different dimensions, the metric name is prefixed with
 the service name.
 e.g.
-`"coordinator-segment/count" : { "dimensions" : ["dataSource"], "type" : "gauge" },
- "historical-segment/count" : { "dimensions" : ["dataSource", "tier", "priority"], "type" : "gauge" }`
- 
+`"druid/coordinator-segment/count" : { "dimensions" : ["dataSource"], "type" : "gauge" },
+ "druid/historical-segment/count" : { "dimensions" : ["dataSource", "tier", "priority"], "type" : "gauge" }`
+
 For most use-cases, the default mapping is sufficient.
diff --git a/extensions-contrib/statsd-emitter/src/main/resources/defaultMetricDimensions.json b/extensions-contrib/statsd-emitter/src/main/resources/defaultMetricDimensions.json
index 3d2422ce235..11fe43909d0 100644
--- a/extensions-contrib/statsd-emitter/src/main/resources/defaultMetricDimensions.json
+++ b/extensions-contrib/statsd-emitter/src/main/resources/defaultMetricDimensions.json
@@ -138,8 +138,8 @@
   "sys/storage/used" : { "dimensions" : ["fsDirName"], "type" : "gauge"},
   "sys/cpu" : { "dimensions" : ["cpuName", "cpuTime"], "type" : "gauge"},
 
-  "coordinator-segment/count" : { "dimensions" : ["dataSource"], "type" : "gauge" },
-  "historical-segment/count" : { "dimensions" : ["dataSource", "tier", "priority"], "type" : "gauge" },
+  "druid/coordinator-segment/count" : { "dimensions" : ["dataSource"], "type" : "gauge" },
+  "druid/historical-segment/count" : { "dimensions" : ["dataSource", "tier", "priority"], "type" : "gauge" },
 
   "jetty/numOpenConnections": { "dimensions" : [], "type" : "gauge" },
   "jetty/threadPool/total": { "dimensions" : [], "type" : "gauge" },


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org