You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by sunjincheng121 <gi...@git.apache.org> on 2017/05/22 09:10:46 UTC
[GitHub] flink pull request #3958: [FLINK-6650][table] Improve the error message for ...
GitHub user sunjincheng121 opened a pull request:
https://github.com/apache/flink/pull/3958
[FLINK-6650][table] Improve the error message for toAppendStream
The PR have three small changes:
1. Improve the error message for toAppendStream.
2. Change incorrect variable name.
3.Add JAVA DOC for key parameter of method.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-6650][table] Improve the error message for toAppendStream")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [ ] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [ ] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sunjincheng121/flink FLINK-6650-PR
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3958.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3958
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3958: [FLINK-6650][table] Improve the error message for toAppen...
Posted by sunjincheng121 <gi...@git.apache.org>.
Github user sunjincheng121 commented on the issue:
https://github.com/apache/flink/pull/3958
Hi @twalthr Thanks for review the PR. I have updated the PR. According your comment.
Best,
SunJincheng
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3958: [FLINK-6650][table] Improve the error message for ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3958
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3958: [FLINK-6650][table] Improve the error message for ...
Posted by sunjincheng121 <gi...@git.apache.org>.
Github user sunjincheng121 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3958#discussion_r118038355
--- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala ---
@@ -629,8 +629,7 @@ abstract class StreamTableEnvironment(
// if no change flags are requested, verify table is an insert-only (append-only) table.
if (!withChangeFlag && !isAppendOnly(logicalPlan)) {
throw new TableException(
- "Table is not an append-only table. " +
- "Output needs to handle update and delete changes.")
+ "Table is not an append-only table. Try calling the [table.toRetractStream] method.")
--- End diff --
Yes, make sense to user. should update it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3958: [FLINK-6650][table] Improve the error message for toAppen...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/3958
Merging this...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3958: [FLINK-6650][table] Improve the error message for ...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on a diff in the pull request:
https://github.com/apache/flink/pull/3958#discussion_r117724493
--- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala ---
@@ -629,8 +629,7 @@ abstract class StreamTableEnvironment(
// if no change flags are requested, verify table is an insert-only (append-only) table.
if (!withChangeFlag && !isAppendOnly(logicalPlan)) {
throw new TableException(
- "Table is not an append-only table. " +
- "Output needs to handle update and delete changes.")
+ "Table is not an append-only table. Try calling the [table.toRetractStream] method.")
--- End diff --
I don't think that "try calling..." is a helpful message. What about "Table is not an append-only table. Use the toRetractStream() in order to handle add and retract messages."?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---