You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/03/13 22:43:26 UTC
[GitHub] [couchdb] nickva opened a new pull request #2663: Refactor "tx too
old" tests
nickva opened a new pull request #2663: Refactor "tx too old" tests
URL: https://github.com/apache/couchdb/pull/2663
* There was a good amount of duplication between `_db_crud_tests` and
`_changes_fold_tests`, so make a common test utility module so both suites can
use.
* Clean up test names. Previously some were named `tx_too_long` but since the
official FDB error is `transaction_too_old` rename them to match a bit
better.
* `list_dbs_info` implementation queue of 100 futures to parallelize fetching.
So its test was update to create more than 100 dbs. Creating 100 dbs took
about 3 seconds so add a small parallel map (pmap) utility function to help
with that.
To test:
`make check-fdb`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] jaydoane commented on a change in pull request #2663:
Refactor "tx too old" tests
Posted by GitBox <gi...@apache.org>.
jaydoane commented on a change in pull request #2663: Refactor "tx too old" tests
URL: https://github.com/apache/couchdb/pull/2663#discussion_r392626757
##########
File path: src/fabric/test/fabric2_tutil.erl
##########
@@ -0,0 +1,99 @@
+% Licensed under the Apache License, Version 2.0 (the "License"); you may not
Review comment:
At the risk of bike shedding, `tutil` seems a little terse, and I'd prefer `fabric2_test_util` if it were up for a vote.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] nickva edited a comment on issue #2663: Refactor "tx too
old" tests
Posted by GitBox <gi...@apache.org>.
nickva edited a comment on issue #2663: Refactor "tx too old" tests
URL: https://github.com/apache/couchdb/pull/2663#issuecomment-599238414
Added a minor fixup. @davisp suggested to enhance pmap to make it properly re-throw exceptions so it behaves closer to `lists:map/2`. I had forgotten to update the original PR with that.
Also I moved it to `fabric2_util` so it can more generally useful.
As a benefit I could remove the extra "validate pmap results" steps from the tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] nickva commented on issue #2663: Refactor "tx too old"
tests
Posted by GitBox <gi...@apache.org>.
nickva commented on issue #2663: Refactor "tx too old" tests
URL: https://github.com/apache/couchdb/pull/2663#issuecomment-599238414
Added a minor fixup. @davisp suggested to enhance pmap to make it properly re-throw exceptions so it behaves closer to `lists:map/2. I had forgotten to update the original PR with that.
Also I moved it to `fabric2_util` so it can more generally useful.
As a benefit I could remove the extra "validate pmap results" steps from the tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] nickva merged pull request #2663: Refactor "tx too old"
tests
Posted by GitBox <gi...@apache.org>.
nickva merged pull request #2663: Refactor "tx too old" tests
URL: https://github.com/apache/couchdb/pull/2663
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] nickva edited a comment on issue #2663: Refactor "tx too
old" tests
Posted by GitBox <gi...@apache.org>.
nickva edited a comment on issue #2663: Refactor "tx too old" tests
URL: https://github.com/apache/couchdb/pull/2663#issuecomment-599238414
Added a minor fixup. @davisp suggested to enhance pmap to make it properly re-throw exceptions so it behaves closer to `lists:map/2`. I had forgotten to update the original PR with that.
Also I moved it to `fabric2_util` so it can be more generally useful.
As a benefit I could remove the extra "validate pmap results" steps from the tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [couchdb] nickva commented on a change in pull request #2663:
Refactor "tx too old" tests
Posted by GitBox <gi...@apache.org>.
nickva commented on a change in pull request #2663: Refactor "tx too old" tests
URL: https://github.com/apache/couchdb/pull/2663#discussion_r392628907
##########
File path: src/fabric/test/fabric2_tutil.erl
##########
@@ -0,0 +1,99 @@
+% Licensed under the Apache License, Version 2.0 (the "License"); you may not
Review comment:
Changed to fabric2_test_util
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services