You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/04 11:13:04 UTC

[GitHub] [airflow] ashb commented on pull request #13984: Fixed reading from zip package to default to text.

ashb commented on pull request #13984:
URL: https://github.com/apache/airflow/pull/13984#issuecomment-773229399


   
   > _That_ I agree with. In this PR I tried to match the way things are done in the existing code and fix the specific issue at focus with minimal changes. If the elders agree, I'll certainly be happy to change the test implementation. @ashb , I'm new to the codebase, can you recommend exact files (a zip and a non-zip Python source code-like content) to use that you say already exist in the tests?
   
   @levahim `tests/dags/test_zip.zip` was the zip file I was thinking of, and anything else in that dir for a .py folder.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org