[jira] [Commented] (FLINK-9571) Switch to internal states in StateBinder

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16513866#comment-16513866 ] 

ASF GitHub Bot commented on FLINK-9571:
---------------------------------------

GitHub user azagrebin opened a pull request:

    https://github.com/apache/flink/pull/6173

    [FLINK-9571] Refactor StateBinder to internal backend specific state factories

    ## What is the purpose of the change
    
    Remove StateBinder and StateDescriptor.bind method from State user API.
    Introduce AbstractKeyedStateBackend.createState factory method.
    The factory method dispatches StateDescriptor.class to backend specific state implementation.
    
    ## Brief change log
    
      - Deprecate StateBinder and StateDescriptor.bind in state descriptors
      - Add abstract AbstractKeyedStateBackend.createState
      - Implement createState in heap, rockdb and queryable state client backends
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/azagrebin/flink FLINK-9571

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6173.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6173
    
----
commit de5085f75331488fc6b0f72ec06c973c61eaef79
Author: Andrey Zagrebin <az...@...>
Date:   2018-06-13T08:24:10Z

    [FLINK-9571] Refactor StateBinder to internal backend specific state factories

----


> Switch to internal states in StateBinder
> ----------------------------------------
>
>                 Key: FLINK-9571
>                 URL: https://issues.apache.org/jira/browse/FLINK-9571
>             Project: Flink
>          Issue Type: Sub-task
>          Components: State Backends, Checkpointing
>    Affects Versions: 1.6.0
>            Reporter: Andrey Zagrebin
>            Assignee: Andrey Zagrebin
>            Priority: Major
>             Fix For: 1.6.0
>
>
> The StateBinder factory for state objects is not a part of public API and it produces in fact only internal states.
> It can be changed it to produce internal state interfaces instead of public API.
> This can help to expose internal state API for internal components which use the factory, e.g. for state TTL wrappers.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)