You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by is...@apache.org on 2017/01/20 12:47:49 UTC

lucene-solr:jira/solr-5944: SOLR-5944: Returning the field names from IndexWriter and FieldInfos as UnmodifiableSets

Repository: lucene-solr
Updated Branches:
  refs/heads/jira/solr-5944 c192e69d6 -> 87c02d7df


SOLR-5944: Returning the field names from IndexWriter and FieldInfos as UnmodifiableSets


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/87c02d7d
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/87c02d7d
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/87c02d7d

Branch: refs/heads/jira/solr-5944
Commit: 87c02d7dfdeee8feeca97a2b722184a871580b69
Parents: c192e69
Author: Ishan Chattopadhyaya <is...@apache.org>
Authored: Fri Jan 20 18:17:37 2017 +0530
Committer: Ishan Chattopadhyaya <is...@apache.org>
Committed: Fri Jan 20 18:17:37 2017 +0530

----------------------------------------------------------------------
 lucene/core/src/java/org/apache/lucene/index/FieldInfos.java  | 2 +-
 lucene/core/src/java/org/apache/lucene/index/IndexWriter.java | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/87c02d7d/lucene/core/src/java/org/apache/lucene/index/FieldInfos.java
----------------------------------------------------------------------
diff --git a/lucene/core/src/java/org/apache/lucene/index/FieldInfos.java b/lucene/core/src/java/org/apache/lucene/index/FieldInfos.java
index 4e9d4fc..7c3e23c 100644
--- a/lucene/core/src/java/org/apache/lucene/index/FieldInfos.java
+++ b/lucene/core/src/java/org/apache/lucene/index/FieldInfos.java
@@ -326,7 +326,7 @@ public class FieldInfos implements Iterable<FieldInfo> {
     }
     
     synchronized Set<String> getFieldNames() {
-      return nameToNumber.keySet();
+      return Collections.unmodifiableSet(nameToNumber.keySet());
     }
     
     synchronized void clear() {

http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/87c02d7d/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
----------------------------------------------------------------------
diff --git a/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java b/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
index 89a37be..53347ad 100644
--- a/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
+++ b/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
@@ -1789,7 +1789,7 @@ public class IndexWriter implements Closeable, TwoPhaseCommit, Accountable {
    * of the index.
    */
   public Set<String> getFieldNames() {
-    return globalFieldNumberMap.getFieldNames();
+    return Collections.unmodifiableSet(globalFieldNumberMap.getFieldNames());
   }
 
   final String newSegmentName() {