You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/03/18 16:19:23 UTC
[GitHub] [openwhisk-runtime-dotnet] indiePeeters opened a new pull request
#33: Increased MaxRequestBodySize, so larger zip files can be uploaded
indiePeeters opened a new pull request #33: Increased MaxRequestBodySize, so larger zip files can be uploaded
URL: https://github.com/apache/openwhisk-runtime-dotnet/pull/33
I was trying to create an action with a 30mb+ zip. Unfortunately this resulted into an BadHttpRequestException because the request body was too large.
Therefore Ive increased the MaxRequestBodySize so uploading zip files that are larger than the default limit is possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-runtime-dotnet] indiePeeters commented on a change in
pull request #33: Increased MaxRequestBodySize,
so larger zip files can be uploaded
Posted by GitBox <gi...@apache.org>.
indiePeeters commented on a change in pull request #33: Increased MaxRequestBodySize, so larger zip files can be uploaded
URL: https://github.com/apache/openwhisk-runtime-dotnet/pull/33#discussion_r395201345
##########
File path: tests/src/test/scala/actionContainers/DotNet3_1ActionContainerTests.scala
##########
@@ -100,6 +101,19 @@ class DotNet3_1ActionContainerTests extends BasicActionRunnerTests with WskActor
})
}
+ it should "support a large payload" in {
+ val (out, err) = withActionContainer() { c =>
+ val sb = new StringBuilder(18000000 + functionb64.length());
Review comment:
Thanks for your suggestion, ive committed your suggestion with a small change in 1600d77
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-runtime-dotnet] shawnallen85 merged pull request #33:
Increased MaxRequestBodySize, so larger zip files can be uploaded
Posted by GitBox <gi...@apache.org>.
shawnallen85 merged pull request #33: Increased MaxRequestBodySize, so larger zip files can be uploaded
URL: https://github.com/apache/openwhisk-runtime-dotnet/pull/33
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-runtime-dotnet] rabbah commented on a change in pull
request #33: Increased MaxRequestBodySize,
so larger zip files can be uploaded
Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #33: Increased MaxRequestBodySize, so larger zip files can be uploaded
URL: https://github.com/apache/openwhisk-runtime-dotnet/pull/33#discussion_r395164907
##########
File path: tests/src/test/scala/actionContainers/DotNet3_1ActionContainerTests.scala
##########
@@ -100,6 +101,19 @@ class DotNet3_1ActionContainerTests extends BasicActionRunnerTests with WskActor
})
}
+ it should "support a large payload" in {
+ val (out, err) = withActionContainer() { c =>
+ val sb = new StringBuilder(18000000 + functionb64.length());
Review comment:
```suggestion
val sb = " " * (18000000 + functionb64.length())
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-runtime-dotnet] indiePeeters commented on issue #33:
Increased MaxRequestBodySize, so larger zip files can be uploaded
Posted by GitBox <gi...@apache.org>.
indiePeeters commented on issue #33: Increased MaxRequestBodySize, so larger zip files can be uploaded
URL: https://github.com/apache/openwhisk-runtime-dotnet/pull/33#issuecomment-602593575
@shawnallen85 Thank you for merging this pull request! Ive signed the ICLA and my name should be in the list now. Do you know when the next release will take place? I would like to start using openwhisk with larger files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-runtime-dotnet] rabbah commented on issue #33: Increased
MaxRequestBodySize, so larger zip files can be uploaded
Posted by GitBox <gi...@apache.org>.
rabbah commented on issue #33: Increased MaxRequestBodySize, so larger zip files can be uploaded
URL: https://github.com/apache/openwhisk-runtime-dotnet/pull/33#issuecomment-602766225
@indiePeeters are you deploying your own instance of openwhisk or using it as a hosted service?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-runtime-dotnet] rabbah commented on a change in pull
request #33: Increased MaxRequestBodySize,
so larger zip files can be uploaded
Posted by GitBox <gi...@apache.org>.
rabbah commented on a change in pull request #33: Increased MaxRequestBodySize, so larger zip files can be uploaded
URL: https://github.com/apache/openwhisk-runtime-dotnet/pull/33#discussion_r395164613
##########
File path: tests/src/test/scala/actionContainers/DotNet3_1ActionContainerTests.scala
##########
@@ -100,6 +101,19 @@ class DotNet3_1ActionContainerTests extends BasicActionRunnerTests with WskActor
})
}
+ it should "support a large payload" in {
+ val (out, err) = withActionContainer() { c =>
+ val sb = new StringBuilder(18000000 + functionb64.length());
+ sb.append(functionb64);
+ for (i<-0 to 18000000) {
Review comment:
`" " * 18000000` to get a string that long.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-runtime-dotnet] indiePeeters commented on issue #33:
Increased MaxRequestBodySize, so larger zip files can be uploaded
Posted by GitBox <gi...@apache.org>.
indiePeeters commented on issue #33: Increased MaxRequestBodySize, so larger zip files can be uploaded
URL: https://github.com/apache/openwhisk-runtime-dotnet/pull/33#issuecomment-601318303
@shawnallen85 @rabbah Thanks for your suggestions, Ive added unittests to both the dotnet 2.2 and 3.1 runtime. Which should test the init with a payload that is around 36mb+
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-runtime-dotnet] shawnallen85 commented on issue #33:
Increased MaxRequestBodySize, so larger zip files can be uploaded
Posted by GitBox <gi...@apache.org>.
shawnallen85 commented on issue #33: Increased MaxRequestBodySize, so larger zip files can be uploaded
URL: https://github.com/apache/openwhisk-runtime-dotnet/pull/33#issuecomment-600734038
@indiePeeters Would you be able to update the .NET Core 2.2 runtime as well and create unit tests with a payload larger than 30MB and less than 48MB (default exec-size-limit)?
Thanks!!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-runtime-dotnet] rabbah commented on issue #33: Increased
MaxRequestBodySize, so larger zip files can be uploaded
Posted by GitBox <gi...@apache.org>.
rabbah commented on issue #33: Increased MaxRequestBodySize, so larger zip files can be uploaded
URL: https://github.com/apache/openwhisk-runtime-dotnet/pull/33#issuecomment-601281731
Thanks @indiePeeters for the contribution and runtime enhancement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk-runtime-dotnet] shawnallen85 commented on issue #33:
Increased MaxRequestBodySize, so larger zip files can be uploaded
Posted by GitBox <gi...@apache.org>.
shawnallen85 commented on issue #33: Increased MaxRequestBodySize, so larger zip files can be uploaded
URL: https://github.com/apache/openwhisk-runtime-dotnet/pull/33#issuecomment-601741091
@indiePeeters Have you signed an Apache CLA? It's fine if you haven't, I just want to double check. I searched for "Peeters" but didn't get any hits. Might be good to look into if you plan on future contributions. More info here: https://github.com/apache/openwhisk-runtime-dotnet/blob/master/CONTRIBUTING.md
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services