You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/03/11 23:47:21 UTC
Review Request 19077: Only darwin/clang needs GTEST to supply its own tr1
tuple
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19077/
-----------------------------------------------------------
Review request for mesos, Till Toenshoff and Vinod Kone.
Bugs: MESOS-750
https://issues.apache.org/jira/browse/MESOS-750
Repository: mesos-git
Description
-------
See summary
Diffs
-----
3rdparty/libprocess/configure.ac f4e0bcb8ea627100f44aaa2df1fce38fc9e60de2
configure.ac 390f11b829af35ab207ce753d03aa058fa72740d
Diff: https://reviews.apache.org/r/19077/diff/
Testing
-------
make check clang/g++-4.4 linux
Thanks,
Dominic Hamon
Re: Review Request 19077: Only darwin/clang needs GTEST to supply its own
tr1 tuple
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19077/#review36878
-----------------------------------------------------------
Patch looks great!
Reviews applied: [19077]
All tests passed.
- Mesos ReviewBot
On March 11, 2014, 11 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19077/
> -----------------------------------------------------------
>
> (Updated March 11, 2014, 11 p.m.)
>
>
> Review request for mesos, Till Toenshoff and Vinod Kone.
>
>
> Bugs: MESOS-750
> https://issues.apache.org/jira/browse/MESOS-750
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac f4e0bcb8ea627100f44aaa2df1fce38fc9e60de2
> configure.ac 390f11b829af35ab207ce753d03aa058fa72740d
>
> Diff: https://reviews.apache.org/r/19077/diff/
>
>
> Testing
> -------
>
> make check clang/g++-4.4 linux
> make check clang darwin (thanks, tillt)
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 19077: Only darwin/clang needs GTEST to supply its own
tr1 tuple
Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19077/#review36873
-----------------------------------------------------------
Ship it!
configure.ac
<https://reviews.apache.org/r/19077/#comment68066>
Not yours, but CPPFLAGS would most likely be a better place for this.
- Till Toenshoff
On March 11, 2014, 11 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19077/
> -----------------------------------------------------------
>
> (Updated March 11, 2014, 11 p.m.)
>
>
> Review request for mesos, Till Toenshoff and Vinod Kone.
>
>
> Bugs: MESOS-750
> https://issues.apache.org/jira/browse/MESOS-750
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac f4e0bcb8ea627100f44aaa2df1fce38fc9e60de2
> configure.ac 390f11b829af35ab207ce753d03aa058fa72740d
>
> Diff: https://reviews.apache.org/r/19077/diff/
>
>
> Testing
> -------
>
> make check clang/g++-4.4 linux
> make check clang darwin (thanks, tillt)
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 19077: Only darwin/clang needs GTEST to supply its own
tr1 tuple
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19077/#review36934
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On March 11, 2014, 11 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19077/
> -----------------------------------------------------------
>
> (Updated March 11, 2014, 11 p.m.)
>
>
> Review request for mesos, Till Toenshoff and Vinod Kone.
>
>
> Bugs: MESOS-750
> https://issues.apache.org/jira/browse/MESOS-750
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/configure.ac f4e0bcb8ea627100f44aaa2df1fce38fc9e60de2
> configure.ac 390f11b829af35ab207ce753d03aa058fa72740d
>
> Diff: https://reviews.apache.org/r/19077/diff/
>
>
> Testing
> -------
>
> make check clang/g++-4.4 linux
> make check clang darwin (thanks, tillt)
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 19077: Only darwin/clang needs GTEST to supply its own
tr1 tuple
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19077/
-----------------------------------------------------------
(Updated March 11, 2014, 4 p.m.)
Review request for mesos, Till Toenshoff and Vinod Kone.
Bugs: MESOS-750
https://issues.apache.org/jira/browse/MESOS-750
Repository: mesos-git
Description
-------
See summary
Diffs
-----
3rdparty/libprocess/configure.ac f4e0bcb8ea627100f44aaa2df1fce38fc9e60de2
configure.ac 390f11b829af35ab207ce753d03aa058fa72740d
Diff: https://reviews.apache.org/r/19077/diff/
Testing (updated)
-------
make check clang/g++-4.4 linux
make check clang darwin (thanks, tillt)
Thanks,
Dominic Hamon