[PR] Restrict topology scheduler strategies to the shipped strategies when no allowlist is configured (storm)

["rzo1 (via GitHub)" <gi...@apache.org>]

rzo1 opened a new pull request, #8986:
URL: https://github.com/apache/storm/pull/8986

   `nimbus.scheduler.strategy.class.whitelist` had no entry in `conf/defaults.yaml`, and `ReflectionUtils.newSchedulerStrategyInstance` treated an unset list as "allow any class", so Nimbus instantiated whatever class a topology named in `topology.scheduler.strategy`.
   
   Unset now means the six strategies that ship with Storm. An explicitly configured list, including an empty one, is honoured unchanged.
   
   Behaviour change: a cluster running an out-of-tree strategy with no allowlist configured will start failing scheduling for those topologies. The exception previously carried no message at all and now names the refused class and the config key to add. Adds `ReflectionUtilsTest`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Restrict topology scheduler strategies to the shipped strategies when no allowlist is configured (storm)

["reiabreu (via GitHub)" <gi...@apache.org>]

reiabreu commented on PR #8986:
URL: https://github.com/apache/storm/pull/8986#issuecomment-5381213560

   _Disclaimer: this comment was generated with the help of an LLM._
   
   Compatibility note (this PR is already approved): this changes the default from "unset whitelist ⇒ any strategy class is allowed" to "only the strategies shipped with Storm." Any cluster that sets a custom `topology.scheduler.strategy` will have those topologies **rejected** after upgrade until an operator adds the custom class to `nimbus.scheduler.strategy.class.whitelist`. It's the intended hardening, but a breaking change worth calling out in the release notes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Restrict topology scheduler strategies to the shipped strategies when no allowlist is configured (storm)

["skrcode (via GitHub)" <gi...@apache.org>]

skrcode commented on PR #8986:
URL: https://github.com/apache/storm/pull/8986#issuecomment-5384292729

   @rzo1 — I ran JAIPilot Cloud against an earlier exact head of this now-merged PR. It produced an AI-generated draft that uses List.of for the default scheduler strategies and adds a focused status-message contract test: https://github.com/skrcode/storm/pull/2
   
   The cloud run passed 610 storm-client and 483 storm-server tests. Since the original PR is merged, this would need to be rebased as a follow-up if still useful. Nothing is auto-merged.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Restrict topology scheduler strategies to the shipped strategies when no allowlist is configured (storm)

["rzo1 (via GitHub)" <gi...@apache.org>]

rzo1 merged PR #8986:
URL: https://github.com/apache/storm/pull/8986


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@storm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org