[GitHub] [incubator-pekko-connectors] mdedetrich commented on a diff in pull request #170: Scala3 ftp support

["mdedetrich (via GitHub)" <gi...@apache.org>]

mdedetrich commented on code in PR #170:
URL: https://github.com/apache/incubator-pekko-connectors/pull/170#discussion_r1225778694


##########
ftp/src/main/scala/org/apache/pekko/stream/connectors/ftp/javadsl/FtpApi.scala:
##########
@@ -573,6 +573,6 @@ object Sftp extends SftpApi {
    */
   def create(customSshClient: SSHClient): SftpApi =
     new SftpApi {
-      override val sshClient: SSHClient = customSshClient

Review Comment:
   Why is this a `def` now? This could have a performance impact because it would get evaluated each time



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org