[jira] [Commented] (DERBY-6638) Remove unnecessary use of reflection in SignatureChecker

["Knut Anders Hatlen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-6638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14044504#comment-14044504 ] 

Knut Anders Hatlen commented on DERBY-6638:
-------------------------------------------

Removing the reflection looks like a good improvement. +1

I'm not so sure if I see the value in adding empty javadoc tags, such as

{noformat}
+     * @param conn
+     * @throws java.sql.SQLException
{noformat}

I think those tags only provide value if they contain a description of the parameter or exception.

There are two additions of @SuppressWarnings("StringConcatenationInsideStringBufferAppend"). It's probably just as easy, and a little cleaner, to silence the warnings by replacing the concatenation with calls to append().

> Remove unnecessary use of reflection in SignatureChecker
> --------------------------------------------------------
>
>                 Key: DERBY-6638
>                 URL: https://issues.apache.org/jira/browse/DERBY-6638
>             Project: Derby
>          Issue Type: Improvement
>          Components: Tools
>            Reporter: Dag H. Wanvik
>         Attachments: derby-6638.diff, derby-6638.status
>
>
> Ca line 377 in SignatureChecker we use reflection to call DatabaseMetaData#getFunctionColumns. This is no longer necessary after we removed support for JDR 169.
> {color:blue}
> [Update:] There are more occurrences of reflection that can be removed in this class.
> {color}



--
This message was sent by Atlassian JIRA
(v6.2#6252)