You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/01/26 05:44:25 UTC

[jira] [Commented] (CB-12399) FileTransfer only uses WebView cookies if available

    [ https://issues.apache.org/jira/browse/CB-12399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15839281#comment-15839281 ] 

ASF GitHub Bot commented on CB-12399:
-------------------------------------

GitHub user Lemon-King opened a pull request:

    https://github.com/apache/cordova-plugin-file-transfer/pull/174

    CB-12399: (Android) Fix bug with WebView & CookieManager cookies

    ### Platforms affected
    Android
    
    ### What does this PR do?
    Resolves the issue where only WebView cookies would be used, affecting hybrid applications which use CookieManager cookies.
    
    ### What testing has been done on this change?
    Tested on Motorola, Nexus 6, and Pixel devices.
    Also tested on various emulators api ranges (19 - 24).
    
    ### Checklist
    - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
    - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
    - [ ] Added automated test coverage as appropriate for this change.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Lemon-King/cordova-plugin-file-transfer fotofuzePatch

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-file-transfer/pull/174.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #174
    
----
commit ab268e0605c55c47b3931029bc37b6a2eae6249e
Author: Lemon King <le...@gmail.com>
Date:   2017-01-26T05:10:39Z

    Allow both cookiemanager and webview cookies to be used for hybrid applications.

----


> FileTransfer only uses WebView cookies if available
> ---------------------------------------------------
>
>                 Key: CB-12399
>                 URL: https://issues.apache.org/jira/browse/CB-12399
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugin File Transfer
>    Affects Versions: Master
>         Environment: Android
>            Reporter: James Harless
>            Priority: Minor
>
> Came across this bug a few weeks ago where FileTransfer will use WebView cookies over CookieManager cookies. This can be a major source of confusion if WebView receives a cookie with a hybrid app where cookies are handled by CookieManager.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org