You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by GitBox <gi...@apache.org> on 2020/10/02 13:28:54 UTC
[GitHub] [parquet-format] tanuja5 opened a new pull request #161: Fix in Timestamp parameters
tanuja5 opened a new pull request #161:
URL: https://github.com/apache/parquet-format/pull/161
As i read, the parameters indicate precision but the table has unit parameter for timestamp type.
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Parquet Jira](https://issues.apache.org/jira/browse/PARQUET/) issues and references them in the PR title. For example, "PARQUET-1234: My Parquet PR"
- https://issues.apache.org/jira/browse/PARQUET-XXX
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-format] tanuja5 commented on pull request #161: Fix in Timestamp parameters
Posted by GitBox <gi...@apache.org>.
tanuja5 commented on pull request #161:
URL: https://github.com/apache/parquet-format/pull/161#issuecomment-810146559
I have created a tracking - https://issues.apache.org/jira/browse/PARQUET-2011
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-format] pitrou commented on pull request #161: Fix in Timestamp parameters
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #161:
URL: https://github.com/apache/parquet-format/pull/161#issuecomment-810111021
@nandorKollar Can you explain what this fix is for? The field in `TimestampType` is named `unit`, not `precision`: https://github.com/apache/parquet-format/blob/master/src/main/thrift/parquet.thrift#L272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-format] pitrou commented on pull request #161: Fix in Timestamp parameters
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #161:
URL: https://github.com/apache/parquet-format/pull/161#issuecomment-810131495
Ah, you're right. Do you want to push a fix for it then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-format] tanuja5 commented on pull request #161: Fix in Timestamp parameters
Posted by GitBox <gi...@apache.org>.
tanuja5 commented on pull request #161:
URL: https://github.com/apache/parquet-format/pull/161#issuecomment-810129536
I suppose this doc is yet to be updated - https://github.com/apache/parquet-format/blob/master/LogicalTypes.md
Under timestamp it reads "precision" instead of "unit" ( TIMESTAMP(isAdjustedToUTC=true, precision=MILLIS))
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-format] pitrou merged pull request #161: PARQUET-2011: Use "unit" for timestamp parameter, not "precision"
Posted by GitBox <gi...@apache.org>.
pitrou merged pull request #161:
URL: https://github.com/apache/parquet-format/pull/161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-format] pitrou commented on pull request #161: Fix in Timestamp parameters
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #161:
URL: https://github.com/apache/parquet-format/pull/161#issuecomment-810131839
Also, would you like to open a ticket on JIRA? https://issues.apache.org/jira/projects/PARQUET/issues/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [parquet-format] pitrou edited a comment on pull request #161: Fix in Timestamp parameters
Posted by GitBox <gi...@apache.org>.
pitrou edited a comment on pull request #161:
URL: https://github.com/apache/parquet-format/pull/161#issuecomment-810111021
@tanuja5 Can you explain what this fix is for? The field in `TimestampType` is named `unit`, not `precision`: https://github.com/apache/parquet-format/blob/master/src/main/thrift/parquet.thrift#L272
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org