You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "NihalJain (via GitHub)" <gi...@apache.org> on 2023/12/22 08:50:48 UTC
[PR] OMID-254 Upgrade to phoenix-thirdparty 2.1.0 [phoenix-omid]
NihalJain opened a new pull request, #151:
URL: https://github.com/apache/phoenix-omid/pull/151
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OMID-254 Upgrade to phoenix-thirdparty 2.1.0 [phoenix-omid]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #151:
URL: https://github.com/apache/phoenix-omid/pull/151#issuecomment-1873692027
No need, if you have tested with thirdparty-2.1 in both Omid and Phoenix at the same time, that's fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OMID-254 Upgrade to phoenix-thirdparty 2.1.0 [phoenix-omid]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #151:
URL: https://github.com/apache/phoenix-omid/pull/151#issuecomment-1867416988
Built code locally and ran tests.:
```
mvn clean install -Dhbase.version=2.5.6-hadoop3 -DskipTests
mvn verify -Dsurefire.rerunFailingTestsCount=5 -Dhbase.version=2.5.6-hadoop3
```
FYI @chrajeshbabu , @stoty , @gjacoby126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OMID-254 Upgrade to phoenix-thirdparty 2.1.0 [phoenix-omid]
Posted by "chrajeshbabu (via GitHub)" <gi...@apache.org>.
chrajeshbabu commented on PR #151:
URL: https://github.com/apache/phoenix-omid/pull/151#issuecomment-1867419622
+lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OMID-254 Upgrade to phoenix-thirdparty 2.1.0 [phoenix-omid]
Posted by "stoty (via GitHub)" <gi...@apache.org>.
stoty commented on PR #151:
URL: https://github.com/apache/phoenix-omid/pull/151#issuecomment-1873673603
Have you run the full Phoenix test suite with both Phoenix and Omid built with the new thirdparty, @NihalJain ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OMID-254 Upgrade to phoenix-thirdparty 2.1.0 [phoenix-omid]
Posted by "chrajeshbabu (via GitHub)" <gi...@apache.org>.
chrajeshbabu merged PR #151:
URL: https://github.com/apache/phoenix-omid/pull/151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OMID-254 Upgrade to phoenix-thirdparty 2.1.0 [phoenix-omid]
Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #151:
URL: https://github.com/apache/phoenix-omid/pull/151#issuecomment-1873681962
> Have you run the full Phoenix test suite with both Phoenix and Omid built with the new thirdparty,@NihalJain ?
Hi @stoty I have ran following for omid.
> Built code locally and ran tests.:
>
> ```
> mvn clean install -Dhbase.version=2.5.6-hadoop3 -DskipTests
> mvn verify -Dsurefire.rerunFailingTestsCount=5 -Dhbase.version=2.5.6-hadoop3
> ```
Also had run tests for phoenix with https://github.com/apache/phoenix-thirdparty/pull/8#issuecomment-1832165125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org