You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/06/04 20:40:19 UTC

[GitHub] [tvm] junrushao1994 opened a new pull request, #11575: [TIR] Schedule Primitive: Add-Unit-Loop

junrushao1994 opened a new pull request, #11575:
URL: https://github.com/apache/tvm/pull/11575

   In TE, a unit loop could be introduced by fusing an empty list of loops on a stage. This PR adds its counterpart in TIR, while being a bit more explicit with a new schedule primitive which adds a unit loop without impacting any existing functionalities.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] vinx13 commented on a diff in pull request #11575: [TIR] Schedule Primitive: Add-Unit-Loop

Posted by GitBox <gi...@apache.org>.
vinx13 commented on code in PR #11575:
URL: https://github.com/apache/tvm/pull/11575#discussion_r889622523


##########
src/tir/schedule/primitive.h:
##########
@@ -186,6 +186,16 @@ TVM_DLL StmtSRef Fuse(ScheduleState self, const Array<StmtSRef>& loop_srefs);
  */
 TVM_DLL void Reorder(ScheduleState self, const Array<StmtSRef>& ordered_loop_srefs);
 
+/*!
+ * \brief Create a new thread_binding loop on top of the `loop_rv`
+ * \param sref The block/loop above which the new thread_binding loop is created
+ * \param extent The extent of the new thread_binding loop
+ * \param thread_axis The thread axis of the new thread_binding loop
+ * \param attrs Extra loop attributes

Review Comment:
   update doc



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] junrushao1994 commented on a diff in pull request #11575: [TIR] Schedule Primitive: Add-Unit-Loop

Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on code in PR #11575:
URL: https://github.com/apache/tvm/pull/11575#discussion_r889624507


##########
src/tir/schedule/primitive.h:
##########
@@ -186,6 +186,16 @@ TVM_DLL StmtSRef Fuse(ScheduleState self, const Array<StmtSRef>& loop_srefs);
  */
 TVM_DLL void Reorder(ScheduleState self, const Array<StmtSRef>& ordered_loop_srefs);
 
+/*!
+ * \brief Create a new thread_binding loop on top of the `loop_rv`
+ * \param sref The block/loop above which the new thread_binding loop is created
+ * \param extent The extent of the new thread_binding loop
+ * \param thread_axis The thread axis of the new thread_binding loop
+ * \param attrs Extra loop attributes

Review Comment:
   oh ooops



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [tvm] junrushao1994 merged pull request #11575: [TIR] Schedule Primitive: Add-Unit-Loop

Posted by GitBox <gi...@apache.org>.
junrushao1994 merged PR #11575:
URL: https://github.com/apache/tvm/pull/11575


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org