You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/12/18 16:04:15 UTC
[GitHub] [nuttx] halyssonJr opened a new pull request, #7917: board/xtensa/esp32s2 Add New Board
halyssonJr opened a new pull request, #7917:
URL: https://github.com/apache/nuttx/pull/7917
## Summary
Add new board ESP32S2 Franzininho WiFi
## Impact
New feature
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] gustavonihei commented on a diff in pull request #7917: board/xtensa/esp32s2: Add Franzinho Board
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on code in PR #7917:
URL: https://github.com/apache/nuttx/pull/7917#discussion_r1053276355
##########
boards/Kconfig:
##########
@@ -2708,6 +2717,7 @@ config ARCH_BOARD
default "esp32c3-devkit-rust-1" if ARCH_BOARD_ESP32C3_DEVKIT_RUST1
default "esp32s2-kaluga-1" if ARCH_BOARD_ESP32S2_KALUGA_1
default "esp32s2-saola-1" if ARCH_BOARD_ESP32S2_SAOLA_1
+ default "esp32s2-franzininho" if ARCH_BOARD_ESP32S2_FRANZININHO
Review Comment:
```suggestion
default "franzininho-wifi" if ARCH_BOARD_ESP32S2_FRANZININHO
```
Rename board name for consistency.
##########
boards/Kconfig:
##########
@@ -2708,6 +2717,7 @@ config ARCH_BOARD
default "esp32c3-devkit-rust-1" if ARCH_BOARD_ESP32C3_DEVKIT_RUST1
default "esp32s2-kaluga-1" if ARCH_BOARD_ESP32S2_KALUGA_1
default "esp32s2-saola-1" if ARCH_BOARD_ESP32S2_SAOLA_1
+ default "esp32s2-franzininho" if ARCH_BOARD_ESP32S2_FRANZININHO
Review Comment:
```suggestion
default "franzininho-wifi" if ARCH_BOARD_FRANZININHO_WIFI
```
Rename board name for consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] gustavonihei commented on a diff in pull request #7917: board/xtensa/esp32s2: Add Franzinho Board
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on code in PR #7917:
URL: https://github.com/apache/nuttx/pull/7917#discussion_r1053273992
##########
boards/Kconfig:
##########
@@ -370,7 +370,16 @@ config ARCH_BOARD_ESP32S2_SAOLA_1
select ARCH_HAVE_IRQBUTTONS if ESP32S2_GPIO_IRQ
---help---
This is the ESP32-S2-Saola-1 board
-
+
+config ARCH_BOARD_ESP32S2_FRANZININHO
+ bool "FRANZININHO WI-FI"
+ depends on ARCH_CHIP_ESP32S2WROVER
+ select ARCH_HAVE_LEDS
+ select ARCH_HAVE_BUTTONS
+ select ARCH_HAVE_IRQBUTTONS if ESP32S2_GPIO_IRQ
+ ---help---
+ This is the ESP32-S2-FRANZININHO board
Review Comment:
```suggestion
Franzininho Wi-Fi is a development board to evaluate the ESP32-S2 SoC.
https://docs.franzininho.com.br/docs/franzininho-wifi/franzininho-wifi/
```
Suggestion for a more detailed description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] gustavonihei commented on a diff in pull request #7917: board/xtensa/esp32s2: Add Franzinho Board
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on code in PR #7917:
URL: https://github.com/apache/nuttx/pull/7917#discussion_r1051740166
##########
boards/Kconfig:
##########
@@ -370,7 +370,16 @@ config ARCH_BOARD_ESP32S2_SAOLA_1
select ARCH_HAVE_IRQBUTTONS if ESP32S2_GPIO_IRQ
---help---
This is the ESP32-S2-Saola-1 board
-
+
+config ARCH_BOARD_ESP32S2_FRANZININHO
+ bool "Espressif ESP32-S2-FRANZININHO"
Review Comment:
```suggestion
bool “Franzininho Wi-Fi"
```
The correct name for this board is Franzininho Wi-Fi.
Furthermore, this board is not an official design from Espressif, so “Espressif” should not appear in the board name.
https://docs.franzininho.com.br/docs/franzininho-wifi/franzininho-wifi/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] halyssoncarvalho commented on a diff in pull request #7917: board/xtensa/esp32s2: Add Franzinho Board
Posted by GitBox <gi...@apache.org>.
halyssoncarvalho commented on code in PR #7917:
URL: https://github.com/apache/nuttx/pull/7917#discussion_r1053531122
##########
boards/xtensa/esp32s2/esp32s2-franzininho/src/esp32s2-franzininho.h:
##########
@@ -0,0 +1,200 @@
+/****************************************************************************
+ * boards/xtensa/esp32s2/esp32s2-franzininho/src/esp32s2-franzininho.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+#ifndef __BOARDS_XTENSA_ESP32S2_ESP32S2_FRANZININHO_SRC_ESP32S2_FRANZININHO_H
+#define __BOARDS_XTENSA_ESP32S2_ESP32S2_FRANZININHO_SRC_ESP32S2_FRANZININHO_H
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+#include <nuttx/compiler.h>
+#include <stdint.h>
+
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+/* ESP32S2-Franzininho GPIOs ************************************************/
+
+/* BOOT Button */
+
+#define BUTTON_BOOT 0
+
+/* TIMERS */
+
+#define TIMER0 0
+#define TIMER1 1
+#define TIMER2 2
+#define TIMER3 3
+
+/* ONESHOT */
+
+#define ONESHOT_TIMER TIMER0
+#define ONESHOT_RESOLUTION_US 1
+
+/****************************************************************************
+ * Public Types
+ ****************************************************************************/
+
+/****************************************************************************
+ * Public Data
+ ****************************************************************************/
+
+#ifndef __ASSEMBLY__
+
+/****************************************************************************
+ * Public Function Prototypes
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: esp32s2_bringup
+ *
+ * Description:
+ * Perform architecture-specific initialization
+ *
+ * CONFIG_BOARD_LATE_INITIALIZE=y :
+ * Called from board_late_initialize().
+ *
+ * CONFIG_BOARD_LATE_INITIALIZE=y && CONFIG_BOARDCTL=y :
+ * Called from the NSH library via board_app_initialize()
+ *
+ ****************************************************************************/
+
+int esp32s2_bringup(void);
+
+/****************************************************************************
+ * Name: esp32s2_gpio_init
+ *
+ * Description:
+ * Configure the GPIO driver.
+ *
+ * Returned Value:
+ * Zero (OK) is returned on success; A negated errno value is returned
+ * to indicate the nature of any failure.
+ *
+ ****************************************************************************/
+
+#ifdef CONFIG_DEV_GPIO
+int esp32s2_gpio_init(void);
+#endif
+
+/****************************************************************************
+ * Name: board_oneshot_init
+ *
+ * Description:
+ * Configure the oneshot timer driver.
+ *
+ * Input Parameters:
+ * timer - Timer instance to be used as oneshot timer.
+ * resolution - Oneshot timer resolution.
+ *
+ * Returned Value:
+ * Zero (OK) is returned on success; A negated errno value is returned
+ * to indicate the nature of any failure.
+ *
+ ****************************************************************************/
+
+#ifdef CONFIG_ONESHOT
+int board_oneshot_init(int timer, uint16_t resolution);
+#endif
+
+/****************************************************************************
+ * Name: board_i2c_init
+ *
+ * Description:
+ * Configure the I2C driver.
+ *
+ * Returned Value:
+ * Zero (OK) is returned on success; A negated errno value is returned
+ * to indicate the nature of any failure.
+ *
+ ****************************************************************************/
+
+#ifdef CONFIG_I2C_DRIVER
+int board_i2c_init(void);
+#endif
+
+/****************************************************************************
+ * Name: board_bmp180_initialize
+ *
+ * Description:
+ * Initialize and register the BMP180 Pressure Sensor driver.
+ *
+ * Input Parameters:
+ * devno - The device number, used to build the device path as /dev/pressN
+ * busno - The I2C bus number
+ *
+ * Returned Value:
+ * Zero (OK) on success; a negated errno value on failure.
+ *
+ ****************************************************************************/
+
+#ifdef CONFIG_SENSORS_BMP180
+int board_bmp180_initialize(int devno, int busno);
+#endif
Review Comment:
Nop, i will remove. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] lucasssvaz commented on a diff in pull request #7917: board/xtensa/esp32s2: Add Franzinho Board
Posted by GitBox <gi...@apache.org>.
lucasssvaz commented on code in PR #7917:
URL: https://github.com/apache/nuttx/pull/7917#discussion_r1053342777
##########
boards/xtensa/esp32s2/esp32s2-franzininho/src/Make.defs:
##########
@@ -0,0 +1,55 @@
+############################################################################
+# boards/xtensa/esp32s2/esp32s2-franzininho/src/Make.defs
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership. The
+# ASF licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the
+# License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+############################################################################
+
+include $(TOPDIR)/Make.defs
+
+CSRCS = esp32s2_boot.c esp32s2_bringup.c
+
+ifeq ($(CONFIG_BOARDCTL),y)
+CSRCS += esp32s2_appinit.c
+ifeq ($(CONFIG_BOARDCTL_RESET),y)
+CSRCS += esp32s2_reset.c
+endif
+endif
+
+ifeq ($(CONFIG_DEV_GPIO),y)
+CSRCS += esp32s2_gpio.c
+endif
+
+ifeq ($(CONFIG_ONESHOT),y)
+CSRCS += esp32s2_oneshot.c
+endif
+
+ifeq ($(CONFIG_I2C_DRIVER),y)
+CSRCS += esp32s2_board_i2c.c
+endif
+
+ifeq ($(CONFIG_SENSORS_BMP180),y)
+CSRCS += esp32s2_bmp180.c
+endif
Review Comment:
```suggestion
```
Should be removed if BMP180 was not tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] gustavonihei commented on a diff in pull request #7917: board/xtensa/esp32s2: Add Franzinho Board
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on code in PR #7917:
URL: https://github.com/apache/nuttx/pull/7917#discussion_r1053271534
##########
boards/Kconfig:
##########
@@ -370,7 +370,16 @@ config ARCH_BOARD_ESP32S2_SAOLA_1
select ARCH_HAVE_IRQBUTTONS if ESP32S2_GPIO_IRQ
---help---
This is the ESP32-S2-Saola-1 board
-
+
+config ARCH_BOARD_ESP32S2_FRANZININHO
Review Comment:
```suggestion
config ARCH_BOARD_FRANZININHO_WIFI
```
Rename `config` for consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis merged pull request #7917: board/xtensa/esp32s2: Add Franzinho Board
Posted by GitBox <gi...@apache.org>.
acassis merged PR #7917:
URL: https://github.com/apache/nuttx/pull/7917
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] lucasssvaz commented on a diff in pull request #7917: board/xtensa/esp32s2: Add Franzinho Board
Posted by GitBox <gi...@apache.org>.
lucasssvaz commented on code in PR #7917:
URL: https://github.com/apache/nuttx/pull/7917#discussion_r1053342777
##########
boards/xtensa/esp32s2/esp32s2-franzininho/src/Make.defs:
##########
@@ -0,0 +1,55 @@
+############################################################################
+# boards/xtensa/esp32s2/esp32s2-franzininho/src/Make.defs
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership. The
+# ASF licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the
+# License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+############################################################################
+
+include $(TOPDIR)/Make.defs
+
+CSRCS = esp32s2_boot.c esp32s2_bringup.c
+
+ifeq ($(CONFIG_BOARDCTL),y)
+CSRCS += esp32s2_appinit.c
+ifeq ($(CONFIG_BOARDCTL_RESET),y)
+CSRCS += esp32s2_reset.c
+endif
+endif
+
+ifeq ($(CONFIG_DEV_GPIO),y)
+CSRCS += esp32s2_gpio.c
+endif
+
+ifeq ($(CONFIG_ONESHOT),y)
+CSRCS += esp32s2_oneshot.c
+endif
+
+ifeq ($(CONFIG_I2C_DRIVER),y)
+CSRCS += esp32s2_board_i2c.c
+endif
+
+ifeq ($(CONFIG_SENSORS_BMP180),y)
+CSRCS += esp32s2_bmp180.c
+endif
Review Comment:
Should be removed if BMP180 was not tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] gustavonihei commented on pull request #7917: board/xtensa/esp32s2: Add Franzinho Board
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on PR #7917:
URL: https://github.com/apache/nuttx/pull/7917#issuecomment-1357549003
@halyssonJr Could you please add some info about this board to the NuttX Documentation?
You may refer to a recent work on the support for ESP32 Lyra-T board:
https://github.com/apache/nuttx/commit/4ee22e87398efc1162772d1e8d66300766c35373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] gustavonihei commented on a diff in pull request #7917: board/xtensa/esp32s2: Add Franzinho Board
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on code in PR #7917:
URL: https://github.com/apache/nuttx/pull/7917#discussion_r1053277004
##########
boards/Kconfig:
##########
@@ -3672,6 +3682,9 @@ endif
if ARCH_BOARD_ESP32S2_SAOLA_1
source "boards/xtensa/esp32s2/esp32s2-saola-1/Kconfig"
endif
+if ARCH_BOARD_ESP32S2_FRANZININHO
+source "boards/xtensa/esp32s2/esp32s2-franzininho/Kconfig"
+endif
Review Comment:
```suggestion
if ARCH_BOARD_FRANZININHO_WIFI
source "boards/xtensa/esp32s2/franzininho-wifi/Kconfig"
endif
```
Rename board name and its directory for consistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] lucasssvaz commented on a diff in pull request #7917: board/xtensa/esp32s2: Add Franzinho Board
Posted by GitBox <gi...@apache.org>.
lucasssvaz commented on code in PR #7917:
URL: https://github.com/apache/nuttx/pull/7917#discussion_r1053339549
##########
boards/xtensa/esp32s2/esp32s2-franzininho/src/esp32s2_bmp180.c:
##########
@@ -0,0 +1,75 @@
+/****************************************************************************
+ * boards/xtensa/esp32s2/esp32s2-franzininho/src/esp32s2_bmp180.c
Review Comment:
This file should be deleted if the BMP180 was not tested.
##########
boards/xtensa/esp32s2/esp32s2-franzininho/src/esp32s2-franzininho.h:
##########
@@ -0,0 +1,200 @@
+/****************************************************************************
+ * boards/xtensa/esp32s2/esp32s2-franzininho/src/esp32s2-franzininho.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+#ifndef __BOARDS_XTENSA_ESP32S2_ESP32S2_FRANZININHO_SRC_ESP32S2_FRANZININHO_H
+#define __BOARDS_XTENSA_ESP32S2_ESP32S2_FRANZININHO_SRC_ESP32S2_FRANZININHO_H
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+#include <nuttx/compiler.h>
+#include <stdint.h>
+
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+/* ESP32S2-Franzininho GPIOs ************************************************/
+
+/* BOOT Button */
+
+#define BUTTON_BOOT 0
+
+/* TIMERS */
+
+#define TIMER0 0
+#define TIMER1 1
+#define TIMER2 2
+#define TIMER3 3
+
+/* ONESHOT */
+
+#define ONESHOT_TIMER TIMER0
+#define ONESHOT_RESOLUTION_US 1
+
+/****************************************************************************
+ * Public Types
+ ****************************************************************************/
+
+/****************************************************************************
+ * Public Data
+ ****************************************************************************/
+
+#ifndef __ASSEMBLY__
+
+/****************************************************************************
+ * Public Function Prototypes
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: esp32s2_bringup
+ *
+ * Description:
+ * Perform architecture-specific initialization
+ *
+ * CONFIG_BOARD_LATE_INITIALIZE=y :
+ * Called from board_late_initialize().
+ *
+ * CONFIG_BOARD_LATE_INITIALIZE=y && CONFIG_BOARDCTL=y :
+ * Called from the NSH library via board_app_initialize()
+ *
+ ****************************************************************************/
+
+int esp32s2_bringup(void);
+
+/****************************************************************************
+ * Name: esp32s2_gpio_init
+ *
+ * Description:
+ * Configure the GPIO driver.
+ *
+ * Returned Value:
+ * Zero (OK) is returned on success; A negated errno value is returned
+ * to indicate the nature of any failure.
+ *
+ ****************************************************************************/
+
+#ifdef CONFIG_DEV_GPIO
+int esp32s2_gpio_init(void);
+#endif
+
+/****************************************************************************
+ * Name: board_oneshot_init
+ *
+ * Description:
+ * Configure the oneshot timer driver.
+ *
+ * Input Parameters:
+ * timer - Timer instance to be used as oneshot timer.
+ * resolution - Oneshot timer resolution.
+ *
+ * Returned Value:
+ * Zero (OK) is returned on success; A negated errno value is returned
+ * to indicate the nature of any failure.
+ *
+ ****************************************************************************/
+
+#ifdef CONFIG_ONESHOT
+int board_oneshot_init(int timer, uint16_t resolution);
+#endif
+
+/****************************************************************************
+ * Name: board_i2c_init
+ *
+ * Description:
+ * Configure the I2C driver.
+ *
+ * Returned Value:
+ * Zero (OK) is returned on success; A negated errno value is returned
+ * to indicate the nature of any failure.
+ *
+ ****************************************************************************/
+
+#ifdef CONFIG_I2C_DRIVER
+int board_i2c_init(void);
+#endif
+
+/****************************************************************************
+ * Name: board_bmp180_initialize
+ *
+ * Description:
+ * Initialize and register the BMP180 Pressure Sensor driver.
+ *
+ * Input Parameters:
+ * devno - The device number, used to build the device path as /dev/pressN
+ * busno - The I2C bus number
+ *
+ * Returned Value:
+ * Zero (OK) on success; a negated errno value on failure.
+ *
+ ****************************************************************************/
+
+#ifdef CONFIG_SENSORS_BMP180
+int board_bmp180_initialize(int devno, int busno);
+#endif
Review Comment:
```suggestion
```
This should be removed if it was not tested. Did you test the board with a BMP180 ?
##########
boards/xtensa/esp32s2/esp32s2-franzininho/src/esp32s2_bringup.c:
##########
@@ -0,0 +1,265 @@
+/****************************************************************************
+ * boards/xtensa/esp32s2/esp32s2-franzininho/src/esp32s2_bringup.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
+#include <stdio.h>
+#include <fcntl.h>
+#include <unistd.h>
+#include <syslog.h>
+#include <sys/stat.h>
+#include <sys/ioctl.h>
+#include <sys/types.h>
+#include <syslog.h>
+#include <debug.h>
+#include <stdio.h>
+
+#include <errno.h>
+#include <nuttx/fs/fs.h>
+
+#ifdef CONFIG_USERLED
+# include <nuttx/leds/userled.h>
+#endif
+
+#ifdef CONFIG_INPUT_BUTTONS
+# include <nuttx/input/buttons.h>
+#endif
+
+#ifdef CONFIG_TIMER
+# include "esp32s2_tim_lowerhalf.h"
+#endif
+
+#ifdef CONFIG_ESP32S2_I2C
+# include "esp32s2_i2c.h"
+#endif
+
+#ifdef CONFIG_ESP32S2_RT_TIMER
+# include "esp32s2_rt_timer.h"
+#endif
+
+#ifdef CONFIG_WATCHDOG
+# include "esp32s2_board_wdt.h"
+#endif
+
+#include "esp32s2-franzininho.h"
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: esp32s2_bringup
+ *
+ * Description:
+ * Perform architecture-specific initialization
+ *
+ * CONFIG_BOARD_LATE_INITIALIZE=y :
+ * Called from board_late_initialize().
+ *
+ * CONFIG_BOARD_LATE_INITIALIZE=n && CONFIG_BOARDCTL=y :
+ * Called from the NSH library
+ *
+ ****************************************************************************/
+
+int esp32s2_bringup(void)
+{
+ int ret = OK;
+
+#ifdef CONFIG_FS_PROCFS
+ /* Mount the procfs file system */
+
+ ret = nx_mount(NULL, "/proc", "procfs", 0, NULL);
+ if (ret < 0)
+ {
+ syslog(LOG_ERR, "ERROR: Failed to mount procfs at /proc: %d\n", ret);
+ }
+#endif
+
+#ifdef CONFIG_FS_TMPFS
+ /* Mount the tmpfs file system */
+
+ ret = nx_mount(NULL, CONFIG_LIBC_TMPDIR, "tmpfs", 0, NULL);
+ if (ret < 0)
+ {
+ syslog(LOG_ERR, "ERROR: Failed to mount tmpfs at %s: %d\n",
+ CONFIG_LIBC_TMPDIR, ret);
+ }
+#endif
+
+#ifdef CONFIG_WATCHDOG
+ /* Configure watchdog timer */
+
+ ret = board_wdt_init();
+ if (ret < 0)
+ {
+ syslog(LOG_ERR, "Failed to initialize watchdog timer: %d\n", ret);
+ }
+#endif
+
+#ifdef CONFIG_DEV_GPIO
+ ret = esp32s2_gpio_init();
+ if (ret < 0)
+ {
+ syslog(LOG_ERR, "Failed to initialize GPIO Driver: %d\n", ret);
+ return ret;
+ }
+#endif
+
+ /* Register the timer drivers */
+
+#ifdef CONFIG_TIMER
+
+#if defined(CONFIG_ESP32S2_TIMER0) && !defined(CONFIG_ONESHOT)
+ ret = esp32s2_timer_initialize("/dev/timer0", TIMER0);
+ if (ret < 0)
+ {
+ syslog(LOG_ERR,
+ "ERROR: Failed to initialize timer driver: %d\n",
+ ret);
+ return ret;
+ }
+#endif
+
+#ifdef CONFIG_ESP32S2_TIMER1
+ ret = esp32s2_timer_initialize("/dev/timer1", TIMER1);
+ if (ret < 0)
+ {
+ syslog(LOG_ERR,
+ "ERROR: Failed to initialize timer driver: %d\n",
+ ret);
+ return ret;
+ }
+#endif
+
+#ifdef CONFIG_ESP32S2_TIMER2
+ ret = esp32s2_timer_initialize("/dev/timer2", TIMER2);
+ if (ret < 0)
+ {
+ syslog(LOG_ERR,
+ "ERROR: Failed to initialize timer driver: %d\n",
+ ret);
+ return ret;
+ }
+#endif
+
+#ifdef CONFIG_ESP32S2_TIMER3
+ ret = esp32s2_timer_initialize("/dev/timer3", TIMER3);
+ if (ret < 0)
+ {
+ syslog(LOG_ERR,
+ "ERROR: Failed to initialize timer driver: %d\n",
+ ret);
+ return ret;
+ }
+#endif
+
+#endif /* CONFIG_TIMER */
+
+#ifdef CONFIG_ESP32S2_RT_TIMER
+ ret = esp32s2_rt_timer_init();
+ if (ret < 0)
+ {
+ syslog(LOG_ERR, "Failed to initialize RT timer: %d\n", ret);
+ }
+
+#endif
+ /* Now register one oneshot driver */
+
+#if defined(CONFIG_ONESHOT) && defined(CONFIG_ESP32S2_TIMER0)
+
+ ret = board_oneshot_init(ONESHOT_TIMER, ONESHOT_RESOLUTION_US);
+ if (ret < 0)
+ {
+ syslog(LOG_ERR, "ERROR: board_oneshot_init() failed: %d\n", ret);
+ }
+
+#endif /* CONFIG_ONESHOT */
+
+#ifdef CONFIG_I2C_DRIVER
+ /* Configure I2C peripheral interfaces */
+
+ ret = board_i2c_init();
+ if (ret < 0)
+ {
+ syslog(LOG_ERR, "Failed to initialize I2C driver: %d\n", ret);
+ }
+#endif
+
+#ifdef CONFIG_SENSORS_BMP180
+ /* Try to register BMP180 device in I2C0 */
+
+ ret = board_bmp180_initialize(0, ESP32S2_I2C0);
+ if (ret < 0)
+ {
+ syslog(LOG_ERR,
+ "Failed to initialize BMP180 driver for I2C0: %d\n", ret);
+ }
+#endif
Review Comment:
```suggestion
```
Should be removed if BMP280 was not tested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] gustavonihei commented on a diff in pull request #7917: board/xtensa/esp32s2: Add Franzinho Board
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on code in PR #7917:
URL: https://github.com/apache/nuttx/pull/7917#discussion_r1051740166
##########
boards/Kconfig:
##########
@@ -370,7 +370,16 @@ config ARCH_BOARD_ESP32S2_SAOLA_1
select ARCH_HAVE_IRQBUTTONS if ESP32S2_GPIO_IRQ
---help---
This is the ESP32-S2-Saola-1 board
-
+
+config ARCH_BOARD_ESP32S2_FRANZININHO
+ bool "Espressif ESP32-S2-FRANZININHO"
Review Comment:
```suggestion
bool “Franzininho Wi-Fi"
```
The correct name for this board is Franzininho Wi-Fi.
Furthermore, this board is not an official design from Espressif, so “Espressif” should not appear in the board name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] gustavonihei commented on pull request #7917: board/xtensa/esp32s2: Add Franzinho Board
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on PR #7917:
URL: https://github.com/apache/nuttx/pull/7917#issuecomment-1356997839
Thanks for the contribution, @halyssonJr!
Tomorrow I’ll do a full review of the PR, for now I just made one change request that caught my attention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] gustavonihei commented on a diff in pull request #7917: board/xtensa/esp32s2: Add Franzinho Board
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on code in PR #7917:
URL: https://github.com/apache/nuttx/pull/7917#discussion_r1052131057
##########
boards/xtensa/esp32s2/esp32s2-franzininho/src/esp32s2_bringup.c:
##########
@@ -0,0 +1,277 @@
+/****************************************************************************
+ * boards/xtensa/esp32s2/esp32s2-franzininho/src/esp32s2_bringup.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
+#include <stdio.h>
+#include <fcntl.h>
+#include <unistd.h>
+#include <syslog.h>
+#include <sys/stat.h>
+#include <sys/ioctl.h>
+#include <sys/types.h>
+#include <syslog.h>
+#include <debug.h>
+#include <stdio.h>
+
+#include <errno.h>
+#include <nuttx/fs/fs.h>
+
+#ifdef CONFIG_USERLED
+# include <nuttx/leds/userled.h>
+#endif
+
+#ifdef CONFIG_INPUT_BUTTONS
+# include <nuttx/input/buttons.h>
+#endif
+
+#ifdef CONFIG_TIMER
+# include "esp32s2_tim_lowerhalf.h"
+#endif
+
+#ifdef CONFIG_ESP32S2_I2C
+# include "esp32s2_i2c.h"
+#endif
+
+#ifdef CONFIG_ESP32S2_RT_TIMER
+# include "esp32s2_rt_timer.h"
+#endif
+
+#ifdef CONFIG_WATCHDOG
+# include "esp32s2_board_wdt.h"
+#endif
+
+#ifdef CONFIG_SENSORS_MAX6675
+# include "esp32s2_max6675.h"
+#endif
Review Comment:
```suggestion
```
This file does not exist on the repository nor it is being added to the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] gustavonihei commented on a diff in pull request #7917: board/xtensa/esp32s2: Add Franzinho Board
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on code in PR #7917:
URL: https://github.com/apache/nuttx/pull/7917#discussion_r1052128345
##########
boards/xtensa/esp32s2/esp32s2-franzininho/scripts/Make.defs:
##########
@@ -0,0 +1,74 @@
+############################################################################
+# boards/xtensa/esp32s2/esp32s2-devkitc/scripts/Make.defs
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership. The
+# ASF licenses this file to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance with the
+# License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+# License for the specific language governing permissions and limitations
+# under the License.
+#
+############################################################################
+
+include $(TOPDIR)/.config
+include $(TOPDIR)/tools/Config.mk
+include $(TOPDIR)/tools/esp32s2/Config.mk
+include $(TOPDIR)/arch/xtensa/src/lx7/Toolchain.defs
+
+# Pick the linker scripts from the board level if they exist, if not
+# pick the common linker scripts.
+
+ARCHSCRIPT += $(BOARD_COMMON_DIR)$(DELIM)scripts$(DELIM)esp32s2_rom.ld
+ARCHSCRIPT += $(BOARD_COMMON_DIR)$(DELIM)scripts$(DELIM)esp32s2_peripherals.ld
+
+ifneq ($(wildcard $(BOARD_DIR)$(DELIM)scripts$(DELIM)esp32s2_memory.ld),)
+ ARCHSCRIPT += $(BOARD_DIR)$(DELIM)scripts$(DELIM)esp32s2_memory.ld
+else
+ ARCHSCRIPT += $(BOARD_COMMON_DIR)$(DELIM)scripts$(DELIM)esp32s2_memory.ld
+endif
+
+ifeq ($(CONFIG_ESP32S2_APP_FORMAT_MCUBOOT),y)
+ ifneq ($(wildcard $(BOARD_DIR)$(DELIM)scripts$(DELIM)esp32s2_mcuboot.ld),)
+ ARCHSCRIPT += $(BOARD_DIR)$(DELIM)scripts$(DELIM)esp32s2_mcuboot.ld
+ else
+ ARCHSCRIPT += $(BOARD_COMMON_DIR)$(DELIM)scripts$(DELIM)esp32s2_mcuboot.ld
+ endif
+else
+ ifneq ($(wildcard $(BOARD_DIR)$(DELIM)scripts$(DELIM)esp32s2_sections.ld),)
+ ARCHSCRIPT += $(BOARD_DIR)$(DELIM)scripts$(DELIM)esp32s2_sections.ld
+ else
+ ARCHSCRIPT += $(BOARD_COMMON_DIR)$(DELIM)scripts$(DELIM)esp32s2_sections.ld
+ endif
+endif
Review Comment:
This Makefile is referring to old versions of the linker scripts.
Please, double check the current version of the Makefiles from similar boards.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] gustavonihei commented on a diff in pull request #7917: board/xtensa/esp32s2: Add Franzinho Board
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on code in PR #7917:
URL: https://github.com/apache/nuttx/pull/7917#discussion_r1053279399
##########
boards/xtensa/esp32s2/esp32s2-franzininho/src/esp32s2-franzininho.h:
##########
@@ -0,0 +1,200 @@
+/****************************************************************************
+ * boards/xtensa/esp32s2/esp32s2-franzininho/src/esp32s2-franzininho.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+#ifndef __BOARDS_XTENSA_ESP32S2_ESP32S2_FRANZININHO_SRC_ESP32S2_FRANZININHO_H
+#define __BOARDS_XTENSA_ESP32S2_ESP32S2_FRANZININHO_SRC_ESP32S2_FRANZININHO_H
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+#include <nuttx/compiler.h>
+#include <stdint.h>
+
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+/* ESP32S2-Franzininho GPIOs ************************************************/
Review Comment:
```suggestion
/* Franzininho Wi-Fi GPIOs ************************************************/
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #7917: board/xtensa/esp32s2 Add New Board
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #7917:
URL: https://github.com/apache/nuttx/pull/7917#discussion_r1051626933
##########
boards/xtensa/esp32s2/esp32s2-franzininho/src/esp32s2_bringup.c:
##########
@@ -0,0 +1,278 @@
+/****************************************************************************
+ * boards/xtensa/esp32s2/esp32s2-saola-1/src/esp32s2_bringup.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
+#include <stdio.h>
+#include <fcntl.h>
+#include <unistd.h>
+#include <syslog.h>
+#include <sys/stat.h>
+#include <sys/ioctl.h>
+#include <sys/types.h>
+#include <syslog.h>
+#include <debug.h>
+#include <stdio.h>
+
+#include <errno.h>
+#include <nuttx/fs/fs.h>
+
+#ifdef CONFIG_USERLED
+# include <nuttx/leds/userled.h>
+#endif
+
+#ifdef CONFIG_INPUT_BUTTONS
+# include <nuttx/input/buttons.h>
+#endif
+
+#ifdef CONFIG_TIMER
+# include "esp32s2_tim_lowerhalf.h"
+#endif
+
+#ifdef CONFIG_ESP32S2_I2C
+# include "esp32s2_i2c.h"
+#endif
+
+#ifdef CONFIG_ESP32S2_RT_TIMER
+# include "esp32s2_rt_timer.h"
+#endif
+
+#ifdef CONFIG_WATCHDOG
+# include "esp32s2_board_wdt.h"
+#endif
+
+#ifdef CONFIG_SENSORS_MAX6675
+# include "esp32s2_max6675.h"
+#endif
+
+#include "esp32s2-franzininho.h"
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: esp32s2_bringup
+ *
+ * Description:
+ * Perform architecture-specific initialization
+ *
+ * CONFIG_BOARD_LATE_INITIALIZE=y :
+ * Called from board_late_initialize().
+ *
+ * CONFIG_BOARD_LATE_INITIALIZE=n && CONFIG_BOARDCTL=y :
+ * Called from the NSH library
+ *
+ ****************************************************************************/
+
+int esp32s2_bringup(void)
+{
+ int ret;
+
+#ifdef CONFIG_FS_PROCFS
+ /* Mount the procfs file system */
+
+ ret = nx_mount(NULL, "/proc", "procfs", 0, NULL);
+ if (ret < 0)
+ {
+ syslog(LOG_ERR, "ERROR: Failed to mount procfs at /proc: %d\n", ret);
+ }
+#endif
+
+#ifdef CONFIG_FS_TMPFS
+ /* Mount the tmpfs file system */
+
+ ret = nx_mount(NULL, CONFIG_LIBC_TMPDIR, "tmpfs", 0, NULL);
+ if (ret < 0)
+ {
+ syslog(LOG_ERR, "ERROR: Failed to mount tmpfs at %s: %d\n",
+ CONFIG_LIBC_TMPDIR, ret);
+ }
+#endif
+
+#ifdef CONFIG_WATCHDOG
+ /* Configure watchdog timer */
+
+ ret = board_wdt_init();
+ if (ret < 0)
+ {
+ syslog(LOG_ERR, "Failed to initialize watchdog timer: %d\n", ret);
+ }
+#endif
+
+#ifdef CONFIG_DEV_GPIO
+ ret = esp32s2_gpio_init();
+ if (ret < 0)
+ {
+ syslog(LOG_ERR, "Failed to initialize GPIO Driver: %d\n", ret);
+ return ret;
+ }
+#endif
+
+ /* Register the timer drivers */
+
+#ifdef CONFIG_TIMER
+
+#if defined(CONFIG_ESP32S2_TIMER0) && !defined(CONFIG_ONESHOT)
+ ret = esp32s2_timer_initialize("/dev/timer0", TIMER0);
+ if (ret < 0)
+ {
+ syslog(LOG_ERR,
+ "ERROR: Failed to initialize timer driver: %d\n",
+ ret);
+ return ret;
+ }
+#endif
+
+#ifdef CONFIG_ESP32S2_TIMER1
+ ret = esp32s2_timer_initialize("/dev/timer1", TIMER1);
+ if (ret < 0)
+ {
+ syslog(LOG_ERR,
+ "ERROR: Failed to initialize timer driver: %d\n",
+ ret);
+ return ret;
+ }
+#endif
+
+#ifdef CONFIG_ESP32S2_TIMER2
+ ret = esp32s2_timer_initialize("/dev/timer2", TIMER2);
+ if (ret < 0)
+ {
+ syslog(LOG_ERR,
+ "ERROR: Failed to initialize timer driver: %d\n",
+ ret);
+ return ret;
+ }
+#endif
+
+#ifdef CONFIG_ESP32S2_TIMER3
+ ret = esp32s2_timer_initialize("/dev/timer3", TIMER3);
+ if (ret < 0)
+ {
+ syslog(LOG_ERR,
+ "ERROR: Failed to initialize timer driver: %d\n",
+ ret);
+ return ret;
+ }
+#endif
+
+#endif /* CONFIG_TIMER */
+
+#ifdef CONFIG_ESP32S2_RT_TIMER
+ ret = esp32s2_rt_timer_init();
+ if (ret < 0)
+ {
+ syslog(LOG_ERR, "Failed to initialize RT timer: %d\n", ret);
+ }
+
+#endif
+ /* Now register one oneshot driver */
+
+#if defined(CONFIG_ONESHOT) && defined(CONFIG_ESP32S2_TIMER0)
+
+ ret = board_oneshot_init(ONESHOT_TIMER, ONESHOT_RESOLUTION_US);
+ if (ret < 0)
+ {
+ syslog(LOG_ERR, "ERROR: board_oneshot_init() failed: %d\n", ret);
+ }
+
+#endif /* CONFIG_ONESHOT */
+
+#ifdef CONFIG_I2C_DRIVER
+ /* Configure I2C peripheral interfaces */
+
+ ret = board_i2c_init();
+ if (ret < 0)
+ {
+ syslog(LOG_ERR, "Failed to initialize I2C driver: %d\n", ret);
+ }
+#endif
+
+#ifdef CONFIG_SENSORS_BMP180
+ /* Try to register BMP180 device in I2C0 */
+
+ ret = board_bmp180_initialize(0, ESP32S2_I2C0);
+ if (ret < 0)
+ {
+ syslog(LOG_ERR,
+ "Failed to initialize BMP180 driver for I2C0: %d\n", ret);
+ }
+#endif
+
+#ifdef CONFIG_SENSORS_MAX6675
+ ret = board_max6675_initialize(0, 2);
+ if (ret < 0)
+ {
+ syslog(LOG_ERR, "ERROR: MAX6675 initialization failed: %d\n", ret);
+ }
+#endif
+
+#ifdef CONFIG_ESP32S2_I2S
+
+#ifdef CONFIG_AUDIO_CS4344
+
+ /* Configure CS4344 audio on I2S0 */
+
+ ret = esp32s2_cs4344_initialize();
+ if (ret != OK)
+ {
+ syslog(LOG_ERR, "Failed to initialize CS4344 audio: %d\n", ret);
+ }
+#else
+
+ bool i2s_enable_tx;
+ bool i2s_enable_rx;
+
+#ifdef CONFIG_ESP32S2_I2S_TX
+ i2s_enable_tx = true;
+#else
+ i2s_enable_tx = false;
+#endif /* CONFIG_ESP32S2_I2S_TX */
+
+#ifdef CONFIG_ESP32S2_I2S_RX
+ i2s_enable_rx = true;
+#else
+ i2s_enable_rx = false;
+#endif /* CONFIG_ESP32S2_I2S_RX */
+
+ /* Configure I2S generic audio on I2S0 */
+
+ ret = board_i2sdev_initialize(i2s_enable_tx, i2s_enable_rx);
+ if (ret < 0)
+ {
+ syslog(LOG_ERR, "Failed to initialize I2S0 driver: %d\n", ret);
+ }
+#endif /* CONFIG_AUDIO_CS4344 */
+
+#endif /* CONFIG_ESP32S2_I2S */
+
+ /* If we got here then perhaps not all initialization was successful, but
+ * at least enough succeeded to bring-up NSH with perhaps reduced
+ * capabilities.
+ */
+
+ UNUSED(ret);
Review Comment:
can init `ret` to `OK` and `return ret;`, so this will allow to remove `UNUSED(ret);`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] gustavonihei commented on pull request #7917: board/xtensa/esp32s2: Add Franzinho Board
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on PR #7917:
URL: https://github.com/apache/nuttx/pull/7917#issuecomment-1357575709
**Testing** section of the PR description is too vague for the amount of features being added to this new board. CI build success is not enough for validation.
Please, describe the testing procedure used for the validation of the following peripherals:
* SPI
* I2C
* GPIO
* Timers
In case their operartion haven't been properly verified, I'd suggest to strip down the board support to the bare minimum for now (e.g. just the board initialization up to NSH).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] gustavonihei commented on a diff in pull request #7917: board/xtensa/esp32s2: Add Franzinho Board
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on code in PR #7917:
URL: https://github.com/apache/nuttx/pull/7917#discussion_r1052126507
##########
boards/xtensa/esp32s2/esp32s2-franzininho/scripts/Make.defs:
##########
@@ -0,0 +1,74 @@
+############################################################################
+# boards/xtensa/esp32s2/esp32s2-devkitc/scripts/Make.defs
Review Comment:
```suggestion
# boards/xtensa/esp32s2/franzininho-wifi/scripts/Make.defs
```
File path is wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] gustavonihei commented on a diff in pull request #7917: board/xtensa/esp32s2: Add Franzinho Board
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on code in PR #7917:
URL: https://github.com/apache/nuttx/pull/7917#discussion_r1052178184
##########
boards/xtensa/esp32s2/esp32s2-franzininho/src/esp32s2_boot.c:
##########
@@ -0,0 +1,83 @@
+/****************************************************************************
+ * boards/xtensa/esp32s2/esp32s2-franzininho/src/esp32s2_boot.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
+#include <debug.h>
+
+#include <nuttx/board.h>
+#include <nuttx/mm/mm.h>
+#include <arch/board/board.h>
+
+#include "esp32s2-franzininho.h"
+
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Private Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: esp32s2_board_initialize
+ *
+ * Description:
+ * All ESP32 architectures must provide the following entry point.
Review Comment:
```suggestion
* All ESP32-S2 boards must provide the following entry point.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] gustavonihei commented on a diff in pull request #7917: board/xtensa/esp32s2: Add Franzinho Board
Posted by GitBox <gi...@apache.org>.
gustavonihei commented on code in PR #7917:
URL: https://github.com/apache/nuttx/pull/7917#discussion_r1053320939
##########
boards/xtensa/esp32s2/esp32s2-franzininho/include/board.h:
##########
@@ -0,0 +1,58 @@
+/****************************************************************************
+ * boards/xtensa/esp32s2/esp32s2-franzininho/include/board.h
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+#ifndef __BOARDS_XTENSA_ESP32S2_ESP32S2_FRANZININHO_INCLUDE_BOARD_H
+#define __BOARDS_XTENSA_ESP32S2_ESP32S2_FRANZININHO_INCLUDE_BOARD_H
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+#include <nuttx/config.h>
+
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+/* Clocking *****************************************************************/
+
+/* The ESP32-S2-Franzininho is fitted with a 40MHz crystal */
Review Comment:
```suggestion
/* The Franzininho Wi-Fi is fitted with a 40MHz crystal */
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org