Re: Review Request 18257: [OOZIE-1703] User should be able to set bundle/coord end-time before start time

[Rohini Palaniswamy <ro...@gmail.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18257/#review39346
-----------------------------------------------------------



core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment71706>

    Please revert the changes in BundleJobChangeXCommand. It does not make sense to allow setting pausetime or endtime before start time. If the bundle is not started, it can be killed. Setting endtime to before start time of bundle is convoluted. We only want it for coordinators as same end time will be applied to all coordinators.
    
    BundleJobChangeXCommand allows changing end time but it is not part of the commandline or webservice documentation. Please update documentation for that. 
    
    



core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment71716>

    You need to check for lastActionTime which is not PREP, WAITING or READY. Else the processLookAheadActions code will never be executed.
    
    Need to add that check for checkPauseTime as well. Else processLookAheadActions will have a big bug where it goes and deletes even RUNNING actions without killing the hadoop jobs.



core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java
<https://reviews.apache.org/r/18257/#comment71715>

    This has a big bug where it goes and deletes even RUNNING actions without killing the hadoop jobs. Please do not delete running actions. Either we need to queue kill commands for them or throw an error in checkEndTime and checkPauseTime.



docs/src/site/twiki/DG_CommandLineTool.twiki
<https://reviews.apache.org/r/18257/#comment71704>

    Conditions and usage:



docs/src/site/twiki/DG_CommandLineTool.twiki
<https://reviews.apache.org/r/18257/#comment71705>

    if they are in WAITING state. 
    
    For actions already in RUNNING state we need to make a decision and either
       - Kill all actions that are RUNNING
       - Or throw an error if they are RUNNING actions after the endtime/pause time.


- Rohini Palaniswamy


On March 31, 2014, 5:31 p.m., Purshotam Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18257/
> -----------------------------------------------------------
> 
> (Updated March 31, 2014, 5:31 p.m.)
> 
> 
> Review request for oozie.
> 
> 
> Bugs: OOZIE-1703
>     https://issues.apache.org/jira/browse/OOZIE-1703
> 
> 
> Repository: oozie-git
> 
> 
> Description
> -------
> 
> This is one of the important use-case in case of versioning.
> 
> User can set end date of old coord/bundle before start date( if coord/bundle is supposed to run in future), so that it doesn't run and user can safely upload new version.
> 
> 
> We should also lookahead at created actions that become invalid because of the new end time.
> These actions should be deleted from DB.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/oozie/command/bundle/BundleJobChangeXCommand.java cd2c844 
>   core/src/main/java/org/apache/oozie/command/coord/CoordChangeXCommand.java 5ecd5d5 
>   core/src/test/java/org/apache/oozie/command/bundle/TestBundleChangeXCommand.java 6560db6 
>   core/src/test/java/org/apache/oozie/command/coord/TestCoordChangeXCommand.java fdc0a55 
>   docs/src/site/twiki/DG_CommandLineTool.twiki 351f0f2 
> 
> Diff: https://reviews.apache.org/r/18257/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Purshotam Shah
> 
>