You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/05 23:19:27 UTC
[GitHub] [arrow] BryanCutler opened a new pull request #8352: ARROW-10178: [CI] Remove patch to fix Spark master build
BryanCutler opened a new pull request #8352:
URL: https://github.com/apache/arrow/pull/8352
Spark master branch has been updated for Arrow 1.0.1, the patch to fix Java compilation can be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche closed pull request #8352: ARROW-10178: [CI] Remove patch to fix Spark master build
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche closed pull request #8352:
URL: https://github.com/apache/arrow/pull/8352
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #8352: ARROW-10178: [CI] Remove patch to fix Spark master build
Posted by GitBox <gi...@apache.org>.
emkornfield commented on pull request #8352:
URL: https://github.com/apache/arrow/pull/8352#issuecomment-704707705
> Spark needs to be patched again to handle structs with timestamps, adding the patch here and it can be removed after SPARK-32285 is complete. This is due to the changes in #7816
Was this patch necessary before? I thought we should be running Spark in a backwards compatibility mode that doesn't honor the TZ info. (maybe this got dropped from the patch?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] BryanCutler commented on pull request #8352: ARROW-10178: [CI] Remove patch to fix Spark master build
Posted by GitBox <gi...@apache.org>.
BryanCutler commented on pull request #8352:
URL: https://github.com/apache/arrow/pull/8352#issuecomment-704715450
Oh, I didn't see there was a backwards compatible setting. I ran the tests locally and obviously failed without it. Let me remove the patch and run again here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] BryanCutler commented on pull request #8352: ARROW-10178: [CI] Remove patch to fix Spark master build
Posted by GitBox <gi...@apache.org>.
BryanCutler commented on pull request #8352:
URL: https://github.com/apache/arrow/pull/8352#issuecomment-704715724
@ursabot crossbow submit test-conda-python-3.8-spark-master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #8352: ARROW-10178: [CI] Remove patch to fix Spark master build
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #8352:
URL: https://github.com/apache/arrow/pull/8352#issuecomment-703941186
[AMD64 Conda Crossbow Submit (#131023)](https://ci.ursalabs.org/#builders/98/builds/655) builder has been succeeded.
Revision: 7c62c5b6daec1d35f0f75bac56163323e8559596
Submitted crossbow builds: [ursa-labs/crossbow @ ursabot-582](https://github.com/ursa-labs/crossbow/branches/all?query=ursabot-582)
|Task|Status|
|----|------|
|test-conda-python-3.8-spark-master|[](https://github.com/ursa-labs/crossbow/actions?query=branch:ursabot-582-github-test-conda-python-3.8-spark-master)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] BryanCutler edited a comment on pull request #8352: ARROW-10178: [CI] Remove patch to fix Spark master build
Posted by GitBox <gi...@apache.org>.
BryanCutler edited a comment on pull request #8352:
URL: https://github.com/apache/arrow/pull/8352#issuecomment-704592685
Spark needs to be patched again to handle structs with timestamps, adding the patch here and it can be removed after SPARK-32285 is complete. This is the result from https://github.com/apache/arrow/pull/7816
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] BryanCutler edited a comment on pull request #8352: ARROW-10178: [CI] Remove patch to fix Spark master build
Posted by GitBox <gi...@apache.org>.
BryanCutler edited a comment on pull request #8352:
URL: https://github.com/apache/arrow/pull/8352#issuecomment-704592685
Spark needs to be patched again to handle structs with timestamps, adding the patch here and it can be removed after SPARK-32285 is complete. This is due to the changes in https://github.com/apache/arrow/pull/7816
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #8352: ARROW-10178: [CI] Remove patch to fix Spark master build
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #8352:
URL: https://github.com/apache/arrow/pull/8352#issuecomment-704593022
[AMD64 Conda Crossbow Submit (#131422)](https://ci.ursalabs.org/#builders/98/builds/656) builder has been succeeded.
Revision: ed31bb2fea84d753539752aae3e80ae800c69ab6
Submitted crossbow builds: [ursa-labs/crossbow @ ursabot-583](https://github.com/ursa-labs/crossbow/branches/all?query=ursabot-583)
|Task|Status|
|----|------|
|test-conda-python-3.8-spark-master|[](https://github.com/ursa-labs/crossbow/actions?query=branch:ursabot-583-github-test-conda-python-3.8-spark-master)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] BryanCutler commented on pull request #8352: ARROW-10178: [CI] Remove patch to fix Spark master build
Posted by GitBox <gi...@apache.org>.
BryanCutler commented on pull request #8352:
URL: https://github.com/apache/arrow/pull/8352#issuecomment-704701161
@kszucs the Spark integration tests are passing for master branch with this change, could you take a look? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #8352: ARROW-10178: [CI] Remove patch to fix Spark master build
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #8352:
URL: https://github.com/apache/arrow/pull/8352#issuecomment-704716424
[AMD64 Conda Crossbow Submit (#131560)](https://ci.ursalabs.org/#builders/98/builds/657) builder has been succeeded.
Revision: 6a064e5084029ac8407836a1bd56b3437599761a
Submitted crossbow builds: [ursa-labs/crossbow @ ursabot-584](https://github.com/ursa-labs/crossbow/branches/all?query=ursabot-584)
|Task|Status|
|----|------|
|test-conda-python-3.8-spark-master|[](https://github.com/ursa-labs/crossbow/actions?query=branch:ursabot-584-github-test-conda-python-3.8-spark-master)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] BryanCutler commented on pull request #8352: ARROW-10178: [CI] Remove patch to fix Spark master build
Posted by GitBox <gi...@apache.org>.
BryanCutler commented on pull request #8352:
URL: https://github.com/apache/arrow/pull/8352#issuecomment-703941527
I think we might have to add a patch to fix that nested timezone problem from earlier in #7804 , but lets see how the integration run goes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8352: ARROW-10178: [CI] Remove patch to fix Spark master build
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8352:
URL: https://github.com/apache/arrow/pull/8352#issuecomment-703940839
https://issues.apache.org/jira/browse/ARROW-10178
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] BryanCutler commented on pull request #8352: ARROW-10178: [CI] Remove patch to fix Spark master build
Posted by GitBox <gi...@apache.org>.
BryanCutler commented on pull request #8352:
URL: https://github.com/apache/arrow/pull/8352#issuecomment-704592763
@ursabot crossbow submit test-conda-python-3.8-spark-master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] BryanCutler commented on pull request #8352: ARROW-10178: [CI] Remove patch to fix Spark master build
Posted by GitBox <gi...@apache.org>.
BryanCutler commented on pull request #8352:
URL: https://github.com/apache/arrow/pull/8352#issuecomment-704592685
Spark needs to be patched again to handle structs with timestamps, adding the patch here and it can be removed after SPARK-32285 is complete.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] BryanCutler commented on pull request #8352: ARROW-10178: [CI] Remove patch to fix Spark master build
Posted by GitBox <gi...@apache.org>.
BryanCutler commented on pull request #8352:
URL: https://github.com/apache/arrow/pull/8352#issuecomment-703940620
@ursabot crossbow submit test-conda-python-3.8-spark-master
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #8352: ARROW-10178: [CI] Remove patch to fix Spark master build
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #8352:
URL: https://github.com/apache/arrow/pull/8352#issuecomment-704942701
Thanks Bryan!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org