[GitHub] mdeuser commented on a change in pull request #276: allow exclusion of api_host validation

[GitBox <gi...@apache.org>]

mdeuser commented on a change in pull request #276: allow exclusion of api_host validation
URL: https://github.com/apache/incubator-openwhisk-cli/pull/276#discussion_r182186977
 
 

 ##########
 File path: tests/src/test/scala/whisk/core/cli/test/WskCliBasicUsageTests.scala
 ##########
 @@ -555,7 +558,9 @@ class WskCliBasicUsageTests extends TestHelpers with WskTestHelpers {
     withActivation(wsk.activation, run) { activation =>
       activation.response.status shouldBe "success"
       val fields = activation.response.result.get.convertTo[Map[String, String]]
-      fields("api_host") shouldBe WhiskProperties.getApiHostForAction
+      if (!noApiHostCheck) {
 
 Review comment:
   @drcariel - nit.. double negative is a littler harder to read that `if (apiHostCheck) {`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services