You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2025/03/14 00:24:56 UTC
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22626
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
This patch implement building exec summary table for
ImpylaHS2Connection. It adds fetch_exec_summary argument in
ImpalaConnection.execute(). If this argument is True, an exec summary
table will be added into the returned result object.
fetch_exec_summary is also implemented for BeeswaxConnection. Thus,
BeeswaxConnection will not fetch exec summary be default all the time.
Tests that validate exec summary table is updated to set
fetch_exec_summary=True and migrated to test against hs2 protocol. Some
flake8 issues are addressed as well.
Testing:
- Run and pass affected tests locally.
Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
---
M tests/beeswax/impala_beeswax.py
M tests/common/impala_connection.py
M tests/custom_cluster/test_executor_groups.py
M tests/query_test/test_hash_join_timer.py
M tests/query_test/test_insert.py
M tests/query_test/test_observability.py
6 files changed, 169 insertions(+), 109 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/22626/1
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 6:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18655/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Mar 2025 19:09:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11636/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Mar 2025 03:27:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 4:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/22626/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/22626/3//COMMIT_MSG@15
PS3, Line 15: by
> Done
Done
http://gerrit.cloudera.org:8080/#/c/22626/3/shell/impala_client.py
File shell/impala_client.py:
http://gerrit.cloudera.org:8080/#/c/22626/3/shell/impala_client.py@141
PS3, Line 141: if not summary.nodes or len(summary.nodes) <= idx:
> Make sense. Done.
On second thought, it should be an assertion assert len(sumary.nodes) > idx. The reason being that before this change, accessing summary.nodex[idx] would throw an error if idx was out of range, but with this change, it will silently return. I think it best to let the caller know they have their index wrong.
http://gerrit.cloudera.org:8080/#/c/22626/3/tests/beeswax/impala_beeswax.py
File tests/beeswax/impala_beeswax.py:
http://gerrit.cloudera.org:8080/#/c/22626/3/tests/beeswax/impala_beeswax.py@398
PS3, Line 398: return None
> Done
Done
http://gerrit.cloudera.org:8080/#/c/22626/3/tests/common/impala_connection.py
File tests/common/impala_connection.py:
http://gerrit.cloudera.org:8080/#/c/22626/3/tests/common/impala_connection.py@113
PS3, Line 113:
> Unfortunately, start-impala-cluster.py does not work if I do that.
Ah, that explains it. I withdraw the comment.
http://gerrit.cloudera.org:8080/#/c/22626/3/tests/common/impala_connection.py@305
PS3, Line 305:
> Done
Done
http://gerrit.cloudera.org:8080/#/c/22626/3/tests/common/impala_connection.py@487
PS3, Line 487: t, user
> Done
Done
http://gerrit.cloudera.org:8080/#/c/22626/3/tests/custom_cluster/test_executor_groups.py
File tests/custom_cluster/test_executor_groups.py:
http://gerrit.cloudera.org:8080/#/c/22626/3/tests/custom_cluster/test_executor_groups.py@a1053
PS3, Line 1053:
> Yes. Custom cluster test will recreate clients on each for each test method
Thanks!
http://gerrit.cloudera.org:8080/#/c/22626/3/tests/custom_cluster/test_executor_groups.py@992
PS3, Line 992: self.hs2_client.set_configuration_option(k, v)
> Done
Done
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Mar 2025 23:14:02 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18604/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Mar 2025 00:55:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18609/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Mar 2025 20:45:05 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22626/5/shell/impala_client.py
File shell/impala_client.py:
http://gerrit.cloudera.org:8080/#/c/22626/5/shell/impala_client.py@113
PS5, Line 113: class QueryOptionLevels:
: """These are the levels used when displaying query options.
> Got a feedback from Csaba that this ideally should be in its own python fil
Done
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Mar 2025 18:43:49 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 7:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18662/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 7
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Mar 2025 15:31:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18643/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Mar 2025 22:52:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 4:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/22626/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/22626/3//COMMIT_MSG@15
PS3, Line 15: by
> Nit: by
Done
http://gerrit.cloudera.org:8080/#/c/22626/3/shell/impala_client.py
File shell/impala_client.py:
http://gerrit.cloudera.org:8080/#/c/22626/3/shell/impala_client.py@141
PS3, Line 141: if not summary.nodes or len(summary.nodes) <= idx:
> Would it make sense to also return if len(summary.nodes) <= idx? Not havin
Make sense. Done.
http://gerrit.cloudera.org:8080/#/c/22626/3/tests/beeswax/impala_beeswax.py
File tests/beeswax/impala_beeswax.py:
http://gerrit.cloudera.org:8080/#/c/22626/3/tests/beeswax/impala_beeswax.py@398
PS3, Line 398: return None
> Can you please add a note about this change to the commit message?
Done
http://gerrit.cloudera.org:8080/#/c/22626/3/tests/common/impala_connection.py
File tests/common/impala_connection.py:
http://gerrit.cloudera.org:8080/#/c/22626/3/tests/common/impala_connection.py@113
PS3, Line 113:
> Even though this import is only used here, please consider moving it to the
Unfortunately, start-impala-cluster.py does not work if I do that.
$ bin/start-impala-cluster.py
Traceback (most recent call last):
File "bin/start-impala-cluster.py", line 39, in <module>
from tests.common.impala_cluster import (ImpalaCluster, DEFAULT_BEESWAX_PORT,
File "/home/rsuminto/workspace/impala/tests/common/impala_cluster.py", line 37, in <module>
from tests.common.impala_service import (
File "/home/rsuminto/workspace/impala/tests/common/impala_service.py", line 34, in <module>
from tests.common.impala_connection import create_connection, create_ldap_connection
File "/home/rsuminto/workspace/impala/tests/common/impala_connection.py", line 36, in <module>
from shell.impala_client import build_exec_summary_table
File "/home/rsuminto/workspace/impala/shell/impala_client.py", line 21, in <module>
from compatibility import _xrange as xrange
ModuleNotFoundError: No module named 'compatibility'
http://gerrit.cloudera.org:8080/#/c/22626/3/tests/common/impala_connection.py@305
PS3, Line 305:
> Nit: passed
Done
http://gerrit.cloudera.org:8080/#/c/22626/3/tests/common/impala_connection.py@487
PS3, Line 487: t, user
> Nit: supports
Done
http://gerrit.cloudera.org:8080/#/c/22626/3/tests/custom_cluster/test_executor_groups.py
File tests/custom_cluster/test_executor_groups.py:
http://gerrit.cloudera.org:8080/#/c/22626/3/tests/custom_cluster/test_executor_groups.py@a1053
PS3, Line 1053:
> Does self.hs2_client get re-initialized before this test begins executing?
Yes. Custom cluster test will recreate clients on each for each test method, because it restart Impala cluster.
https://github.com/apache/impala/blob/master/tests/common/custom_cluster_test_suite.py#L365
http://gerrit.cloudera.org:8080/#/c/22626/3/tests/custom_cluster/test_executor_groups.py@992
PS3, Line 992: self.hs2_client.set_configuration_option(k, v)
> Please note this change in the commit message.
Done
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Mar 2025 22:27:07 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, Jason Fehr, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22626
to look at the new patch set (#4).
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
This patch implement building exec summary table for
ImpylaHS2Connection. It adds fetch_exec_summary argument in
ImpalaConnection.execute(). If this argument is True, an exec summary
table will be added into the returned result object.
fetch_exec_summary is also implemented for BeeswaxConnection. Thus,
BeeswaxConnection will not fetch exec summary by default all the time.
Tests that validate exec summary table is updated to set
fetch_exec_summary=True and migrated to test against hs2 protocol.
Change TestExecutorGroup._set_query_options() to do query option setting
through hs2_client iconfig instead of SET query. Some flake8 issues are
addressed as well.
Tweak build_exec_summary_table a bit to return early if given
TExecSummary is empty.
Fixed bug in ImpalaBeeswaxClient.fetch_results() where fetch will not
happen at all if discard_result argument is True.
Testing:
- Run and pass affected tests locally.
Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
---
M shell/impala_client.py
M tests/beeswax/impala_beeswax.py
M tests/common/impala_connection.py
M tests/custom_cluster/test_executor_groups.py
M tests/query_test/test_hash_join_timer.py
M tests/query_test/test_insert.py
M tests/query_test/test_observability.py
7 files changed, 166 insertions(+), 96 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/22626/4
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 2:
(6 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/22626/2/tests/common/impala_connection.py
File tests/common/impala_connection.py:
http://gerrit.cloudera.org:8080/#/c/22626/2/tests/common/impala_connection.py@290
PS2, Line 290: s
flake8: U100 Unused argument 'sql_stmt'
http://gerrit.cloudera.org:8080/#/c/22626/2/tests/common/impala_connection.py@290
PS2, Line 290: u
flake8: U100 Unused argument 'user'
http://gerrit.cloudera.org:8080/#/c/22626/2/tests/common/impala_connection.py@290
PS2, Line 290: f
flake8: U100 Unused argument 'fetch_profile_after_close'
http://gerrit.cloudera.org:8080/#/c/22626/2/tests/common/impala_connection.py@291
PS2, Line 291: f
flake8: U100 Unused argument 'fetch_exec_summary'
http://gerrit.cloudera.org:8080/#/c/22626/2/tests/common/impala_connection.py@291
PS2, Line 291: p
flake8: U100 Unused argument 'profile_format'
http://gerrit.cloudera.org:8080/#/c/22626/2/tests/common/impala_connection.py@391
PS2, Line 391: o
flake8: U100 Unused argument 'operation_handle'
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Mar 2025 01:09:13 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, Jason Fehr, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22626
to look at the new patch set (#5).
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
This patch implement building exec summary table for
ImpylaHS2Connection. It adds fetch_exec_summary argument in
ImpalaConnection.execute(). If this argument is True, an exec summary
table will be added into the returned result object.
fetch_exec_summary is also implemented for BeeswaxConnection. Thus,
BeeswaxConnection will not fetch exec summary by default all the time.
Tests that validate exec summary table is updated to set
fetch_exec_summary=True and migrated to test against hs2 protocol.
Change TestExecutorGroup._set_query_options() to do query option setting
through hs2_client iconfig instead of SET query. Some flake8 issues are
addressed as well.
Tweak build_exec_summary_table a bit to return early if given
TExecSummary is empty.
Fixed bug in ImpalaBeeswaxClient.fetch_results() where fetch will not
happen at all if discard_result argument is True.
Testing:
- Run and pass affected tests locally.
Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
---
M shell/impala_client.py
M tests/beeswax/impala_beeswax.py
M tests/common/impala_connection.py
M tests/custom_cluster/test_executor_groups.py
M tests/query_test/test_hash_join_timer.py
M tests/query_test/test_insert.py
M tests/query_test/test_observability.py
7 files changed, 169 insertions(+), 96 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/22626/5
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18645/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Mar 2025 04:06:17 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Mar 2025 20:36:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22626
to look at the new patch set (#3).
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
This patch implement building exec summary table for
ImpylaHS2Connection. It adds fetch_exec_summary argument in
ImpalaConnection.execute(). If this argument is True, an exec summary
table will be added into the returned result object.
fetch_exec_summary is also implemented for BeeswaxConnection. Thus,
BeeswaxConnection will not fetch exec summary be default all the time.
Tests that validate exec summary table is updated to set
fetch_exec_summary=True and migrated to test against hs2 protocol. Some
flake8 issues are addressed as well.
Tweak build_exec_summary_table a bit to return early if given
TExecSummary is empty.
Testing:
- Run and pass affected tests locally.
Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
---
M shell/impala_client.py
M tests/beeswax/impala_beeswax.py
M tests/common/impala_connection.py
M tests/custom_cluster/test_executor_groups.py
M tests/query_test/test_hash_join_timer.py
M tests/query_test/test_insert.py
M tests/query_test/test_observability.py
7 files changed, 164 insertions(+), 95 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/22626/3
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
This patch implement building exec summary table for
ImpylaHS2Connection. It adds fetch_exec_summary argument in
ImpalaConnection.execute(). If this argument is True, an exec summary
table will be added into the returned result object.
fetch_exec_summary is also implemented for BeeswaxConnection. Thus,
BeeswaxConnection will not fetch exec summary by default all the time.
Tests that validate exec summary table is updated to set
fetch_exec_summary=True and migrated to test against hs2 protocol.
Change TestExecutorGroup._set_query_options() to do query option setting
through hs2_client iconfig instead of SET query. Some flake8 issues are
addressed as well.
Move build_exec_summary_table to separate exec_summary.py file. Tweak it
a bit to return early if given TExecSummary is empty.
Fixed bug in ImpalaBeeswaxClient.fetch_results() where fetch will not
happen at all if discard_result argument is True.
Testing:
- Run and pass affected tests locally.
Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Reviewed-on: http://gerrit.cloudera.org:8080/22626
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
A shell/exec_summary.py
M shell/impala_client.py
M shell/packaging/make_python_package.sh
M tests/beeswax/impala_beeswax.py
M tests/common/impala_connection.py
M tests/custom_cluster/test_coordinators.py
M tests/custom_cluster/test_executor_groups.py
M tests/query_test/test_hash_join_timer.py
M tests/query_test/test_insert.py
M tests/query_test/test_observability.py
10 files changed, 344 insertions(+), 244 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 12
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, Jason Fehr, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22626
to look at the new patch set (#10).
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
This patch implement building exec summary table for
ImpylaHS2Connection. It adds fetch_exec_summary argument in
ImpalaConnection.execute(). If this argument is True, an exec summary
table will be added into the returned result object.
fetch_exec_summary is also implemented for BeeswaxConnection. Thus,
BeeswaxConnection will not fetch exec summary by default all the time.
Tests that validate exec summary table is updated to set
fetch_exec_summary=True and migrated to test against hs2 protocol.
Change TestExecutorGroup._set_query_options() to do query option setting
through hs2_client iconfig instead of SET query. Some flake8 issues are
addressed as well.
Move build_exec_summary_table to separate exec_summary.py file. Tweak it
a bit to return early if given TExecSummary is empty.
Fixed bug in ImpalaBeeswaxClient.fetch_results() where fetch will not
happen at all if discard_result argument is True.
Testing:
- Run and pass affected tests locally.
Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
---
A shell/exec_summary.py
M shell/impala_client.py
M shell/packaging/make_python_package.sh
M tests/beeswax/impala_beeswax.py
M tests/common/impala_connection.py
M tests/custom_cluster/test_coordinators.py
M tests/custom_cluster/test_executor_groups.py
M tests/query_test/test_hash_join_timer.py
M tests/query_test/test_insert.py
M tests/query_test/test_observability.py
10 files changed, 344 insertions(+), 244 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/22626/10
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 10
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 10:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18671/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 10
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Mar 2025 17:35:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 8: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11639/
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 8
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Mar 2025 20:36:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 6:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22626/6/shell/impala_client.py
File shell/impala_client.py:
http://gerrit.cloudera.org:8080/#/c/22626/6/shell/impala_client.py@48
PS6, Line 48: from exec_summary import build_exec_summary_table
Looks like there is an import confusion going here. Here is one fail occurrence:
custom_cluster/test_client_keepalive.py:100: in test_ssl_keepalive
self.check_keepalive(vector, ssl=True)
custom_cluster/test_client_keepalive.py:78: in check_keepalive
result = run_impala_shell_cmd(vector, shell_options)
shell/util.py:137: in run_impala_shell_cmd
result.stderr)
E AssertionError: Cmd ['-q', 'shell sleep 1 && ss -Hton sport = 21000', '--ssl'] was expected to succeed: Traceback (most recent call last):
E File "/usr/lib/python2.7/runpy.py", line 174, in _run_module_as_main
E "__main__", fname, loader, pkg_name)
E File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
E exec code in run_globals
E File "/home/ubuntu/Impala/shell/build/impala-shell-5.0.0-SNAPSHOT/install_py2.7/impala_shell/impala_shell.py", line 43, in <module>
E from impala_client import ImpalaHS2Client, StrictHS2Client, \
E File "/home/ubuntu/Impala/shell/build/impala-shell-5.0.0-SNAPSHOT/install_py2.7/impala_shell/impala_client.py", line 48, in <module>
E from exec_summary import build_exec_summary_table
E ImportError: No module named exec_summary
I'll try moving this inside build_summary_table function.
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Mar 2025 14:54:09 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22626
to look at the new patch set (#2).
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
This patch implement building exec summary table for
ImpylaHS2Connection. It adds fetch_exec_summary argument in
ImpalaConnection.execute(). If this argument is True, an exec summary
table will be added into the returned result object.
fetch_exec_summary is also implemented for BeeswaxConnection. Thus,
BeeswaxConnection will not fetch exec summary be default all the time.
Tests that validate exec summary table is updated to set
fetch_exec_summary=True and migrated to test against hs2 protocol. Some
flake8 issues are addressed as well.
Testing:
- Run and pass affected tests locally.
Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
---
M tests/beeswax/impala_beeswax.py
M tests/common/impala_connection.py
M tests/custom_cluster/test_executor_groups.py
M tests/query_test/test_hash_join_timer.py
M tests/query_test/test_insert.py
M tests/query_test/test_observability.py
6 files changed, 155 insertions(+), 88 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/22626/2
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22626/3/shell/impala_client.py
File shell/impala_client.py:
http://gerrit.cloudera.org:8080/#/c/22626/3/shell/impala_client.py@141
PS3, Line 141: if not summary.nodes:
> On second thought, it should be an assertion assert len(sumary.nodes) > idx
Done in patch set 5.
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Mar 2025 03:41:55 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 11:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11644/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 11
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Mar 2025 17:11:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 6: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11636/
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Mar 2025 08:51:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, Jason Fehr, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22626
to look at the new patch set (#6).
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
This patch implement building exec summary table for
ImpylaHS2Connection. It adds fetch_exec_summary argument in
ImpalaConnection.execute(). If this argument is True, an exec summary
table will be added into the returned result object.
fetch_exec_summary is also implemented for BeeswaxConnection. Thus,
BeeswaxConnection will not fetch exec summary by default all the time.
Tests that validate exec summary table is updated to set
fetch_exec_summary=True and migrated to test against hs2 protocol.
Change TestExecutorGroup._set_query_options() to do query option setting
through hs2_client iconfig instead of SET query. Some flake8 issues are
addressed as well.
Move build_exec_summary_table to separate exec_summary.py file. Tweak it
a bit to return early if given TExecSummary is empty.
Fixed bug in ImpalaBeeswaxClient.fetch_results() where fetch will not
happen at all if discard_result argument is True.
Testing:
- Run and pass affected tests locally.
Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
---
A shell/exec_summary.py
M shell/impala_client.py
M tests/beeswax/impala_beeswax.py
M tests/common/impala_connection.py
M tests/custom_cluster/test_executor_groups.py
M tests/query_test/test_hash_join_timer.py
M tests/query_test/test_insert.py
M tests/query_test/test_observability.py
8 files changed, 335 insertions(+), 242 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/22626/6
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 3:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/22626/3//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/22626/3//COMMIT_MSG@15
PS3, Line 15: be
Nit: by
http://gerrit.cloudera.org:8080/#/c/22626/3/shell/impala_client.py
File shell/impala_client.py:
http://gerrit.cloudera.org:8080/#/c/22626/3/shell/impala_client.py@141
PS3, Line 141: if not summary.nodes:
Would it make sense to also return if len(summary.nodes) <= idx? Not having this check has not caused issues to date, so the check probably doesn't need to be added.
http://gerrit.cloudera.org:8080/#/c/22626/3/tests/beeswax/impala_beeswax.py
File tests/beeswax/impala_beeswax.py:
http://gerrit.cloudera.org:8080/#/c/22626/3/tests/beeswax/impala_beeswax.py@398
PS3, Line 398: return None
Can you please add a note about this change to the commit message?
http://gerrit.cloudera.org:8080/#/c/22626/3/tests/common/impala_connection.py
File tests/common/impala_connection.py:
http://gerrit.cloudera.org:8080/#/c/22626/3/tests/common/impala_connection.py@113
PS3, Line 113: from shell.impala_client import build_exec_summary_table
Even though this import is only used here, please consider moving it to the top of the file since there is where imports are expected to be.
http://gerrit.cloudera.org:8080/#/c/22626/3/tests/common/impala_connection.py@305
PS3, Line 305: pass
Nit: passed
http://gerrit.cloudera.org:8080/#/c/22626/3/tests/common/impala_connection.py@487
PS3, Line 487: support
Nit: supports
http://gerrit.cloudera.org:8080/#/c/22626/3/tests/custom_cluster/test_executor_groups.py
File tests/custom_cluster/test_executor_groups.py:
http://gerrit.cloudera.org:8080/#/c/22626/3/tests/custom_cluster/test_executor_groups.py@a1053
PS3, Line 1053:
Does self.hs2_client get re-initialized before this test begins executing? If not, configuration from other tests will leak into this test.
http://gerrit.cloudera.org:8080/#/c/22626/3/tests/custom_cluster/test_executor_groups.py@992
PS3, Line 992: self.hs2_client.set_configuration_option(k, v)
Please note this change in the commit message.
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 19 Mar 2025 20:34:15 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, Jason Fehr, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22626
to look at the new patch set (#7).
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
This patch implement building exec summary table for
ImpylaHS2Connection. It adds fetch_exec_summary argument in
ImpalaConnection.execute(). If this argument is True, an exec summary
table will be added into the returned result object.
fetch_exec_summary is also implemented for BeeswaxConnection. Thus,
BeeswaxConnection will not fetch exec summary by default all the time.
Tests that validate exec summary table is updated to set
fetch_exec_summary=True and migrated to test against hs2 protocol.
Change TestExecutorGroup._set_query_options() to do query option setting
through hs2_client iconfig instead of SET query. Some flake8 issues are
addressed as well.
Move build_exec_summary_table to separate exec_summary.py file. Tweak it
a bit to return early if given TExecSummary is empty.
Fixed bug in ImpalaBeeswaxClient.fetch_results() where fetch will not
happen at all if discard_result argument is True.
Testing:
- Run and pass affected tests locally.
Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
---
A shell/exec_summary.py
M shell/impala_client.py
M tests/beeswax/impala_beeswax.py
M tests/common/impala_connection.py
M tests/custom_cluster/test_executor_groups.py
M tests/query_test/test_hash_join_timer.py
M tests/query_test/test_insert.py
M tests/query_test/test_observability.py
8 files changed, 335 insertions(+), 242 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/22626/7
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 7
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 8
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Mar 2025 15:05:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Daniel Becker, Jason Fehr, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22626
to look at the new patch set (#9).
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
This patch implement building exec summary table for
ImpylaHS2Connection. It adds fetch_exec_summary argument in
ImpalaConnection.execute(). If this argument is True, an exec summary
table will be added into the returned result object.
fetch_exec_summary is also implemented for BeeswaxConnection. Thus,
BeeswaxConnection will not fetch exec summary by default all the time.
Tests that validate exec summary table is updated to set
fetch_exec_summary=True and migrated to test against hs2 protocol.
Change TestExecutorGroup._set_query_options() to do query option setting
through hs2_client iconfig instead of SET query. Some flake8 issues are
addressed as well.
Move build_exec_summary_table to separate exec_summary.py file. Tweak it
a bit to return early if given TExecSummary is empty.
Fixed bug in ImpalaBeeswaxClient.fetch_results() where fetch will not
happen at all if discard_result argument is True.
Testing:
- Run and pass affected tests locally.
Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
---
A shell/exec_summary.py
M shell/impala_client.py
M shell/packaging/make_python_package.sh
M tests/beeswax/impala_beeswax.py
M tests/common/impala_connection.py
M tests/custom_cluster/test_coordinators.py
M tests/custom_cluster/test_executor_groups.py
M tests/query_test/test_hash_join_timer.py
M tests/query_test/test_insert.py
M tests/query_test/test_observability.py
10 files changed, 344 insertions(+), 244 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/26/22626/9
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 9
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 8:
> Patch Set 8: Verified-1
>
> Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11639/
Forgot to update make_python_package.sh and MinimalHS2Connection in impala_connection.py
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 8
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Sun, 23 Mar 2025 04:23:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18606/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Mar 2025 01:34:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22626/1/tests/custom_cluster/test_executor_groups.py
File tests/custom_cluster/test_executor_groups.py:
http://gerrit.cloudera.org:8080/#/c/22626/1/tests/custom_cluster/test_executor_groups.py@996
PS1, Line 996: fetch_exec_summary=False):
> This can be simpler without calling __verify_fs_writers inside this method.
Done
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Mar 2025 01:07:49 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 3:
(6 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/22626/3/tests/common/impala_connection.py
File tests/common/impala_connection.py:
http://gerrit.cloudera.org:8080/#/c/22626/3/tests/common/impala_connection.py@290
PS3, Line 290: s
flake8: U100 Unused argument 'sql_stmt'
http://gerrit.cloudera.org:8080/#/c/22626/3/tests/common/impala_connection.py@290
PS3, Line 290: u
flake8: U100 Unused argument 'user'
http://gerrit.cloudera.org:8080/#/c/22626/3/tests/common/impala_connection.py@290
PS3, Line 290: f
flake8: U100 Unused argument 'fetch_profile_after_close'
http://gerrit.cloudera.org:8080/#/c/22626/3/tests/common/impala_connection.py@291
PS3, Line 291: f
flake8: U100 Unused argument 'fetch_exec_summary'
http://gerrit.cloudera.org:8080/#/c/22626/3/tests/common/impala_connection.py@291
PS3, Line 291: p
flake8: U100 Unused argument 'profile_format'
http://gerrit.cloudera.org:8080/#/c/22626/3/tests/common/impala_connection.py@391
PS3, Line 391: o
flake8: U100 Unused argument 'operation_handle'
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Mar 2025 20:21:15 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 9:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11643/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 9
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Sun, 23 Mar 2025 04:35:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Jason Fehr (Code Review)" <ge...@cloudera.org>.
Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22626/3/shell/impala_client.py
File shell/impala_client.py:
http://gerrit.cloudera.org:8080/#/c/22626/3/shell/impala_client.py@141
PS3, Line 141: if not summary.nodes:
> Done in patch set 5.
Done
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Mar 2025 17:09:22 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 1:
(6 comments)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/22626/1/tests/common/impala_connection.py
File tests/common/impala_connection.py:
http://gerrit.cloudera.org:8080/#/c/22626/1/tests/common/impala_connection.py@290
PS1, Line 290: s
flake8: U100 Unused argument 'sql_stmt'
http://gerrit.cloudera.org:8080/#/c/22626/1/tests/common/impala_connection.py@290
PS1, Line 290: u
flake8: U100 Unused argument 'user'
http://gerrit.cloudera.org:8080/#/c/22626/1/tests/common/impala_connection.py@290
PS1, Line 290: f
flake8: U100 Unused argument 'fetch_profile_after_close'
http://gerrit.cloudera.org:8080/#/c/22626/1/tests/common/impala_connection.py@291
PS1, Line 291: f
flake8: U100 Unused argument 'fetch_exec_summary'
http://gerrit.cloudera.org:8080/#/c/22626/1/tests/common/impala_connection.py@291
PS1, Line 291: p
flake8: U100 Unused argument 'profile_format'
http://gerrit.cloudera.org:8080/#/c/22626/1/tests/common/impala_connection.py@391
PS1, Line 391: o
flake8: U100 Unused argument 'operation_handle'
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Mar 2025 00:27:14 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22626/1/tests/custom_cluster/test_executor_groups.py
File tests/custom_cluster/test_executor_groups.py:
http://gerrit.cloudera.org:8080/#/c/22626/1/tests/custom_cluster/test_executor_groups.py@996
PS1, Line 996: expected_num_writers=None, expected_instances_per_host=None
This can be simpler without calling __verify_fs_writers inside this method.
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Mar 2025 01:05:14 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 11: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 11
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Mar 2025 17:11:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 10: Code-Review+2
(1 comment)
Carry +2.
http://gerrit.cloudera.org:8080/#/c/22626/9/shell/impala_client.py
File shell/impala_client.py:
http://gerrit.cloudera.org:8080/#/c/22626/9/shell/impala_client.py@533
PS9, Line 533: def build_summary_table(self, summary, output):
> Why not import it at the beginning of the file? Doing it in the functions m
Done.
I can not make the same thing work for impala_beeswax.py and impala_connection.py.
Might need https://issues.apache.org/jira/browse/IMPALA-11980 work first.
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 10
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Mar 2025 17:10:16 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 9: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22626/9/shell/impala_client.py
File shell/impala_client.py:
http://gerrit.cloudera.org:8080/#/c/22626/9/shell/impala_client.py@533
PS9, Line 533: from exec_summary import build_exec_summary_table
Why not import it at the beginning of the file? Doing it in the functions means that if it can't be imported for some reason then we'll only learn this when running the function.
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 9
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Mar 2025 16:17:34 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 11: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 11
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Mar 2025 22:34:19 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 9:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18669/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 9
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Sun, 23 Mar 2025 05:02:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22626/5/shell/impala_client.py
File shell/impala_client.py:
http://gerrit.cloudera.org:8080/#/c/22626/5/shell/impala_client.py@113
PS5, Line 113: def build_exec_summary_table(summary, idx, indent_level, new_indent_level, output,
: is_prettyprint=True, separate_prefix_column=False):
Got a feedback from Csaba that this ideally should be in its own python file.
I'll check if I can do that.
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Thu, 20 Mar 2025 18:10:04 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
Carry +2.
http://gerrit.cloudera.org:8080/#/c/22626/6/shell/impala_client.py
File shell/impala_client.py:
http://gerrit.cloudera.org:8080/#/c/22626/6/shell/impala_client.py@48
PS6, Line 48: from kerberos_util import get_kerb_host_from_kerb
> Looks like there is an import confusion going here. Here is one fail occurr
Done
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 7
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Mar 2025 15:04:49 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 8:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11639/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 8
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Mar 2025 15:05:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13864: Implement ImpylaHS2ResultSet.exec summary
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................
Patch Set 9: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 9
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Sun, 23 Mar 2025 10:01:00 +0000
Gerrit-HasComments: No