You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jetspeed-dev@portals.apache.org by David Sean Taylor <da...@bluesunrise.com> on 2003/03/13 20:36:12 UTC
Pending Patches
There are several pending patches not committed.
Lets not let these patches slip.
I will try to review them this weekend, but I just haven't had much
time recently due to project crunch.
Could everyone possibly take just one patch, and commit it?
Tanks guyz
--
David Sean Taylor
Bluesunrise Software
david@bluesunrise.com
+01 707 773-4646
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jetspeed-dev-help@jakarta.apache.org
Re: PATCH LocalizationService
Posted by Massimiliano Dessi <ma...@gruppoatlantis.com>.
Hi Jon
I have choiche "conservative approach" .
For my site it's necessary change the language at runtime ,
but i don't know if Turbine used the service for other point of framework .
Extends the turbine service and rewrite only the method for change the
language
(and the classes around it ..CustomLocalization, CustomLocalizationTool and
CustomLocalizationService)
permit to use the service with the new functionality and avoid to
malfunction of Turbine;
I think that the work of Turbine Developers are great and I could' not added
nothing to the code of Turbine.
This is my solution , not necessary the best , but work fine in my site.
The problem of the bundles in my site are not compared because the
localization files are in one bundle and the content of
the portlet are searched in the database in more language.
I write the searchKey to manteine the approach more conservative possible.
Sorry for my bad english.
Massimiliano
----- Original Message -----
From: "Jon Evans" <jo...@misgl.com>
To: "Massimiliano Dessi" <ma...@gruppoatlantis.com>
Cc: "Jetspeed Developers List" <je...@jakarta.apache.org>;
<da...@bluesunrise.com>
Sent: Tuesday, March 18, 2003 11:12 AM
Subject: Re: PATCH LocalizationService
Hi Massimiliano,
Massimiliano Dessi wrote:
> Please see the attached patch.
>
> The different with the previous version it's the private method
> searchKey(Locale locale, String key)
> used by getString(String bundleName, Locale locale, String key).
> The key it's search in the firstbundle, if it' not found it's search in
the
> second and so on until the key it's found.
But, that functionality is already there in TurbineLocalizationService.
Why duplicate it?
Also I don't see the point of re-implementing all of the methods you
are overriding, then calling super.<method> every time. Isn't that the
whole point of extending another class? Why stop there, why not also
re-implement getClass() etc.? :-)
The only thing needed in JetspeedLocalizationService is the
functionality to choose a Locale based on a request parameter, that's
why my patch removed all methods except getLocale(RunData). It works
fine, and although I'm not using it in a production environment yet I
have 2 development sites using that code.
Jon
--
Merlin Information Systems Limited,
Merlin House, Gawcott Road, Buckingham, United Kingdom. MK18 1TN
Tel: +44 (0) 1280 824331 Fax: +44 (0) 1280 824112
http://www.misgl.com
Provider of IT Services and Online Portal Support Services.
Confidentiality:
The information contained in this email (including any attachments) is
confidential and is intended solely for the use of the named addressee.
Access, copying or re-use of the information in it by any other person is
not authorised. If you are not the intended recipient, please notify us
immediately by telephone or by e-mail to admin@misgl.com
*** This mail has been scanned for viruses ***
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jetspeed-dev-help@jakarta.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jetspeed-dev-help@jakarta.apache.org
Re: PATCH LocalizationService
Posted by Jon Evans <jo...@misgl.com>.
Hi Massimiliano,
Massimiliano Dessi wrote:
> Please see the attached patch.
>
> The different with the previous version it's the private method
> searchKey(Locale locale, String key)
> used by getString(String bundleName, Locale locale, String key).
> The key it's search in the firstbundle, if it' not found it's search in the
> second and so on until the key it's found.
But, that functionality is already there in TurbineLocalizationService.
Why duplicate it?
Also I don't see the point of re-implementing all of the methods you
are overriding, then calling super.<method> every time. Isn't that the
whole point of extending another class? Why stop there, why not also
re-implement getClass() etc.? :-)
The only thing needed in JetspeedLocalizationService is the
functionality to choose a Locale based on a request parameter, that's
why my patch removed all methods except getLocale(RunData). It works
fine, and although I'm not using it in a production environment yet I
have 2 development sites using that code.
Jon
--
Merlin Information Systems Limited,
Merlin House, Gawcott Road, Buckingham, United Kingdom. MK18 1TN
Tel: +44 (0) 1280 824331 Fax: +44 (0) 1280 824112
http://www.misgl.com
Provider of IT Services and Online Portal Support Services.
Confidentiality:
The information contained in this email (including any attachments) is confidential and is intended solely for the use of the named addressee. Access, copying or re-use of the information in it by any other person is not authorised. If you are not the intended recipient, please notify us immediately by telephone or by e-mail to admin@misgl.com
*** This mail has been scanned for viruses ***
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jetspeed-dev-help@jakarta.apache.org
PATCH LocalizationService
Posted by Massimiliano Dessi <ma...@gruppoatlantis.com>.
Please see the attached patch.
The different with the previous version it's the private method
searchKey(Locale locale, String key)
used by getString(String bundleName, Locale locale, String key).
The key it's search in the firstbundle, if it' not found it's search in the
second and so on until the key it's found.
Massimiliano.
----- Original Message -----
From: "David Sean Taylor" <da...@bluesunrise.com>
To: "Jetspeed Developers List" <je...@jakarta.apache.org>
Sent: Thursday, March 13, 2003 9:02 PM
Subject: Re: Pending Patches
>
> On Thursday, March 13, 2003, at 11:51 AM, Mark Orciuch wrote:
>
> >>
> >> There are several pending patches not committed.
> >> Lets not let these patches slip.
> >> I will try to review them this weekend, but I just haven't had much
> >> time recently due to project crunch.
> >> Could everyone possibly take just one patch, and commit it?
> >>
> >
> > Here's what I know about because it's logged in Bugzilla:
> >
> > 1. Psml browser/customizer error when language specific psml exists -
> > http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16627
> >
> > 2. Cleanup logging -
> > http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15214
> >
> > 3. MVCPortlet Proposal -
> > http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17756
> >
> > 4. Sub-Category Filtering -
> > http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17839
> >
> > I already assigned myself to the first one.
> >
> > Could you publish a list of outstanding patches? How do you keep track
> > of
> > them? I think all patches should have a corresponding Bugzilla number
> > and
> > some sort of indicator that would make it come up on 'Outstanding
> > Patches
> > Report' (perhaps adding value 'Patch' in 'Severity').
> >
> The patches are sent to the jetspeed-dev list.
> We can ask that people also log it in bugzilla, no guarantee that they
> will do it.
>
> - Jeremy Ford' s patch to Portlet Customizer
> - Shinsuke SUGAYA's patch to all users disable
> - Jon Evans and Massimiliano Dessi's localization patch
>
> --
> David Sean Taylor
> Bluesunrise Software
> david@bluesunrise.com
> +01 707 773-4646
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: jetspeed-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: jetspeed-dev-help@jakarta.apache.org
>
>
Re: Pending Patches
Posted by Shinsuke SUGAYA <sh...@yahoo.co.jp>.
I have filed "all users disable" bug.
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17998
Regards,
shinsuke
David Sean Taylor wrote:
>
> On Thursday, March 13, 2003, at 11:51 AM, Mark Orciuch wrote:
>
>>>
>>> There are several pending patches not committed.
>>> Lets not let these patches slip.
>>> I will try to review them this weekend, but I just haven't had much
>>> time recently due to project crunch.
>>> Could everyone possibly take just one patch, and commit it?
>>>
>>
>> Here's what I know about because it's logged in Bugzilla:
>>
>> 1. Psml browser/customizer error when language specific psml exists -
>> http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16627
>>
>> 2. Cleanup logging -
>> http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15214
>>
>> 3. MVCPortlet Proposal -
>> http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17756
>>
>> 4. Sub-Category Filtering -
>> http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17839
>>
>> I already assigned myself to the first one.
>>
>> Could you publish a list of outstanding patches? How do you keep track of
>> them? I think all patches should have a corresponding Bugzilla number and
>> some sort of indicator that would make it come up on 'Outstanding Patches
>> Report' (perhaps adding value 'Patch' in 'Severity').
>>
> The patches are sent to the jetspeed-dev list.
> We can ask that people also log it in bugzilla, no guarantee that they
> will do it.
>
> - Jeremy Ford' s patch to Portlet Customizer
> - Shinsuke SUGAYA's patch to all users disable
> - Jon Evans and Massimiliano Dessi's localization patch
>
> --
> David Sean Taylor
> Bluesunrise Software
> david@bluesunrise.com
> +01 707 773-4646
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: jetspeed-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: jetspeed-dev-help@jakarta.apache.org
>
__________________________________________________
Do You Yahoo!?
Yahoo! BB is Broadband by Yahoo! http://bb.yahoo.co.jp/
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jetspeed-dev-help@jakarta.apache.org
Re: Pending Patches
Posted by David Sean Taylor <da...@bluesunrise.com>.
On Thursday, March 13, 2003, at 11:51 AM, Mark Orciuch wrote:
>>
>> There are several pending patches not committed.
>> Lets not let these patches slip.
>> I will try to review them this weekend, but I just haven't had much
>> time recently due to project crunch.
>> Could everyone possibly take just one patch, and commit it?
>>
>
> Here's what I know about because it's logged in Bugzilla:
>
> 1. Psml browser/customizer error when language specific psml exists -
> http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16627
>
> 2. Cleanup logging -
> http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15214
>
> 3. MVCPortlet Proposal -
> http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17756
>
> 4. Sub-Category Filtering -
> http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17839
>
> I already assigned myself to the first one.
>
> Could you publish a list of outstanding patches? How do you keep track
> of
> them? I think all patches should have a corresponding Bugzilla number
> and
> some sort of indicator that would make it come up on 'Outstanding
> Patches
> Report' (perhaps adding value 'Patch' in 'Severity').
>
The patches are sent to the jetspeed-dev list.
We can ask that people also log it in bugzilla, no guarantee that they
will do it.
- Jeremy Ford' s patch to Portlet Customizer
- Shinsuke SUGAYA's patch to all users disable
- Jon Evans and Massimiliano Dessi's localization patch
--
David Sean Taylor
Bluesunrise Software
david@bluesunrise.com
+01 707 773-4646
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jetspeed-dev-help@jakarta.apache.org
RE: Pending Patches
Posted by Mark Orciuch <ma...@yahoo.com>.
>
> There are several pending patches not committed.
> Lets not let these patches slip.
> I will try to review them this weekend, but I just haven't had much
> time recently due to project crunch.
> Could everyone possibly take just one patch, and commit it?
>
Here's what I know about because it's logged in Bugzilla:
1. Psml browser/customizer error when language specific psml exists -
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=16627
2. Cleanup logging - http://nagoya.apache.org/bugzilla/show_bug.cgi?id=15214
3. MVCPortlet Proposal -
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17756
4. Sub-Category Filtering -
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=17839
I already assigned myself to the first one.
Could you publish a list of outstanding patches? How do you keep track of
them? I think all patches should have a corresponding Bugzilla number and
some sort of indicator that would make it come up on 'Outstanding Patches
Report' (perhaps adding value 'Patch' in 'Severity').
Best regards,
Mark Orciuch - morciuch@apache.org
Jakarta Jetspeed - Enterprise Portal in Java
http://jakarta.apache.org/jetspeed/
---------------------------------------------------------------------
To unsubscribe, e-mail: jetspeed-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jetspeed-dev-help@jakarta.apache.org