You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "justinwwhuang (via GitHub)" <gi...@apache.org> on 2024/02/21 03:29:35 UTC
[PR] [INLONG-9716][Agent] Delete useless code when storing tasks [inlong]
justinwwhuang opened a new pull request, #9717:
URL: https://github.com/apache/inlong/pull/9717
[INLONG-9716][Agent] Delete useless code when storing tasks
- Fixes #XYZ
### Motivation
Delete useless code when storing tasks
### Modifications
Delete useless code when storing tasks
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-9716][Agent] Delete useless code when storing tasks [inlong]
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang merged PR #9717:
URL: https://github.com/apache/inlong/pull/9717
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-9716][Agent] Delete useless code when storing tasks [inlong]
Posted by "justinwwhuang (via GitHub)" <gi...@apache.org>.
justinwwhuang commented on code in PR #9717:
URL: https://github.com/apache/inlong/pull/9717#discussion_r1496965946
##########
inlong-agent/agent-common/src/main/java/org/apache/inlong/agent/db/TaskProfileDb.java:
##########
@@ -63,7 +62,7 @@ public void storeTask(TaskProfile task) {
if (task.allRequiredKeyExist()) {
String keyName = getKeyByTaskId(task.getTaskId());
KeyValueEntity entity = new KeyValueEntity(keyName,
- task.toJsonStr(), task.get(TaskConstants.FILE_DIR_FILTER_PATTERNS));
+ task.toJsonStr(), "");
Review Comment:
For task configuration, it is not possible to fill in specific files here, and we do not need file names as indexes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-9716][Agent] Delete useless code when storing tasks [inlong]
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang commented on code in PR #9717:
URL: https://github.com/apache/inlong/pull/9717#discussion_r1496905727
##########
inlong-agent/agent-common/src/main/java/org/apache/inlong/agent/db/TaskProfileDb.java:
##########
@@ -63,7 +62,7 @@ public void storeTask(TaskProfile task) {
if (task.allRequiredKeyExist()) {
String keyName = getKeyByTaskId(task.getTaskId());
KeyValueEntity entity = new KeyValueEntity(keyName,
- task.toJsonStr(), task.get(TaskConstants.FILE_DIR_FILTER_PATTERNS));
+ task.toJsonStr(), "");
Review Comment:
why put an empty value here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org