You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "eitsupi (via GitHub)" <gi...@apache.org> on 2025/12/17 15:05:16 UTC

[PR] ci(r): Ensure testing with the local version of driver manager instead of the cran version [arrow-adbc]

eitsupi opened a new pull request, #3817:
URL: https://github.com/apache/arrow-adbc/pull/3817

   Related to #3789
   
   Looking at the logs, it seems that the current CI was using adbcdrivermanager installed from CRAN, and testing of the latest driver and driver manager combinations had not been performed.
   This PR will make a change to ensure that adbcdrivermanager is installed locally.
   
   This required a minor change to prevent the bootstrap.R script from failing with `pak::pkg_install("local::.")` or something else.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci(r): Ensure testing with the local version of driver manager instead of the cran version [arrow-adbc]

Posted by "eitsupi (via GitHub)" <gi...@apache.org>.
eitsupi commented on PR #3817:
URL: https://github.com/apache/arrow-adbc/pull/3817#issuecomment-3665816264

   When I reverted the changes made by #3790 (e42eff2), I was able to confirm that, as intended, this change caused the test failures pointed out by #3789 to occur in CI.
   
   ```
    ══ Failed tests ════════════════════════════════════════════════════════════════
   ── Error ('test-adbcsqlite-package.R:108:3'): write_adbc() with temporary = TRUE works with sqlite databases ──
   <adbc_status_invalid_argument/adbc_status/simpleError/error/condition>
   Error in `adbc_database_set_options(database, options)`: INVALID_ARGUMENT: [Driver Manager] Invalid URI: missing scheme
   Backtrace:
       ▆
    1. ├─adbcdrivermanager::adbc_database_init(adbcsqlite(), uri = temp_db) at test-adbcsqlite-package.R:108:3
    2. └─adbcsqlite:::adbc_database_init.adbcsqlite_driver_sqlite(...)
    3.   └─adbcdrivermanager::adbc_database_init_default(...) at adbcsqlite/R/adbcsqlite-package.R:56:3
    4.     ├─adbcdrivermanager::with_adbc(...)
    5.     │ └─base::force(code)
    6.     └─adbcdrivermanager::adbc_database_set_options(database, options)
    7.       └─adbcdrivermanager:::stop_for_error(status, error)
   ── Error ('test-adbcsqlite-package.R:137:3'): write_adbc() supports mode replace/create_append ──
   <adbc_status_internal/adbc_status/simpleError/error/condition>
   Error in `adbc_statement_execute_query(stmt)`: INTERNAL: failed to execute: table "df" already exists
   query was: CREATE TABLE main . "df" ("mpg" REAL, "cyl" REAL, "disp" REAL, "hp" REAL, "drat" REAL, "wt" REAL, "qsec" REAL, "vs" REAL, "am" REAL, "gear" REAL, "carb" REAL)
   Backtrace:
       ▆
    1. ├─adbcdrivermanager::write_adbc(mtcars, con, "df") at test-adbcsqlite-package.R:137:3
    2. └─adbcdrivermanager:::write_adbc.default(mtcars, con, "df")
    3.   └─adbcdrivermanager::adbc_statement_execute_query(stmt)
    4.     └─adbcdrivermanager:::stop_for_error(result$status, error)
   
   [ FAIL 2 | WARN 0 | SKIP 0 | PASS 9 ]
   ```
   
   https://github.com/apache/arrow-adbc/actions/runs/20307485536/job/58328893736?pr=3817


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci(r): Ensure testing with the local version of driver manager instead of the cran version [arrow-adbc]

Posted by "eitsupi (via GitHub)" <gi...@apache.org>.
eitsupi commented on PR #3817:
URL: https://github.com/apache/arrow-adbc/pull/3817#issuecomment-3665937966

   > Something is awry here:
   
   Maybe #3818


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci(r): Ensure testing with the local version of driver manager instead of the cran version [arrow-adbc]

Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #3817:
URL: https://github.com/apache/arrow-adbc/pull/3817#issuecomment-3665930436

   Thank you for this!
   
   For `check-go` I see:
   
   ```
   go: go.mod requires go >= 1.25.0 (running go 1.24.11; GOTOOLCHAIN=local)
   ```
   
   and
   
   ```
   Warning: go-version input was not specified. The action will try to use pre-installed version.
   ```
   
   Something is awry here:
   
   https://github.com/apache/arrow-adbc/blob/c1b77b848f25db3840944307adf123a3cc4f54de/.github/workflows/r-check.yml#L48-L53


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] ci(r): ensure testing with the local version of driver manager instead of the cran version [arrow-adbc]

Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot merged PR #3817:
URL: https://github.com/apache/arrow-adbc/pull/3817


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org