[GitHub] [pinot] richardstartin commented on a diff in pull request #8523: Add tracing for operator planning

[GitBox <gi...@apache.org>]

richardstartin commented on code in PR #8523:
URL: https://github.com/apache/pinot/pull/8523#discussion_r848927822


##########
pinot-core/src/main/java/org/apache/pinot/core/plan/CombinePlanNode.java:
##########
@@ -73,87 +76,31 @@ public CombinePlanNode(List<PlanNode> planNodes, QueryContext queryContext, Exec
     _streamObserver = streamObserver;
   }
 
-  @SuppressWarnings({"rawtypes", "unchecked"})
   @Override
   public BaseCombineOperator run() {
-    int numPlanNodes = _planNodes.size();
-    List<Operator> operators = new ArrayList<>(numPlanNodes);
+    try (InvocationScope ignored = Tracing.getTracer().createScope(CombinePlanNode.class)) {

Review Comment:
   record the number of children



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org